From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B7EC49EA6 for ; Fri, 25 Jun 2021 02:09:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEC94613B9 for ; Fri, 25 Jun 2021 02:09:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AEC94613B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 421B8825; Fri, 25 Jun 2021 04:08:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 421B8825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624586941; bh=DNI820eTAB6xYmNz1WkJfTBfSbRxhVXFj0cFpknPe9s=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=crOjT7/MBBp7GwgNSfxBFFfGuLaymNS+zRIPuxgwQohlh8yMvzjCg4T7jleDIhsxu y+4q/WL0PnMp1kLwyBXmpT2814w9li9JTNI8HnYCuPOYYaEm/zMZfj7DfsqqbFIh6P suXEpRrcGsEyFCyezBRwOZCDLM3PL4x8uL7cbpKk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AF118F8016D; Fri, 25 Jun 2021 04:08:10 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 26C01F801D5; Fri, 25 Jun 2021 04:08:03 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AB16DF8012C for ; Fri, 25 Jun 2021 04:07:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AB16DF8012C Received: by m.b4.vu (Postfix, from userid 1000) id 4094561E5F02; Fri, 25 Jun 2021 11:37:48 +0930 (ACST) Date: Fri, 25 Jun 2021 11:37:48 +0930 From: "Geoffrey D. Bennett" To: Nathan Chancellor Subject: Re: [PATCH] ALSA: usb-audio: scarlett2: Fix for loop increment in scarlett2_usb_get_config Message-ID: <20210625020748.GA21766@m.b4.vu> References: <20210624212048.1356136-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624212048.1356136-1-nathan@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Takashi Iwai , clang-built-linux@googlegroups.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Jun 24, 2021 at 02:20:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > sound/usb/mixer_scarlett_gen2.c:1189:32: warning: expression result > unused [-Wunused-value] > for (i = 0; i < count; i++, (u16 *)buf++) > ^ ~~~~~ > 1 warning generated. > > It appears the intention was to cast the void pointer to a u16 pointer > so that the data could be iterated through like an array of u16 values. > However, the cast happens after the increment because a cast is an > rvalue, whereas the post-increment operator only works on lvalues, so > the loop does not iterate as expected. > > Replace the post-increment shorthand with the full expression so the > cast can be added in the right place and the look works as expected. look -> loop > Fixes: ac34df733d2d ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion") > Link: https://github.com/ClangBuiltLinux/linux/issues/1408 > Signed-off-by: Nathan Chancellor > --- > sound/usb/mixer_scarlett_gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > index fcba682cd422..c20c7f1ddc50 100644 > --- a/sound/usb/mixer_scarlett_gen2.c > +++ b/sound/usb/mixer_scarlett_gen2.c > @@ -1186,7 +1186,7 @@ static int scarlett2_usb_get_config( > if (err < 0) > return err; > if (size == 2) > - for (i = 0; i < count; i++, (u16 *)buf++) > + for (i = 0; i < count; i++, buf = (u16 *)buf + 1) > *(u16 *)buf = le16_to_cpu(*(__le16 *)buf); > return 0; > } Thanks Nathan! FYI: although incorrect, this caused no bug as there is not yet any case where count > 1. Acked-by: Geoffrey D. Bennett From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD94AC49EA5 for ; Fri, 25 Jun 2021 02:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A464A60FE9 for ; Fri, 25 Jun 2021 02:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbhFYCQp (ORCPT ); Thu, 24 Jun 2021 22:16:45 -0400 Received: from m.b4.vu ([203.16.231.148]:53408 "EHLO m.b4.vu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232917AbhFYCQn (ORCPT ); Thu, 24 Jun 2021 22:16:43 -0400 X-Greylist: delayed 394 seconds by postgrey-1.27 at vger.kernel.org; Thu, 24 Jun 2021 22:16:43 EDT Received: by m.b4.vu (Postfix, from userid 1000) id 4094561E5F02; Fri, 25 Jun 2021 11:37:48 +0930 (ACST) Date: Fri, 25 Jun 2021 11:37:48 +0930 From: "Geoffrey D. Bennett" To: Nathan Chancellor Cc: Jaroslav Kysela , Takashi Iwai , Nick Desaulniers , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] ALSA: usb-audio: scarlett2: Fix for loop increment in scarlett2_usb_get_config Message-ID: <20210625020748.GA21766@m.b4.vu> References: <20210624212048.1356136-1-nathan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624212048.1356136-1-nathan@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 02:20:48PM -0700, Nathan Chancellor wrote: > Clang warns: > > sound/usb/mixer_scarlett_gen2.c:1189:32: warning: expression result > unused [-Wunused-value] > for (i = 0; i < count; i++, (u16 *)buf++) > ^ ~~~~~ > 1 warning generated. > > It appears the intention was to cast the void pointer to a u16 pointer > so that the data could be iterated through like an array of u16 values. > However, the cast happens after the increment because a cast is an > rvalue, whereas the post-increment operator only works on lvalues, so > the loop does not iterate as expected. > > Replace the post-increment shorthand with the full expression so the > cast can be added in the right place and the look works as expected. look -> loop > Fixes: ac34df733d2d ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion") > Link: https://github.com/ClangBuiltLinux/linux/issues/1408 > Signed-off-by: Nathan Chancellor > --- > sound/usb/mixer_scarlett_gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > index fcba682cd422..c20c7f1ddc50 100644 > --- a/sound/usb/mixer_scarlett_gen2.c > +++ b/sound/usb/mixer_scarlett_gen2.c > @@ -1186,7 +1186,7 @@ static int scarlett2_usb_get_config( > if (err < 0) > return err; > if (size == 2) > - for (i = 0; i < count; i++, (u16 *)buf++) > + for (i = 0; i < count; i++, buf = (u16 *)buf + 1) > *(u16 *)buf = le16_to_cpu(*(__le16 *)buf); > return 0; > } Thanks Nathan! FYI: although incorrect, this caused no bug as there is not yet any case where count > 1. Acked-by: Geoffrey D. Bennett