From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] block: remove REQ_OP_SCSI_{IN,OUT}
Date: Fri, 25 Jun 2021 07:37:51 +0200 [thread overview]
Message-ID: <20210625053751.GA22164@lst.de> (raw)
In-Reply-To: <BYAPR04MB4965F273BBD2CBD0958B44FE86079@BYAPR04MB4965.namprd04.prod.outlook.com>
On Thu, Jun 24, 2021 at 10:57:44PM +0000, Chaitanya Kulkarni wrote:
> On 6/24/21 05:40, Christoph Hellwig wrote:
> > With the legacy IDE driver gone drivers now use either REQ_OP_DRV_*
> > or REQ_OP_SCSI_*, so unify the two concepts of passthrough requests
> > into a single one.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Nice cleanup, we got two bits free for new req_op.
We could in fact easily reduce REQ_OP_BITS to 5 now with space to spare.
But we haven't run out of flags bits quite yet.
next prev parent reply other threads:[~2021-06-25 5:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 12:39 [PATCH 1/2] block: remove REQ_OP_SCSI_{IN,OUT} Christoph Hellwig
2021-06-24 12:39 ` [PATCH 2/2] nvme Christoph Hellwig
2021-06-24 12:42 ` Christoph Hellwig
2021-06-24 22:57 ` [PATCH 1/2] block: remove REQ_OP_SCSI_{IN,OUT} Chaitanya Kulkarni
2021-06-25 5:37 ` Christoph Hellwig [this message]
2021-06-25 0:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210625053751.GA22164@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.