From: "Trevor Woerner" <twoerner@gmail.com>
To: yocto@lists.yoctoproject.org
Subject: Re: [meta-rockchip][PATCH v2] console cleanup
Date: Sun, 27 Jun 2021 14:45:58 -0400 [thread overview]
Message-ID: <20210627184558.GA29335@localhost> (raw)
In-Reply-To: <20210624123959.10105-1-twoerner@gmail.com>
On Thu 2021-06-24 @ 08:39:59 AM, Trevor Woerner wrote:
> Consolidate all the various console definitions to the common
> conf/machine/include/rockchip-defaults.inc file and create
> RK_CONSOLE_BAUD and RK_CONSOLE_DEVICE variables that can be
> reused in the wks files.
>
> The following variables were checked before and after this patch
> to make sure they are sensible:
> - SERIAL_CONSOLES
> - RK_CONSOLE_DEVICE
> - RK_CONSOLE_BAUD
>
> A boot test was performed on the following boards to make sure
> they all continue to boot to a cmdline:
> - tinker-board
> - rock-pi-e
> - nanopi-m4-2gb
> - rock64
> - rock-pi-4b
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> Changes from v1:
> - In v1 I defined RK_CONSOLE_BAUD and RK_CONSOLE_DEVICE for each MACHINE
> and then redefined SERIAL_CONSOLES to be the concatenation of these two
> variables. Khem pointed out this is a bad approach because I'm redefining
> an oe-core-defined variable that all BSPs expect.
> - In v2 I set/consolidate SERIAL_CONSOLES for each MACHINE and then generate
> RK_CONSOLE_BAUD and RK_CONSOLE_DEVICE based on the first-defined
> <baud>;<device> pair found in SERIAL_CONSOLES; these generated variables are
> then used in the wks files.
Applied to meta-rockchip master.
prev parent reply other threads:[~2021-06-27 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 12:39 [meta-rockchip][PATCH v2] console cleanup Trevor Woerner
2021-06-24 17:36 ` [yocto] " Khem Raj
2021-06-24 20:00 ` Trevor Woerner
2021-06-27 18:45 ` Trevor Woerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210627184558.GA29335@localhost \
--to=twoerner@gmail.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.