All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] boot/uboot: fix uboot build
Date: Mon, 28 Jun 2021 22:26:56 +0200	[thread overview]
Message-ID: <20210628202656.GD2829@scaer> (raw)
In-Reply-To: <20210325173459.7d902f53@kmaincent-XPS-13-7390>

K?ry, All,

On 2021-03-25 17:34 +0100, K?ry Maincent spake thusly:
> On Tue, 16 Mar 2021 23:08:52 +0100
> Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> > On Thu,  4 Feb 2021 18:04:46 +0100
> > Kory Maincent <kory.maincent@bootlin.com> wrote:
> > > The make all command run the tools/makefile on the process.
> > > This makefile use "pkg-config" command to support static link.
> > > The issue is the use of pkg-config configured for crosscompiling
> > > to build binaries tools for host architecture.
> > > To fix it, I copied the behavior of QtWebengine by using a pkg-config
> > > executable preconfigured for host.
> > > 
> > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> > Thanks for the patch. It would require a better commit title though, as
> > "fix uboot build" is very vague.
> Ok I will change it for v2.

> > After discussing with Yann E. Morin on IRC, could you try this change
> > instead:
> > 
> > 	$(TARGET_CONFIGURE_OPTS) \
> > 	        PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
> >         	PKG_CONFIG_SYSROOT_DIR="/" \
> > 	        PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 \
> > 	        PKG_CONFIG_ALLOW_SYSTEM_LIBS=1 \
> > 	        PKG_CONFIG_LIBDIR="$(HOST_DIR)/lib/pkgconfig:$(HOST_DIR)/share/pkgconfig"
> > 
> > The reasoning is that U-Boot anyway only uses pkg-config for host
> > tools, so we could just as well pass those environment variables when
> > building U-Boot.
> > 
> > Could you try this out?
> 
> This change works well, the build of U-boot ends properly.

I don't seem to have seen a v2 of this patch. Do you plan on sending it
soonish? ;-)

Thanks!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  parent reply	other threads:[~2021-06-28 20:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 17:04 [Buildroot] [PATCH] boot/uboot: fix uboot build Kory Maincent
2021-03-16 22:08 ` Thomas Petazzoni
2021-03-25 16:34   ` Köry Maincent
2021-03-25 16:36     ` Thomas Petazzoni
2021-06-28 20:26     ` Yann E. MORIN [this message]
2021-06-29 12:47       ` Köry Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628202656.GD2829@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.