From: Mel Gorman <mgorman@techsingularity.net>
To: Wonhyuk Yang <vvghjk1234@gmail.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v2] mm/compaction: fix 'limit' in fast_isolate_freepages
Date: Tue, 29 Jun 2021 14:52:03 +0100 [thread overview]
Message-ID: <20210629135203.GF3840@techsingularity.net> (raw)
In-Reply-To: <20210626082443.22547-1-vvghjk1234@gmail.com>
On Sat, Jun 26, 2021 at 05:24:43PM +0900, Wonhyuk Yang wrote:
> Because of 'min(1, ...)', fast_isolate_freepages set 'limit'
> to 0 or 1. This takes away the opportunities of find candinate
> pages. So, by making enough scans available, increases the
> probability of finding the appropriate freepage.
>
> Tested it on the thpscale and the results are as follows.
>
> 5.12.0 5.12.0
> valnilla patched
> Amean fault-both-1 598.15 ( 0.00%) 592.56 ( 0.93%)
> Amean fault-both-3 1494.47 ( 0.00%) 1514.35 ( -1.33%)
> Amean fault-both-5 2519.48 ( 0.00%) 2471.76 ( 1.89%)
> Amean fault-both-7 3173.85 ( 0.00%) 3079.19 ( 2.98%)
> Amean fault-both-12 8063.83 ( 0.00%) 7858.29 ( 2.55%)
> Amean fault-both-18 8781.20 ( 0.00%) 7827.70 * 10.86%*
> Amean fault-both-24 12576.44 ( 0.00%) 12250.20 ( 2.59%)
> Amean fault-both-30 18503.27 ( 0.00%) 17528.11 * 5.27%*
> Amean fault-both-32 16133.69 ( 0.00%) 13874.24 * 14.00%*
>
> 5.12.0 5.12.0
> vanilla patched
> Ops Compaction migrate scanned 6547133.00 5963901.00
> Ops Compaction free scanned 32452453.00 26609101.00
>
> 5.12 5.12
> vanilla patched
> Duration User 27.99 28.84
> Duration System 244.08 236.76
> Duration Elapsed 78.27 78.38
>
> Fixes: 5a811889de10f ("mm, compaction: use free lists to quickly locate a migration target")
> Signed-off-by: Wonhyuk Yang <vvghjk1234@gmail.com>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
--
Mel Gorman
SUSE Labs
prev parent reply other threads:[~2021-06-29 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 8:24 [PATCH v2] mm/compaction: fix 'limit' in fast_isolate_freepages Wonhyuk Yang
2021-06-29 13:52 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629135203.GF3840@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=vvghjk1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.