From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxarm@huawei.com, mauro.chehab@huawei.com,
Lee Jones <lee.jones@linaro.org>, Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform drvdata
Date: Tue, 29 Jun 2021 15:32:20 +0200 [thread overview]
Message-ID: <20210629153220.52fffece@coco.lan> (raw)
In-Reply-To: <CAFRkauCPKQyD_Dooqrxvra94RyLXrPDeCSSdfBfvh-o0Zh8q3g@mail.gmail.com>
Em Tue, 29 Jun 2021 20:51:01 +0800
Axel Lin <axel.lin@ingics.com> escreveu:
> > If you're in doubt, try to apply this series, and then change the
> > driver again to use platform data. You'll see that it will stop
> > booting after initializing the first regulator.
> >
>
> Sorry I don't have this h/w to test.
Then, why do you care? Your patch broke the driver. Changes like
that should be tested on a real hardware, in order to avoid
regressions.
Thanks,
Mauro
next prev parent reply other threads:[~2021-06-29 13:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 10:31 [PATCH v10 0/5] Move Hisilicon 6421v600 SPMI and USB drivers out of staging Mauro Carvalho Chehab
2021-06-29 10:31 ` Mauro Carvalho Chehab
2021-06-29 10:31 ` [PATCH v10 1/5] staging: hikey9xx: split hi6421v600 irq into a separate driver Mauro Carvalho Chehab
2021-06-29 10:31 ` [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform drvdata Mauro Carvalho Chehab
[not found] ` <CAFRkauCzHqUfva+zTRhOyiMMb4WsKPHvYJuqpOPwy+siPMZGOQ@mail.gmail.com>
2021-06-29 11:09 ` Mauro Carvalho Chehab
[not found] ` <CAFRkauCPKQyD_Dooqrxvra94RyLXrPDeCSSdfBfvh-o0Zh8q3g@mail.gmail.com>
2021-06-29 13:32 ` Mauro Carvalho Chehab [this message]
2021-06-29 15:11 ` Mark Brown
2021-06-29 19:31 ` Mauro Carvalho Chehab
2021-06-30 8:20 ` Mauro Carvalho Chehab
2021-06-29 10:31 ` [PATCH v10 3/5] mfd: hi6421-spmi-pmic: move driver from staging Mauro Carvalho Chehab
2021-07-01 14:02 ` Rob Herring
2021-06-29 10:31 ` [PATCH v10 4/5] dts: hisilicon: add support for the PMIC found on Hikey 970 Mauro Carvalho Chehab
2021-06-29 10:31 ` Mauro Carvalho Chehab
2021-06-29 10:31 ` [PATCH v10 5/5] dts: hisilicon: add support for USB3 " Mauro Carvalho Chehab
2021-06-29 10:31 ` Mauro Carvalho Chehab
2021-06-29 10:43 ` [PATCH v10 0/5] Move Hisilicon 6421v600 SPMI and USB drivers out of staging Greg Kroah-Hartman
2021-06-29 10:43 ` Greg Kroah-Hartman
2021-06-30 8:28 ` Mauro Carvalho Chehab
2021-06-30 8:28 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629153220.52fffece@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.