From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E40C1C11F65 for ; Wed, 30 Jun 2021 14:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C64AF61447 for ; Wed, 30 Jun 2021 14:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236158AbhF3OC5 (ORCPT ); Wed, 30 Jun 2021 10:02:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:42880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235714AbhF3OCQ (ORCPT ); Wed, 30 Jun 2021 10:02:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3BAB61433; Wed, 30 Jun 2021 13:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625061587; bh=v5OBimTBlCfEF3FaB0xZQ7fhYUBBxeJ8vnG2hTzl9Cs=; h=From:To:Cc:Subject:Date:From; b=UhLf0L0iSKvyXCME1IfDYudvAIZPdd4PQmpptJiSx+90b7BBLlGxrREffX1Tex0ya TpbhJ/jPRSrwKQHYtnhLNUohgPV//0fLxm892CGhORXa/KRy7R2rYHnukRj/rHrOG9 7QYbyaDeh6F1DS+6CUuULIWbRoetgplaBYx61UWB/TdFUFCZLrTpyprYfN1ZkXCy1V FQOaotL2JSAehjffWlpXVcsNQnCCGt9ST1/Pt57yKMo58wpe0lxiRh6kKAHCeO1KFP wtDeAu7Ae1k68QDqviz1hjokeXEPS7w8NWqMbLYwNJRTc+QH5p/E/Nal/DgHNikB1W TJK1eUYXdly0w== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Viresh Kumar , Gregory CLEMENT Cc: Robert Marko , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Konstantin Porotchkin , nnet , Nadav Haklai , =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Date: Wed, 30 Jun 2021 15:59:42 +0200 Message-Id: <20210630135942.29730-1-kabel@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The 1.2 GHz variant of the Armada 3720 SOC is unstable with DVFS: when the SOC boots, the WTMI firmware sets clocks and AVS values that work correctly with 1.2 GHz CPU frequency, but random crashes occur once cpufreq driver starts scaling. We do not know currently what is the reason: - it may be that the voltage value for L0 for 1.2 GHz variant provided by the vendor in the OTP is simply incorrect when scaling is used, - it may be that some delay is needed somewhere, - it may be something else. The most sane solution now seems to be to simply forbid the cpufreq driver on 1.2 GHz variant. Signed-off-by: Marek Behún Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") --- If someone from Marvell could look into this, it would be great since basically 1.2 GHz variant cannot scale, which is a feature that was claimed to be supported by the SOC. --- drivers/cpufreq/armada-37xx-cpufreq.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c index 3fc98a3ffd91..1ef3dde9a40b 100644 --- a/drivers/cpufreq/armada-37xx-cpufreq.c +++ b/drivers/cpufreq/armada-37xx-cpufreq.c @@ -104,7 +104,13 @@ struct armada_37xx_dvfs { }; static struct armada_37xx_dvfs armada_37xx_dvfs[] = { +#if 0 + /* + * The cpufreq scaling for 1.2 GHz variant of the SOC is currently + * unstable because we do not know how to configure it properly. + */ {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, +#endif {.cpu_freq_max = 1000*1000*1000, .divider = {1, 2, 4, 5} }, {.cpu_freq_max = 800*1000*1000, .divider = {1, 2, 3, 4} }, {.cpu_freq_max = 600*1000*1000, .divider = {2, 4, 5, 6} }, -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 788EAC11F65 for ; Wed, 30 Jun 2021 14:21:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42AF96143F for ; Wed, 30 Jun 2021 14:21:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42AF96143F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=x2GDUaLVwMzIf4eD+Adi4Dml0sT7qT9G+h2jrAoXkHw=; b=aOVz3YT9moLdgl dXyHYBG2GlEprLAtxkhFurWSi1kwWFEtgJ6KwwD12jlWUb6EeS2xOCSP94urq1UXVuneb8f59HgmI yfhFK00K8Vjpuw8mx7xQdXZjxp0oCvPpr9nibnjqzxzmH1O7QVoHTz6dBS6OM37CIbkcSmg376+q3 ZBVhAJWiFV7ALuJ1BtwkKEDVC5jfbySdU2uUgOSkXHMzqvsP60+iqEUdG+7RzwMqIvvZj1YUKCaGL FmGJcxIs2h51cUqWDRuwbuK6xZksBg5Ry6ZFt8iPCwHIuN2eOWvLFax6VHefqfm8DMJQp+LI0vBhX VJZxEgG7A2H+3liNqqWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyb3E-00EKLh-CN; Wed, 30 Jun 2021 14:18:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyakm-00EEdo-HG for linux-arm-kernel@lists.infradead.org; Wed, 30 Jun 2021 13:59:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C3BAB61433; Wed, 30 Jun 2021 13:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625061587; bh=v5OBimTBlCfEF3FaB0xZQ7fhYUBBxeJ8vnG2hTzl9Cs=; h=From:To:Cc:Subject:Date:From; b=UhLf0L0iSKvyXCME1IfDYudvAIZPdd4PQmpptJiSx+90b7BBLlGxrREffX1Tex0ya TpbhJ/jPRSrwKQHYtnhLNUohgPV//0fLxm892CGhORXa/KRy7R2rYHnukRj/rHrOG9 7QYbyaDeh6F1DS+6CUuULIWbRoetgplaBYx61UWB/TdFUFCZLrTpyprYfN1ZkXCy1V FQOaotL2JSAehjffWlpXVcsNQnCCGt9ST1/Pt57yKMo58wpe0lxiRh6kKAHCeO1KFP wtDeAu7Ae1k68QDqviz1hjokeXEPS7w8NWqMbLYwNJRTc+QH5p/E/Nal/DgHNikB1W TJK1eUYXdly0w== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Viresh Kumar , Gregory CLEMENT Cc: Robert Marko , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Konstantin Porotchkin , nnet , Nadav Haklai , =?UTF-8?q?Marek=20Beh=C3=BAn?= , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Date: Wed, 30 Jun 2021 15:59:42 +0200 Message-Id: <20210630135942.29730-1-kabel@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210630_065948_674938_228C18E9 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIDEuMiBHSHogdmFyaWFudCBvZiB0aGUgQXJtYWRhIDM3MjAgU09DIGlzIHVuc3RhYmxlIHdp dGggRFZGUzogd2hlbgp0aGUgU09DIGJvb3RzLCB0aGUgV1RNSSBmaXJtd2FyZSBzZXRzIGNsb2Nr cyBhbmQgQVZTIHZhbHVlcyB0aGF0IHdvcmsKY29ycmVjdGx5IHdpdGggMS4yIEdIeiBDUFUgZnJl cXVlbmN5LCBidXQgcmFuZG9tIGNyYXNoZXMgb2NjdXIgb25jZQpjcHVmcmVxIGRyaXZlciBzdGFy dHMgc2NhbGluZy4KCldlIGRvIG5vdCBrbm93IGN1cnJlbnRseSB3aGF0IGlzIHRoZSByZWFzb246 Ci0gaXQgbWF5IGJlIHRoYXQgdGhlIHZvbHRhZ2UgdmFsdWUgZm9yIEwwIGZvciAxLjIgR0h6IHZh cmlhbnQgcHJvdmlkZWQKICBieSB0aGUgdmVuZG9yIGluIHRoZSBPVFAgaXMgc2ltcGx5IGluY29y cmVjdCB3aGVuIHNjYWxpbmcgaXMgdXNlZCwKLSBpdCBtYXkgYmUgdGhhdCBzb21lIGRlbGF5IGlz IG5lZWRlZCBzb21ld2hlcmUsCi0gaXQgbWF5IGJlIHNvbWV0aGluZyBlbHNlLgoKVGhlIG1vc3Qg c2FuZSBzb2x1dGlvbiBub3cgc2VlbXMgdG8gYmUgdG8gc2ltcGx5IGZvcmJpZCB0aGUgY3B1ZnJl cQpkcml2ZXIgb24gMS4yIEdIeiB2YXJpYW50LgoKU2lnbmVkLW9mZi1ieTogTWFyZWsgQmVow7pu IDxrYWJlbEBrZXJuZWwuaW9yZz4KRml4ZXM6IDkyY2U0NWZiODc1ZCAoImNwdWZyZXE6IEFkZCBE VkZTIHN1cHBvcnQgZm9yIEFybWFkYSAzN3h4IikKLS0tCklmIHNvbWVvbmUgZnJvbSBNYXJ2ZWxs IGNvdWxkIGxvb2sgaW50byB0aGlzLCBpdCB3b3VsZCBiZSBncmVhdCBzaW5jZQpiYXNpY2FsbHkg MS4yIEdIeiB2YXJpYW50IGNhbm5vdCBzY2FsZSwgd2hpY2ggaXMgYSBmZWF0dXJlIHRoYXQgd2Fz CmNsYWltZWQgdG8gYmUgc3VwcG9ydGVkIGJ5IHRoZSBTT0MuCi0tLQogZHJpdmVycy9jcHVmcmVx L2FybWFkYS0zN3h4LWNwdWZyZXEuYyB8IDYgKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9jcHVmcmVxL2FybWFkYS0zN3h4LWNwdWZy ZXEuYyBiL2RyaXZlcnMvY3B1ZnJlcS9hcm1hZGEtMzd4eC1jcHVmcmVxLmMKaW5kZXggM2ZjOThh M2ZmZDkxLi4xZWYzZGRlOWE0MGIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvY3B1ZnJlcS9hcm1hZGEt Mzd4eC1jcHVmcmVxLmMKKysrIGIvZHJpdmVycy9jcHVmcmVxL2FybWFkYS0zN3h4LWNwdWZyZXEu YwpAQCAtMTA0LDcgKzEwNCwxMyBAQCBzdHJ1Y3QgYXJtYWRhXzM3eHhfZHZmcyB7CiB9OwogCiBz dGF0aWMgc3RydWN0IGFybWFkYV8zN3h4X2R2ZnMgYXJtYWRhXzM3eHhfZHZmc1tdID0geworI2lm IDAKKwkvKgorCSAqIFRoZSBjcHVmcmVxIHNjYWxpbmcgZm9yIDEuMiBHSHogdmFyaWFudCBvZiB0 aGUgU09DIGlzIGN1cnJlbnRseQorCSAqIHVuc3RhYmxlIGJlY2F1c2Ugd2UgZG8gbm90IGtub3cg aG93IHRvIGNvbmZpZ3VyZSBpdCBwcm9wZXJseS4KKwkgKi8KIAl7LmNwdV9mcmVxX21heCA9IDEy MDAqMTAwMCoxMDAwLCAuZGl2aWRlciA9IHsxLCAyLCA0LCA2fSB9LAorI2VuZGlmCiAJey5jcHVf ZnJlcV9tYXggPSAxMDAwKjEwMDAqMTAwMCwgLmRpdmlkZXIgPSB7MSwgMiwgNCwgNX0gfSwKIAl7 LmNwdV9mcmVxX21heCA9IDgwMCoxMDAwKjEwMDAsICAuZGl2aWRlciA9IHsxLCAyLCAzLCA0fSB9 LAogCXsuY3B1X2ZyZXFfbWF4ID0gNjAwKjEwMDAqMTAwMCwgIC5kaXZpZGVyID0gezIsIDQsIDUs IDZ9IH0sCi0tIAoyLjMxLjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==