From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E55C11F66 for ; Wed, 30 Jun 2021 22:56:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 568A861449 for ; Wed, 30 Jun 2021 22:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232705AbhF3W6h (ORCPT ); Wed, 30 Jun 2021 18:58:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232397AbhF3W6g (ORCPT ); Wed, 30 Jun 2021 18:58:36 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3F54613D1; Wed, 30 Jun 2021 22:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625093767; bh=1XbpMrAHLknLLoDhzLADpsI4YXpwMU7vvfhNLq5DXh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gg1GriXGY/N+rrmX/YSR1NIBzGTRhex6grbfuCbGsS6L6q2SqsXM358PqRyWjLxZ5 BflxoiOroAxRzWQKMbH2C+RkkuTWE3nwdn5WYL/Cz4g6Dz+qmzC/TJ17plQq3iqTM+ 87fQuZOABInlaf0b4jUMep1lOaAv0YzKr4U58J24rScMqI8vUcoZVuQdrz0wMddd3+ bwEeXbhY4NHPISSA8PxEOmlzK5k4/tNzWHijTkB7OgBmzoI9uDu5Wu3hbdtVmGn9PK W1jV216OcTVSPfxfv0is6LuaWRd1I24Wr8Wuok/c9n5S+InXTOqY8MWinIrsB4FqlM MkyTrTnahYjKw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Viresh Kumar , Gregory CLEMENT , Ken Ma , Victor Gu Cc: Robert Marko , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Konstantin Porotchkin , nnet , Nadav Haklai , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Date: Thu, 1 Jul 2021 00:56:01 +0200 Message-Id: <20210630225601.6372-1-kabel@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210630135942.29730-1-kabel@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The 1.2 GHz variant of the Armada 3720 SOC is unstable with DVFS: when the SOC boots, the WTMI firmware sets clocks and AVS values that work correctly with 1.2 GHz CPU frequency, but random crashes occur once cpufreq driver starts scaling. We do not know currently what is the reason: - it may be that the voltage value for L0 for 1.2 GHz variant provided by the vendor in the OTP is simply incorrect when scaling is used, - it may be that some delay is needed somewhere, - it may be something else. The most sane solution now seems to be to simply forbid the cpufreq driver on 1.2 GHz variant. Signed-off-by: Marek Behún Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") --- If someone from Marvell could look into this, it would be great since basically 1.2 GHz variant cannot scale, which is a feature that was claimed to be supported by the SOC. Ken Ma / Victor Gu, you have worked on commit https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/d6719fdc2b3cac58064f41b531f86993c919aa9a in linux-marvell. Your patch takes away the 1202 mV constant for 1.2 GHz base CPU frequency and instead adds code that computes the voltages from the voltage found in L0 AVS register (which is filled in by WTMI firmware). Do you know why the code does not work correctly for some 1.2 GHz boards? Do we need to force the L0 voltage to 1202 mV if it is lower, or something? --- drivers/cpufreq/armada-37xx-cpufreq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c index 3fc98a3ffd91..c10fc33b29b1 100644 --- a/drivers/cpufreq/armada-37xx-cpufreq.c +++ b/drivers/cpufreq/armada-37xx-cpufreq.c @@ -104,7 +104,11 @@ struct armada_37xx_dvfs { }; static struct armada_37xx_dvfs armada_37xx_dvfs[] = { - {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, + /* + * The cpufreq scaling for 1.2 GHz variant of the SOC is currently + * unstable because we do not know how to configure it properly. + */ + /* {.cpu_freq_max = 1200*1000*1000, .divider = {1, 2, 4, 6} }, */ {.cpu_freq_max = 1000*1000*1000, .divider = {1, 2, 4, 5} }, {.cpu_freq_max = 800*1000*1000, .divider = {1, 2, 3, 4} }, {.cpu_freq_max = 600*1000*1000, .divider = {2, 4, 5, 6} }, -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B01C8C11F66 for ; Wed, 30 Jun 2021 22:57:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EED4613D1 for ; Wed, 30 Jun 2021 22:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EED4613D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GnJWf+MGkGRGzs3LLX560Rsxbtd4+M3UcEB3liw7rjE=; b=GEoSuslrrr92tW pCroKBeROlVQxyGYyjOc1q/R83qymNOckQ+e1GZ+zR1tILxuEL7BGH45RcKrNUMV2e+YGdEiB4WcR T+J3Yfj0elCyQB1wnfjCdpnDWsuDxoSpJcluT70L8Vjn0P36z8anbYOa+9DeumfM+kfQNtoUR786x 3R3bwjqpBCVca03+OR5tVx2l6AS5vbgCET8XsjFwMlk/SYD1Iu17pJWGps6V7ng0OYapz/QbYoXnL hABlGfKoWu9SliG/QxihfpDAlbbR6i8k1YwHLh9ffHiuFl9M2b3HmtolZKY3L6imk+aFq+0t2SR3R fBqf+jy9n2VzRgsHnXXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyj7r-00FSTE-Ow; Wed, 30 Jun 2021 22:56:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lyj7n-00FSSl-Te for linux-arm-kernel@lists.infradead.org; Wed, 30 Jun 2021 22:56:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3F54613D1; Wed, 30 Jun 2021 22:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625093767; bh=1XbpMrAHLknLLoDhzLADpsI4YXpwMU7vvfhNLq5DXh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gg1GriXGY/N+rrmX/YSR1NIBzGTRhex6grbfuCbGsS6L6q2SqsXM358PqRyWjLxZ5 BflxoiOroAxRzWQKMbH2C+RkkuTWE3nwdn5WYL/Cz4g6Dz+qmzC/TJ17plQq3iqTM+ 87fQuZOABInlaf0b4jUMep1lOaAv0YzKr4U58J24rScMqI8vUcoZVuQdrz0wMddd3+ bwEeXbhY4NHPISSA8PxEOmlzK5k4/tNzWHijTkB7OgBmzoI9uDu5Wu3hbdtVmGn9PK W1jV216OcTVSPfxfv0is6LuaWRd1I24Wr8Wuok/c9n5S+InXTOqY8MWinIrsB4FqlM MkyTrTnahYjKw== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Viresh Kumar , Gregory CLEMENT , Ken Ma , Victor Gu Cc: Robert Marko , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Tomasz Maciej Nowak , Anders Trier Olesen , Philip Soares , linux-pm@vger.kernel.org, Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, Konstantin Porotchkin , nnet , Nadav Haklai , =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH v2] cpufreq: armada-37xx: forbid cpufreq for 1.2 GHz variant Date: Thu, 1 Jul 2021 00:56:01 +0200 Message-Id: <20210630225601.6372-1-kabel@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210630135942.29730-1-kabel@kernel.org> References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210630_155608_034911_64783C41 X-CRM114-Status: GOOD ( 18.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlIDEuMiBHSHogdmFyaWFudCBvZiB0aGUgQXJtYWRhIDM3MjAgU09DIGlzIHVuc3RhYmxlIHdp dGggRFZGUzogd2hlbgp0aGUgU09DIGJvb3RzLCB0aGUgV1RNSSBmaXJtd2FyZSBzZXRzIGNsb2Nr cyBhbmQgQVZTIHZhbHVlcyB0aGF0IHdvcmsKY29ycmVjdGx5IHdpdGggMS4yIEdIeiBDUFUgZnJl cXVlbmN5LCBidXQgcmFuZG9tIGNyYXNoZXMgb2NjdXIgb25jZQpjcHVmcmVxIGRyaXZlciBzdGFy dHMgc2NhbGluZy4KCldlIGRvIG5vdCBrbm93IGN1cnJlbnRseSB3aGF0IGlzIHRoZSByZWFzb246 Ci0gaXQgbWF5IGJlIHRoYXQgdGhlIHZvbHRhZ2UgdmFsdWUgZm9yIEwwIGZvciAxLjIgR0h6IHZh cmlhbnQgcHJvdmlkZWQKICBieSB0aGUgdmVuZG9yIGluIHRoZSBPVFAgaXMgc2ltcGx5IGluY29y cmVjdCB3aGVuIHNjYWxpbmcgaXMgdXNlZCwKLSBpdCBtYXkgYmUgdGhhdCBzb21lIGRlbGF5IGlz IG5lZWRlZCBzb21ld2hlcmUsCi0gaXQgbWF5IGJlIHNvbWV0aGluZyBlbHNlLgoKVGhlIG1vc3Qg c2FuZSBzb2x1dGlvbiBub3cgc2VlbXMgdG8gYmUgdG8gc2ltcGx5IGZvcmJpZCB0aGUgY3B1ZnJl cQpkcml2ZXIgb24gMS4yIEdIeiB2YXJpYW50LgoKU2lnbmVkLW9mZi1ieTogTWFyZWsgQmVow7pu IDxrYWJlbEBrZXJuZWwub3JnPgpGaXhlczogOTJjZTQ1ZmI4NzVkICgiY3B1ZnJlcTogQWRkIERW RlMgc3VwcG9ydCBmb3IgQXJtYWRhIDM3eHgiKQotLS0KSWYgc29tZW9uZSBmcm9tIE1hcnZlbGwg Y291bGQgbG9vayBpbnRvIHRoaXMsIGl0IHdvdWxkIGJlIGdyZWF0IHNpbmNlCmJhc2ljYWxseSAx LjIgR0h6IHZhcmlhbnQgY2Fubm90IHNjYWxlLCB3aGljaCBpcyBhIGZlYXR1cmUgdGhhdCB3YXMK Y2xhaW1lZCB0byBiZSBzdXBwb3J0ZWQgYnkgdGhlIFNPQy4KCktlbiBNYSAvIFZpY3RvciBHdSwg eW91IGhhdmUgd29ya2VkIG9uIGNvbW1pdApodHRwczovL2dpdGh1Yi5jb20vTWFydmVsbEVtYmVk ZGVkUHJvY2Vzc29ycy9saW51eC1tYXJ2ZWxsL2NvbW1pdC9kNjcxOWZkYzJiM2NhYzU4MDY0ZjQx YjUzMWY4Njk5M2M5MTlhYTlhCmluIGxpbnV4LW1hcnZlbGwuCllvdXIgcGF0Y2ggdGFrZXMgYXdh eSB0aGUgMTIwMiBtViBjb25zdGFudCBmb3IgMS4yIEdIeiBiYXNlIENQVQpmcmVxdWVuY3kgYW5k IGluc3RlYWQgYWRkcyBjb2RlIHRoYXQgY29tcHV0ZXMgdGhlIHZvbHRhZ2VzIGZyb20gdGhlCnZv bHRhZ2UgZm91bmQgaW4gTDAgQVZTIHJlZ2lzdGVyICh3aGljaCBpcyBmaWxsZWQgaW4gYnkgV1RN SSBmaXJtd2FyZSkuCgpEbyB5b3Uga25vdyB3aHkgdGhlIGNvZGUgZG9lcyBub3Qgd29yayBjb3Jy ZWN0bHkgZm9yIHNvbWUgMS4yIEdIegpib2FyZHM/IERvIHdlIG5lZWQgdG8gZm9yY2UgdGhlIEww IHZvbHRhZ2UgdG8gMTIwMiBtViBpZiBpdCBpcyBsb3dlciwKb3Igc29tZXRoaW5nPwotLS0KIGRy aXZlcnMvY3B1ZnJlcS9hcm1hZGEtMzd4eC1jcHVmcmVxLmMgfCA2ICsrKysrLQogMSBmaWxlIGNo YW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvY3B1ZnJlcS9hcm1hZGEtMzd4eC1jcHVmcmVxLmMgYi9kcml2ZXJzL2NwdWZyZXEvYXJtYWRh LTM3eHgtY3B1ZnJlcS5jCmluZGV4IDNmYzk4YTNmZmQ5MS4uYzEwZmMzM2IyOWIxIDEwMDY0NAot LS0gYS9kcml2ZXJzL2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jCisrKyBiL2RyaXZlcnMv Y3B1ZnJlcS9hcm1hZGEtMzd4eC1jcHVmcmVxLmMKQEAgLTEwNCw3ICsxMDQsMTEgQEAgc3RydWN0 IGFybWFkYV8zN3h4X2R2ZnMgewogfTsKIAogc3RhdGljIHN0cnVjdCBhcm1hZGFfMzd4eF9kdmZz IGFybWFkYV8zN3h4X2R2ZnNbXSA9IHsKLQl7LmNwdV9mcmVxX21heCA9IDEyMDAqMTAwMCoxMDAw LCAuZGl2aWRlciA9IHsxLCAyLCA0LCA2fSB9LAorCS8qCisJICogVGhlIGNwdWZyZXEgc2NhbGlu ZyBmb3IgMS4yIEdIeiB2YXJpYW50IG9mIHRoZSBTT0MgaXMgY3VycmVudGx5CisJICogdW5zdGFi bGUgYmVjYXVzZSB3ZSBkbyBub3Qga25vdyBob3cgdG8gY29uZmlndXJlIGl0IHByb3Blcmx5Lgor CSAqLworCS8qIHsuY3B1X2ZyZXFfbWF4ID0gMTIwMCoxMDAwKjEwMDAsIC5kaXZpZGVyID0gezEs IDIsIDQsIDZ9IH0sICovCiAJey5jcHVfZnJlcV9tYXggPSAxMDAwKjEwMDAqMTAwMCwgLmRpdmlk ZXIgPSB7MSwgMiwgNCwgNX0gfSwKIAl7LmNwdV9mcmVxX21heCA9IDgwMCoxMDAwKjEwMDAsICAu ZGl2aWRlciA9IHsxLCAyLCAzLCA0fSB9LAogCXsuY3B1X2ZyZXFfbWF4ID0gNjAwKjEwMDAqMTAw MCwgIC5kaXZpZGVyID0gezIsIDQsIDUsIDZ9IH0sCi0tIAoyLjMxLjEKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==