From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9926AC11F67 for ; Thu, 1 Jul 2021 20:59:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7786D613F4 for ; Thu, 1 Jul 2021 20:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233217AbhGAVCI (ORCPT ); Thu, 1 Jul 2021 17:02:08 -0400 Received: from smtp1.axis.com ([195.60.68.17]:19115 "EHLO smtp1.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230063AbhGAVCI (ORCPT ); Thu, 1 Jul 2021 17:02:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1625173177; x=1656709177; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=53cbPrL/BqBfqsi+XFO6AhQ2NXIxqrG4Dytf1cbqaqk=; b=LAPjwtdAP423KIQlPYLTirsgllHL3P4FHut/sErwJwd+FuUa+qEGm7f8 Zi2OM9yhZSLWd0jxAWWuh3fWWTcY21c8BRQ8XuNTkzRvZ80PInw160bes mC6im8zw1r0FBTV3DXHR+I4cr2TgxVk/efA+2eIzJX01D34VJETj6SEfp +fqncTBiRTbYJqJAwot9InPIgN0LFMlRXjf1JsQZAxCelZ+NTaTRv5kMw iKLUhLu/tqfE+1Qqa5YUGMKL3PELdlwzz46OlifA8soaMdeCVSJX7FWP6 O0Nv5CGbhkX1ZHBhfMsYu/vflu/XQCj7uDcxgsPRIBvZAg9Ab+ROUQKP6 Q==; Date: Thu, 1 Jul 2021 22:59:36 +0200 From: Jesper Nilsson To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= CC: Jesper Nilsson , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , "linux-pci@vger.kernel.org" Subject: Re: [PATCH v2 1/2] PCI: artpec6: Remove surplus break statement after return Message-ID: <20210701205936.GN6299@axis.com> References: <20210701204401.1636562-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210701204401.1636562-1-kw@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Thu, Jul 01, 2021 at 10:44:00PM +0200, Krzysztof Wilczyński wrote: > As part of code refactoring completed in the commit a0fd361db8e5 ("PCI: > dwc: Move "dbi", "dbi2", and "addr_space" resource setup into common > code") the function artpec6_add_pcie_ep() has been removed and the call > to the dw_pcie_ep_init() has been moved into artpec6_pcie_probe(). > > This change left a break statement behind that is not needed any more as > as the function artpec6_pcie_probe() return immediately after making > a call to dw_pcie_ep_init(). > > Thus remove this surplus break statement that became a dead code. > > Signed-off-by: Krzysztof Wilczyński Acked-by: Jesper Nilsson /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com