From: Mark Brown <broonie@kernel.org>
To: David Rhodes <drhodes@opensource.cirrus.com>
Cc: robh@kernel.org, brian.austin@cirrus.com,
ckeepax@opensource.cirrus.com, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
david.rhodes@cirrus.com
Subject: Re: [PATCH v2 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier
Date: Fri, 2 Jul 2021 13:08:10 +0100 [thread overview]
Message-ID: <20210702120810.GA4416@sirena.org.uk> (raw)
In-Reply-To: <4d1a88a1-a61b-a14a-a9f1-66101277e8c2@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On Thu, Jul 01, 2021 at 03:22:53PM -0500, David Rhodes wrote:
> On 6/29/21 6:51 PM, Pierre-Louis Bossart wrote:
> > > +static irqreturn_t cs35l41_irq(int irq, void *data)
> > > +{
> > > + struct cs35l41_private *cs35l41 = data;
> > > + unsigned int status[4] = {0, 0, 0, 0};
> > > + unsigned int masks[4] = {0, 0, 0, 0};
> > are those inits necessary, you override them below with the regmap reads?
> This one gets flagged by static analyzers so I'd like to keep the inits
That sounds like you have an actual issue and you're just shutting up
the static analysers, not fixing whatever they were telling you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-02 12:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 22:27 [PATCH v2 0/2] Cirrus Logic CS35L41 Amplifier David Rhodes
2021-06-29 22:27 ` [PATCH v2 1/2] ASoC: cs35l41: CS35L41 Boosted Smart Amplifier David Rhodes
2021-06-29 23:51 ` Pierre-Louis Bossart
2021-06-30 21:35 ` David Rhodes
2021-07-01 11:54 ` Pierre-Louis Bossart
2021-07-01 20:22 ` David Rhodes
2021-07-02 12:08 ` Mark Brown [this message]
2021-07-02 15:23 ` David Rhodes
2021-07-02 15:48 ` Mark Brown
2021-07-02 15:52 ` David Rhodes
2021-07-12 8:32 ` Charles Keepax
2021-06-29 22:27 ` [PATCH v2 2/2] ASoC: cs35l41: Add bindings for CS35L41 David Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702120810.GA4416@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=drhodes@opensource.cirrus.com \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.