From: Boris Brezillon <boris.brezillon@collabora.com>
To: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel@lists.freedesktop.org,
Steven Price <steven.price@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v3 5/7] drm/panfrost: Add a new ioctl to submit batches
Date: Fri, 2 Jul 2021 19:54:44 +0200 [thread overview]
Message-ID: <20210702195444.010bbb7b@collabora.com> (raw)
In-Reply-To: <YN9DsztrsMWY1rv+@maud>
On Fri, 2 Jul 2021 12:49:55 -0400
Alyssa Rosenzweig <alyssa@collabora.com> wrote:
> > > Why is there padding instead of putting point first?
> >
> > We can move the point field first, but we need to keep the explicit
> > padding: the struct has to be 64bit aligned because of the __u64 field
> > (which the compiler takes care of) but if we don't have an explicit
> > padding, the unused 32bits are undefined, which might cause trouble if
> > we extend the struct at some point, since we sort of expect that old
> > userspace keep this unused 32bit slot to 0, while new users set
> > non-zero values if they have to.
>
> Makes sense. Reordering still probably makes sense.
Actually, I can't re-order if I want the new in_syncs parser to work
with the old ioctl(), which you and Steven asked me to do :-).
next prev parent reply other threads:[~2021-07-02 17:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 14:32 [PATCH v3 0/7] drm/panfrost: drm/panfrost: Add a new submit ioctl Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 1/7] drm/panfrost: Pass a job to panfrost_{acquire, attach}_object_fences() Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 2/7] drm/panfrost: Move the mappings collection out of panfrost_lookup_bos() Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 3/7] drm/panfrost: Add BO access flags to relax dependencies between jobs Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 4/7] drm/panfrost: Add the ability to create submit queues Boris Brezillon
2021-07-02 15:05 ` Steven Price
2021-07-02 15:49 ` Boris Brezillon
2021-07-02 16:01 ` Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 5/7] drm/panfrost: Add a new ioctl to submit batches Boris Brezillon
2021-07-02 15:13 ` Alyssa Rosenzweig
2021-07-02 15:38 ` Boris Brezillon
2021-07-02 16:49 ` Alyssa Rosenzweig
2021-07-02 17:54 ` Boris Brezillon [this message]
2021-07-02 18:11 ` Boris Brezillon
2021-07-05 8:22 ` Steven Price
2021-07-05 8:43 ` Boris Brezillon
2021-07-05 8:51 ` Steven Price
2021-07-06 12:48 ` Alyssa Rosenzweig
2021-07-07 9:09 ` Steven Price
2021-07-02 15:31 ` Steven Price
2021-07-02 15:34 ` Alyssa Rosenzweig
2021-07-02 14:32 ` [PATCH v3 6/7] drm/panfrost: Advertise the SYNCOBJ_TIMELINE feature Boris Brezillon
2021-07-02 14:32 ` [PATCH v3 7/7] drm/panfrost: Bump minor version to reflect the feature additions Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210702195444.010bbb7b@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=alyssa@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.