From: Pavel Machek <pavel@ucw.cz>
To: David Rivshin <drivshin@awxrd.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt()
Date: Sat, 3 Jul 2021 22:19:24 +0200 [thread overview]
Message-ID: <20210703201924.GB6707@amd> (raw)
In-Reply-To: <20210603171010.37fbf545.drivshin@awxrd.com>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Thu 2021-06-03 17:10:10, David Rivshin wrote:
> On Tue, 1 Jun 2021 19:09:03 +0800
> Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
>
> > The error code is missing in this code scenario, add the error code
> > '-EINVAL' to the return value 'ret'.
> >
> > Eliminate the follow smatch warning:
> >
> > drivers/leds/leds-is31fl32xx.c:388 is31fl32xx_parse_dt() warn: missing
> > error code 'ret'.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
> Good catch!
>
> Acked-by: David Rivshin <drivshin@allworx.com>
>
> You might also want to add a:
>
> Fixes: 9d7cffaf99f5 ("leds: Add driver for the ISSI IS31FL32xx family of LED controllers")
>
Thanks, applied. I added the fixes tag, too, but I'm not sure if this
is suitable for stable.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2021-07-03 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 11:09 [PATCH] leds: is31fl32xx: Fix missing error code in is31fl32xx_parse_dt() Jiapeng Chong
2021-06-03 21:10 ` David Rivshin
2021-07-03 20:19 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210703201924.GB6707@amd \
--to=pavel@ucw.cz \
--cc=drivshin@awxrd.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.