Re: [PATCH 2/4] habanalabs: expose state dump

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3483 bytes --]

Hi Oded,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on next-20210701]
[cannot apply to linux/master linus/master v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 6f746d485fb9188dc67dce7de63d21f0c28a1f2e
config: riscv-randconfig-r021-20210704 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3e9619ac368f95ce2bc592e00383c21f2ce66365
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Oded-Gabbay/habanalabs-use-get_task_pid-to-take-PID/20210704-195147
        git checkout 3e9619ac368f95ce2bc592e00383c21f2ce66365
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/misc/habanalabs/common/state_dump.c:12: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * A helper function, format an integer as binary using supplied scratch buffer,

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for ERRATA_SIFIVE
   Depends on RISCV_ERRATA_ALTERNATIVE
   Selected by
   - SOC_SIFIVE


vim +12 drivers/misc/habanalabs/common/state_dump.c

    10	
    11	/**
  > 12	 * A helper function, format an integer as binary using supplied scratch buffer,
    13	 * return the pointer to the buffer.
    14	 * @buf: the buffer to use
    15	 * @buf_len: buffer capacity
    16	 * @n: number to format
    17	 *
    18	 * Returns pointer to buf
    19	 */
    20	char *hl_format_as_binary(char *buf, size_t buf_len, u32 n)
    21	{
    22		int i;
    23		u32 bit;
    24		bool leading0 = true;
    25		char *wrptr = buf;
    26	
    27		if (buf_len > 0 && buf_len < 3) {
    28			*wrptr = '\0';
    29			return buf;
    30		}
    31	
    32		wrptr[0] = '0';
    33		wrptr[1] = 'b';
    34		wrptr += 2;
    35		/* Remove 3 characters from length for '0b' and '\0' termination */
    36		buf_len -= 3;
    37	
    38		for (i = 0; i < sizeof(n) * BITS_PER_BYTE && buf_len; ++i, n <<= 1) {
    39			/* Writing bit calculation in one line would cause a false
    40			 * positive static code analysis error, so splitting.
    41			 */
    42			bit = n & (1 << (sizeof(n) * BITS_PER_BYTE - 1));
    43			bit = !!bit;
    44			leading0 &= !bit;
    45			if (!leading0) {
    46				*wrptr = '0' + bit;
    47				++wrptr;
    48			}
    49		}
    50	
    51		*wrptr = '\0';
    52	
    53		return buf;
    54	}
    55	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39943 bytes --]