From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA50BC07E96 for ; Tue, 6 Jul 2021 09:41:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 805BC61995 for ; Tue, 6 Jul 2021 09:41:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 805BC61995 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C96F89C0D; Tue, 6 Jul 2021 09:41:52 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D9CC89C0D; Tue, 6 Jul 2021 09:41:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="207260021" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="207260021" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:41:50 -0700 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="559891382" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:41:48 -0700 Date: Tue, 6 Jul 2021 15:13:27 +0530 From: Ramalingam C To: Matthew Auld Message-ID: <20210706094327.GB23963@intel.com> References: <20210702104642.1189978-1-matthew.auld@intel.com> <20210702104642.1189978-2-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210702104642.1189978-2-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: fix smatch warning in mock_reserve X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2021-07-02 at 11:46:42 +0100, Matthew Auld wrote: > If mock_region_create fails then mem will be an error pointer. Instead > we just need to use the correct ordering for the onion unwind. > > igt_mock_reserve() error: 'mem' dereferencing possible ERR_PTR() > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/selftests/intel_memory_region.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > index 1aaccb9841a0..418caae84759 100644 > --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c > +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > @@ -173,7 +173,7 @@ static int igt_mock_reserve(void *arg) > if (IS_ERR(mem)) { > pr_err("failed to create memory region\n"); > err = PTR_ERR(mem); > - goto out_close; > + goto out_free_order; > } > > /* Reserve a bunch of ranges within the region */ > @@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg) > } > > out_close: > - kfree(order); > close_objects(mem, &objects); > intel_memory_region_put(mem); > +out_free_order: > + kfree(order); LGTM. Reviewed-by: Ramalingam C > return err; > } > > -- > 2.26.3 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96801C07E9E for ; Tue, 6 Jul 2021 09:41:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6391261995 for ; Tue, 6 Jul 2021 09:41:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6391261995 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BA4A89DA5; Tue, 6 Jul 2021 09:41:53 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D9CC89C0D; Tue, 6 Jul 2021 09:41:51 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="207260021" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="207260021" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:41:50 -0700 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="559891382" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:41:48 -0700 Date: Tue, 6 Jul 2021 15:13:27 +0530 From: Ramalingam C To: Matthew Auld Subject: Re: [PATCH 2/2] drm/i915/selftests: fix smatch warning in mock_reserve Message-ID: <20210706094327.GB23963@intel.com> References: <20210702104642.1189978-1-matthew.auld@intel.com> <20210702104642.1189978-2-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210702104642.1189978-2-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel test robot , Dan Carpenter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-02 at 11:46:42 +0100, Matthew Auld wrote: > If mock_region_create fails then mem will be an error pointer. Instead > we just need to use the correct ordering for the onion unwind. > > igt_mock_reserve() error: 'mem' dereferencing possible ERR_PTR() > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/selftests/intel_memory_region.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > index 1aaccb9841a0..418caae84759 100644 > --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c > +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > @@ -173,7 +173,7 @@ static int igt_mock_reserve(void *arg) > if (IS_ERR(mem)) { > pr_err("failed to create memory region\n"); > err = PTR_ERR(mem); > - goto out_close; > + goto out_free_order; > } > > /* Reserve a bunch of ranges within the region */ > @@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg) > } > > out_close: > - kfree(order); > close_objects(mem, &objects); > intel_memory_region_put(mem); > +out_free_order: > + kfree(order); LGTM. Reviewed-by: Ramalingam C > return err; > } > > -- > 2.26.3 >