From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E49C07E96 for ; Tue, 6 Jul 2021 12:20:43 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E73461464 for ; Tue, 6 Jul 2021 12:20:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E73461464 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aepfle.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.151199.279449 (Exim 4.92) (envelope-from ) id 1m0k3u-0000km-3e; Tue, 06 Jul 2021 12:20:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 151199.279449; Tue, 06 Jul 2021 12:20:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0k3t-0000kf-WC; Tue, 06 Jul 2021 12:20:25 +0000 Received: by outflank-mailman (input) for mailman id 151199; Tue, 06 Jul 2021 12:20:24 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1m0k3s-0000kZ-AE for xen-devel@lists.xenproject.org; Tue, 06 Jul 2021 12:20:24 +0000 Received: from mo4-p01-ob.smtp.rzone.de (unknown [81.169.146.167]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 89082c22-de54-11eb-8492-12813bfff9fa; Tue, 06 Jul 2021 12:20:23 +0000 (UTC) Received: from sender by smtp.strato.de (RZmta 47.28.1 AUTH) with ESMTPSA id 30791cx66CKFRYC (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 6 Jul 2021 14:20:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89082c22-de54-11eb-8492-12813bfff9fa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1625574016; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=0+owGwuanH3lMx5WvCbyvFUVHkXcVOCqOdO7Ui5n7qg=; b=Wx3DaDSxP+YzxPfxsQhLBQkmVdbbGoB84vUWyG6nc3TO8cm5dClIri9uvjw63lWl2S 8CHzIfjOd9I65C8zYKVMrQ5Bf4bByCuu2jQtN8LIkeMOw5TRr/ffn6OxSNuGBdoaREGz Li9P51C0hCfDTvBex97T2AZnpHJkM8ENo2pTQOTV3c6TqxLX944Fh3VsdwIKVqy5NLQQ lYccRUtTstUDbpvKsIbBTErkxNYltd5ypa57FfE9VkSg2hx0ifZ9vSSB/3yQc5XsVCTd c2d0soXk3emTkSLTpS6pxY1oLc+S6ISvUDqUWafSmhZS1FVtIiErOlTk0Emut/Xyrmqq F8EQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QLpd5ylWvMDX3y/OuD5rXVisF+Ax6FOE3sSy9BcWAcR/hQoAs9MGk67vg1baqX" X-RZG-CLASS-ID: mo00 Date: Tue, 6 Jul 2021 14:20:10 +0200 From: Olaf Hering To: Andrew Cooper Cc: Xen-devel , Ian Jackson , Wei Liu , Juergen Gross , Jan Beulich Subject: Re: [PATCH 1/2] tools/migration: Fix iovec handling in send_checkpoint_dirty_pfn_list() Message-ID: <20210706142010.3555a487.olaf@aepfle.de> In-Reply-To: <20210706112332.31753-2-andrew.cooper3@citrix.com> References: <20210706112332.31753-1-andrew.cooper3@citrix.com> <20210706112332.31753-2-andrew.cooper3@citrix.com> X-Mailer: Claws Mail 2021.07.03 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/3=BS9uBOY8tvc7PqgE_xM6E"; protocol="application/pgp-signature"; micalg=pgp-sha256 --Sig_/3=BS9uBOY8tvc7PqgE_xM6E Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Tue, 6 Jul 2021 12:23:31 +0100 schrieb Andrew Cooper : > We shouldn't be using two struct iovec's to write half of 'rec' each, and > there is no need to malloc() for two struct iovec's at all. >=20 > Simplify down to just two - one covering the whole of 'rec', and one cove= ring > the pfns array. Acked-by: Olaf Hering Olaf --Sig_/3=BS9uBOY8tvc7PqgE_xM6E Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE97o7Um30LT3B+5b/86SN7mm1DoAFAmDkSnoACgkQ86SN7mm1 DoAHZRAAjfqSTntZ7FOI6Ns5VJN8Ozga/YOMGAzHiUH6aubH3A3iK88Q318ju2qA ldiL/VZFVzPZ0exWT7SK/MBihZy/R4uIawFKuo+gIAoUPTX0ysX7fJKV1h1YhyS+ 5euaxhXziVRUoCpyGrCQ8u4y5/2mZgxznswTbOqRwRk7cVP6Gd5gyZP46iksSO/C hj6RPzpcmlku/wH7XrepmOv01FdxoDaMbFhJlETDS7xhAQQBqZYZze0e/gIkZlXU 8L1h4a17NP+NtRSy8UV9vjFGr4UGSvViG8KKLDuqj+2IOBRcPTYn9b2l7ERC1zGN 12iwkRRXEwzLtXO/9spqWUKtFnHSLUlnsqQCtqy3/hw6xWZ0z+n5WHswJijzhf04 ZHp2zFqGmHykd7qyXbNrE5bSBFRhdfsrwHFvLAP36LU5aiSn0eiORPe0JQnI6rQe BfmjalbYIQ538rNY7yjrWfwsN/bm/U2X1gJRKlSSIKmWFrgFmDQaODLIBzTtuF1O ls/YN0WNA2nwB5r5EtXOIwfzSbin20KAfozxidxAlbKUd0ZSZHCF3pVbxuLTRtEC QvcKNwBmn3a7T1XZtYzr3eXC/eQfXUnqd4TmprZUD9IFw/0I3QJBmlv3W0odKM6g WgFIkYLf98EgnyFMswiUggxuY4qWQ4p9ndb6M9F9cQJJEy2/YUM= =dCSv -----END PGP SIGNATURE----- --Sig_/3=BS9uBOY8tvc7PqgE_xM6E--