All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: u-boot@lists.denx.de, Andre Przywara <andre.przywara@arm.com>
Subject: Re: [U-Boot] [PATCH v3 13/20] spl: nand: sunxi: use PIO instead of DMA
Date: Tue, 6 Jul 2021 18:00:33 +0200	[thread overview]
Message-ID: <20210706180033.00a81eb0@xps13> (raw)
In-Reply-To: <20210624120540.7oyhdmerjndsylbq@gilmour>

Hi Maxime,

Maxime Ripard <maxime@cerno.tech> wrote on Thu, 24 Jun 2021 14:05:40
+0200:

> Hi Miquel,
> 
> On Wed, Feb 28, 2018 at 08:51:55PM +0100, Miquel Raynal wrote:
> > SPL support was first written to support only the earlier generations of
> > Allwinner SoCs, and was only really enabled on the A13 / GR8. However,
> > those old SoCs had a DMA engine that has been replaced since the A31 by
> > another DMA controller that is no longer compatible.
> > 
> > Since the code directly uses that DMA controller, it cannot operate
> > properly on the later SoCs, while the NAND controller has not changed.
> > 
> > There's two paths forward, the first one would have been to add support
> > for that DMA controller too, the second to just remove the DMA usage
> > entirely and rely on PIO.
> > 
> > The later has been chosen because CPU overload at this stage is not an
> > issue and it makes the driver more generic, and easier to understand.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>  
> 
> I'm a bit late to the party, but this bricks the CHIP Pro too. While
> U-Boot proper seems to be flashed properly (re-reading it from the NAND
> after flashing brings up the same CRC than the original image), the SPL
> will only read 0s.
> 
> The transfer does complete though, so maybe it's just the copy from the
> SRAM to the main memory that doesn't work?
> 
> The offset looks correct though, so I'm not sure.

Strange... I really have no idea what's going on here and especially I
don't have any suitable board with me these days to troubleshoot this.

Sorry for not being helpful at all on this one :-)

Thanks,
Miquèl

  reply	other threads:[~2021-07-06 16:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 19:51 [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo NES Classic Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 01/20] spl: fix binman_sym output check Miquel Raynal
2018-03-13 13:36   ` Maxime Ripard
2018-03-20 14:24     ` Maxime Ripard
2018-03-31 10:19     ` Simon Glass
2018-02-28 19:51 ` [U-Boot] [PATCH v3 02/20] mtd: nand: sunxi: fix ECC strength choice Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 03/20] spl: nand: sunxi: fix second case of modulo by zero error Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 04/20] spl: nand: sunxi: fix typo on register name Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 05/20] spl: nand: sunxi: introduce the nand_wait_int() helper Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 06/20] spl: nand: sunxi: introduce the nand_wait_cmd_fifo_empty() helper Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 07/20] spl: nand: sunxi: add missing status clear Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 08/20] spl: nand: sunxi: create an helper to handle command execution Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 09/20] spl: nand: sunxi: ensure enough time has passed after changing the column Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 10/20] spl: nand: sunxi: make the reset column helper more generic Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 11/20] sunxi: spl: deassert the NAND controller reset line Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 12/20] spl: nand: sunxi: declare the ecc_bytes array globally Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 13/20] spl: nand: sunxi: use PIO instead of DMA Miquel Raynal
2021-06-24 12:05   ` Maxime Ripard
2021-07-06 16:00     ` Miquel Raynal [this message]
2021-07-07  9:57       ` Maxime Ripard
2018-02-28 19:51 ` [U-Boot] [PATCH v3 14/20] sunxi: spl: remove DMA related settings of the NAND controller Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 15/20] sunxi: allow NAND support to be compiled for sun8i platforms Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 16/20] sunxi: dts: enable NAND on NES classic Miquel Raynal
2018-02-28 19:51 ` [U-Boot] [PATCH v3 17/20] sunxi: automatically select SPL_NAND_SUPPORT in Kconfig Miquel Raynal
2018-02-28 19:52 ` [U-Boot] [PATCH v3 18/20] sunxi: make NAND_SUNXI use ARCH_SUNXI as default " Miquel Raynal
2018-02-28 19:52 ` [U-Boot] [PATCH v3 19/20] sunxi: move the NAND parameters to Kconfig Miquel Raynal
2018-02-28 19:52 ` [U-Boot] [PATCH v3 20/20] configs: add NAND support for NES Classic Miquel Raynal
2018-03-01  8:20 ` [U-Boot] [PATCH v3 00/20] Bring NAND support to Nintendo " Maxime Ripard
2018-03-07  7:57 ` Maxime Ripard
2018-03-12 22:33   ` Scott Wood
2018-03-13 13:36     ` Maxime Ripard
2018-04-03 10:15 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210706180033.00a81eb0@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=andre.przywara@arm.com \
    --cc=maxime@cerno.tech \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.