From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE6D6C07E9B for ; Wed, 7 Jul 2021 00:40:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A538861416 for ; Wed, 7 Jul 2021 00:40:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A538861416 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70F876E7E2; Wed, 7 Jul 2021 00:40:19 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E11C86E7DD; Wed, 7 Jul 2021 00:40:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="209038526" X-IronPort-AV: E=Sophos;i="5.83,330,1616482800"; d="scan'208";a="209038526" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 17:40:15 -0700 X-IronPort-AV: E=Sophos;i="5.83,330,1616482800"; d="scan'208";a="427760290" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 17:40:11 -0700 Date: Wed, 7 Jul 2021 06:11:51 +0530 From: Ramalingam C To: Matthew Auld Message-ID: <20210707004151.GC26377@intel.com> References: <20210705135310.1502437-1-matthew.auld@intel.com> <20210705135310.1502437-4-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210705135310.1502437-4-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/uapi: convert drm_i915_gem_set_domain to kernel doc X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?utf-8?Q?Hellstr=C3=B6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kenneth Graunke , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gMjAyMS0wNy0wNSBhdCAxNDo1MzowOSArMDEwMCwgTWF0dGhldyBBdWxkIHdyb3RlOgo+IENv bnZlcnQgYWxsIHRoZSBkcm1faTkxNV9nZW1fc2V0X2RvbWFpbiBiaXRzIHRvIHByb3BlciBrZXJu ZWwgZG9jLgoKTEdUTS4KClJldmlld2VkLWJ5OiBSYW1hbGluZ2FtIEMgPHJhbWFsaW5nYW0uY0Bp bnRlbC5jb20+Cj4gCj4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwu Y2g+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRAaW50ZWwuY29t Pgo+IENjOiBUaG9tYXMgSGVsbHN0csO2bSA8dGhvbWFzLmhlbGxzdHJvbUBsaW51eC5pbnRlbC5j b20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5j b20+Cj4gQ2M6IEpvcmRhbiBKdXN0ZW4gPGpvcmRhbi5sLmp1c3RlbkBpbnRlbC5jb20+Cj4gQ2M6 IEtlbm5ldGggR3JhdW5rZSA8a2VubmV0aEB3aGl0ZWNhcGUub3JnPgo+IENjOiBKYXNvbiBFa3N0 cmFuZCA8amFzb25Aamxla3N0cmFuZC5uZXQ+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFJhbWFsaW5nYW0gQyA8cmFtYWxpbmdhbS5jQGludGVsLmNv bT4KPiAtLS0KPiAgaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5oIHwgMzQgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzEgaW5zZXJ0aW9ucygr KSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9pOTE1 X2RybS5oIGIvaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5oCj4gaW5kZXggYTRmYWNlZWI4YzMy Li42Zjk0ZTVlNzU2OWEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5o Cj4gKysrIGIvaW5jbHVkZS91YXBpL2RybS9pOTE1X2RybS5oCj4gQEAgLTg4MCwxNCArODgwLDQy IEBAIHN0cnVjdCBkcm1faTkxNV9nZW1fbW1hcF9vZmZzZXQgewo+ICAJX191NjQgZXh0ZW5zaW9u czsKPiAgfTsKPiAgCj4gKwo+ICsvKioKPiArICogc3RydWN0IGRybV9pOTE1X2dlbV9zZXRfZG9t YWluIC0gQWRqdXN0IHRoZSBvYmplY3RzIHdyaXRlIG9yIHJlYWQgZG9tYWluLCBpbgo+ICsgKiBw cmVwYXJhdGlvbiBmb3IgYWNjZXNzaW5nIHRoZSBwYWdlcyB2aWEgc29tZSBDUFUgZG9tYWluLgo+ ICsgKgo+ICsgKiBTcGVjaWZ5aW5nIGEgbmV3IHdyaXRlIG9yIHJlYWQgZG9tYWluIHdpbGwgZmx1 c2ggdGhlIG9iamVjdCBvdXQgb2YgdGhlCj4gKyAqIHByZXZpb3VzIGRvbWFpbihpZiByZXF1aXJl ZCksIGJlZm9yZSB0aGVuIHVwZGF0aW5nIHRoZSBvYmplY3RzIGRvbWFpbgo+ICsgKiB0cmFja2lu ZyB3aXRoIHRoZSBuZXcgZG9tYWluLgo+ICsgKgo+ICsgKiBOb3RlIHRoaXMgbWlnaHQgaW52b2x2 ZSB3YWl0aW5nIGZvciB0aGUgb2JqZWN0IGZpcnN0IGlmIGl0IGlzIHN0aWxsIGFjdGl2ZSBvbgo+ ICsgKiB0aGUgR1BVLgo+ICsgKgo+ICsgKiBTdXBwb3J0ZWQgdmFsdWVzIGZvciBAcmVhZF9kb21h aW5zIGFuZCBAd3JpdGVfZG9tYWluOgo+ICsgKgo+ICsgKgktIEk5MTVfR0VNX0RPTUFJTl9XQzog VW5jYWNoZWQgd3JpdGUtY29tYmluZWQgZG9tYWluCj4gKyAqCS0gSTkxNV9HRU1fRE9NQUlOX0NQ VTogQ1BVIGNhY2hlIGRvbWFpbgo+ICsgKgktIEk5MTVfR0VNX0RPTUFJTl9HVFQ6IE1hcHBhYmxl IGFwZXJ0dXJlIGRvbWFpbgo+ICsgKgo+ICsgKiBBbGwgb3RoZXIgZG9tYWlucyBhcmUgcmVqZWN0 ZWQuCj4gKyAqCj4gKyAqLwo+ICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3NldF9kb21haW4gewo+IC0J LyoqIEhhbmRsZSBmb3IgdGhlIG9iamVjdCAqLwo+ICsJLyoqIEBoYW5kbGU6IEhhbmRsZSBmb3Ig dGhlIG9iamVjdC4gKi8KPiAgCV9fdTMyIGhhbmRsZTsKPiAgCj4gLQkvKiogTmV3IHJlYWQgZG9t YWlucyAqLwo+ICsJLyoqCj4gKwkgKiBAcmVhZF9kb21haW5zOiBOZXcgcmVhZCBkb21haW5zLgo+ ICsJICovCj4gIAlfX3UzMiByZWFkX2RvbWFpbnM7Cj4gIAo+IC0JLyoqIE5ldyB3cml0ZSBkb21h aW4gKi8KPiArCS8qKgo+ICsJICogQHdyaXRlX2RvbWFpbjogTmV3IHdyaXRlIGRvbWFpbi4KPiAr CSAqCj4gKwkgKiBOb3RlIHRoYXQgaGF2aW5nIHNvbWV0aGluZyBpbiB0aGUgd3JpdGUgZG9tYWlu IGltcGxpZXMgaXQncyBpbiB0aGUKPiArCSAqIHJlYWQgZG9tYWluLCBhbmQgb25seSB0aGF0IHJl YWQgZG9tYWluLgo+ICsJICovCj4gIAlfX3UzMiB3cml0ZV9kb21haW47Cj4gIH07Cj4gIAo+IC0t IAo+IDIuMjYuMwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0605DC07E96 for ; Wed, 7 Jul 2021 00:40:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9BD361416 for ; Wed, 7 Jul 2021 00:40:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9BD361416 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 166AE6E7DD; Wed, 7 Jul 2021 00:40:19 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id E11C86E7DD; Wed, 7 Jul 2021 00:40:17 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="209038526" X-IronPort-AV: E=Sophos;i="5.83,330,1616482800"; d="scan'208";a="209038526" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 17:40:15 -0700 X-IronPort-AV: E=Sophos;i="5.83,330,1616482800"; d="scan'208";a="427760290" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 17:40:11 -0700 Date: Wed, 7 Jul 2021 06:11:51 +0530 From: Ramalingam C To: Matthew Auld Subject: Re: [PATCH v3 4/5] drm/i915/uapi: convert drm_i915_gem_set_domain to kernel doc Message-ID: <20210707004151.GC26377@intel.com> References: <20210705135310.1502437-1-matthew.auld@intel.com> <20210705135310.1502437-4-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210705135310.1502437-4-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?utf-8?Q?Hellstr=C3=B6m?= , Jason Ekstrand , Tvrtko Ursulin , Jordan Justen , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Kenneth Graunke , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-05 at 14:53:09 +0100, Matthew Auld wrote: > Convert all the drm_i915_gem_set_domain bits to proper kernel doc. LGTM. Reviewed-by: Ramalingam C > > Suggested-by: Daniel Vetter > Signed-off-by: Matthew Auld > Cc: Thomas Hellström > Cc: Maarten Lankhorst > Cc: Tvrtko Ursulin > Cc: Jordan Justen > Cc: Kenneth Graunke > Cc: Jason Ekstrand > Cc: Daniel Vetter > Cc: Ramalingam C > --- > include/uapi/drm/i915_drm.h | 34 +++++++++++++++++++++++++++++++--- > 1 file changed, 31 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h > index a4faceeb8c32..6f94e5e7569a 100644 > --- a/include/uapi/drm/i915_drm.h > +++ b/include/uapi/drm/i915_drm.h > @@ -880,14 +880,42 @@ struct drm_i915_gem_mmap_offset { > __u64 extensions; > }; > > + > +/** > + * struct drm_i915_gem_set_domain - Adjust the objects write or read domain, in > + * preparation for accessing the pages via some CPU domain. > + * > + * Specifying a new write or read domain will flush the object out of the > + * previous domain(if required), before then updating the objects domain > + * tracking with the new domain. > + * > + * Note this might involve waiting for the object first if it is still active on > + * the GPU. > + * > + * Supported values for @read_domains and @write_domain: > + * > + * - I915_GEM_DOMAIN_WC: Uncached write-combined domain > + * - I915_GEM_DOMAIN_CPU: CPU cache domain > + * - I915_GEM_DOMAIN_GTT: Mappable aperture domain > + * > + * All other domains are rejected. > + * > + */ > struct drm_i915_gem_set_domain { > - /** Handle for the object */ > + /** @handle: Handle for the object. */ > __u32 handle; > > - /** New read domains */ > + /** > + * @read_domains: New read domains. > + */ > __u32 read_domains; > > - /** New write domain */ > + /** > + * @write_domain: New write domain. > + * > + * Note that having something in the write domain implies it's in the > + * read domain, and only that read domain. > + */ > __u32 write_domain; > }; > > -- > 2.26.3 >