From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6093680104943745922==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] printk: fix returnvar.cocci warnings Date: Thu, 08 Jul 2021 23:17:01 +0800 Message-ID: <20210708151700.GA73351@683a21ea9637> In-Reply-To: <202107082323.GGYf01w7-lkp@intel.com> List-Id: --===============6093680104943745922== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot kernel/printk/printk.c:2189:5-8: Unneeded variable: "ret". Return "- ENOMEM= " on line 2294 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: c4049cfc8a03 ("printk: move console printing to kthreads") CC: John Ogness Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.g= it linux-5.13.y-rt-rebase head: 7e175e6b59975c8901ad370f7818937f68de45c1 commit: c4049cfc8a0327c22d56855882d8e2cffd6d20fa [11/222] printk: move cons= ole printing to kthreads :::::: branch date: 19 hours ago :::::: commit date: 19 hours ago printk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2186,7 +2186,6 @@ static int printk_kthread_func(void *dat struct printk_record r; char *ext_text =3D NULL; size_t dropped_len; - int ret =3D -ENOMEM; char *text =3D NULL; char *write_text; size_t len; @@ -2291,7 +2290,7 @@ out: pr_info("%sconsole [%s%d]: printing thread stopped\n", (con->flags & CON_BOOT) ? "boot" : "", con->name, con->index); - return ret; + return -ENOMEM; } = /* Must be called within console_lock(). */ --===============6093680104943745922==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B566C07E96 for ; Thu, 8 Jul 2021 15:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80A54613D1 for ; Thu, 8 Jul 2021 15:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbhGHPU0 (ORCPT ); Thu, 8 Jul 2021 11:20:26 -0400 Received: from mga18.intel.com ([134.134.136.126]:14185 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231922AbhGHPUV (ORCPT ); Thu, 8 Jul 2021 11:20:21 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="196799493" X-IronPort-AV: E=Sophos;i="5.84,224,1620716400"; d="scan'208";a="196799493" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 08:17:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,224,1620716400"; d="scan'208";a="628548994" Received: from lkp-server01.sh.intel.com (HELO 4aae0cb4f5b5) ([10.239.97.150]) by orsmga005.jf.intel.com with ESMTP; 08 Jul 2021 08:17:37 -0700 Received: from kbuild by 4aae0cb4f5b5 with local (Exim 4.92) (envelope-from ) id 1m1VmS-000EMg-OH; Thu, 08 Jul 2021 15:17:36 +0000 Date: Thu, 8 Jul 2021 23:17:01 +0800 From: kernel test robot To: John Ogness Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Sebastian Andrzej Siewior Subject: [PATCH] printk: fix returnvar.cocci warnings Message-ID: <20210708151700.GA73351@683a21ea9637> References: <202107082323.GGYf01w7-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202107082323.GGYf01w7-lkp@intel.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: kernel test robot kernel/printk/printk.c:2189:5-8: Unneeded variable: "ret". Return "- ENOMEM" on line 2294 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Fixes: c4049cfc8a03 ("printk: move console printing to kthreads") CC: John Ogness Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git linux-5.13.y-rt-rebase head: 7e175e6b59975c8901ad370f7818937f68de45c1 commit: c4049cfc8a0327c22d56855882d8e2cffd6d20fa [11/222] printk: move console printing to kthreads :::::: branch date: 19 hours ago :::::: commit date: 19 hours ago printk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2186,7 +2186,6 @@ static int printk_kthread_func(void *dat struct printk_record r; char *ext_text = NULL; size_t dropped_len; - int ret = -ENOMEM; char *text = NULL; char *write_text; size_t len; @@ -2291,7 +2290,7 @@ out: pr_info("%sconsole [%s%d]: printing thread stopped\n", (con->flags & CON_BOOT) ? "boot" : "", con->name, con->index); - return ret; + return -ENOMEM; } /* Must be called within console_lock(). */