Re: [RFC PATCH 1/2] regulator: Add support for software node connections

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3942 bytes --]

Hi Daniel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on regulator/for-next]
[also build test WARNING on linux/master platform-drivers-x86/for-next linus/master v5.13 next-20210708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Scally/Add-software-node-support-to-regulator-framework/20210709-064330
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/e4e62fb5242b2107b82a626f0fafbbf5d6ab2a5c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Scally/Add-software-node-support-to-regulator-framework/20210709-064330
        git checkout e4e62fb5242b2107b82a626f0fafbbf5d6ab2a5c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/regulator/swnode_regulator.c:61:1: warning: no previous prototype for 'regulator_swnode_get_init_data' [-Wmissing-prototypes]
      61 | regulator_swnode_get_init_data(struct device *dev,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/regulator/swnode_regulator.c:92:1: warning: no previous prototype for 'swnode_find_regulator_by_node' [-Wmissing-prototypes]
      92 | swnode_find_regulator_by_node(struct fwnode_handle *swnode)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/regulator/swnode_regulator.c:101:23: warning: no previous prototype for 'swnode_get_regulator_node' [-Wmissing-prototypes]
     101 | struct fwnode_handle *swnode_get_regulator_node(struct device *dev, const char *supply)
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/regulator_swnode_get_init_data +61 drivers/regulator/swnode_regulator.c

    59	
    60	struct regulator_init_data *
  > 61	regulator_swnode_get_init_data(struct device *dev,
    62				       const struct regulator_desc *desc,
    63				       struct regulator_config *config,
    64				       struct fwnode_handle **regnode)
    65	{
    66		struct fwnode_handle *fwnode = dev_fwnode(dev);
    67		struct regulator_init_data *init_data;
    68		struct fwnode_handle *regulator;
    69		int ret;
    70	
    71		if (!fwnode || !is_software_node(fwnode->secondary))
    72			return NULL;
    73	
    74		regulator = regulator_swnode_get_init_node(fwnode, desc);
    75		if (!regulator)
    76			return NULL;
    77	
    78		init_data = devm_kzalloc(dev, sizeof(*init_data), GFP_KERNEL);
    79		if (!init_data)
    80			return ERR_PTR(-ENOMEM);
    81	
    82		ret = swnode_get_regulator_constraints(regulator, init_data);
    83		if (ret)
    84			return ERR_PTR(ret);
    85	
    86		*regnode = regulator;
    87	
    88		return init_data;
    89	}
    90	
    91	struct regulator_dev *
  > 92	swnode_find_regulator_by_node(struct fwnode_handle *swnode)
    93	{
    94		struct device *dev;
    95	
    96		dev = class_find_device_by_fwnode(&regulator_class, swnode);
    97	
    98		return dev ? dev_to_rdev(dev) : NULL;
    99	}
   100	
 > 101	struct fwnode_handle *swnode_get_regulator_node(struct device *dev, const char *supply)

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 59705 bytes --]