From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7A0C07E99 for ; Fri, 9 Jul 2021 14:37:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 515D1613BA for ; Fri, 9 Jul 2021 14:37:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 515D1613BA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A24882DEE; Fri, 9 Jul 2021 16:36:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cFU8W1/3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D4FE2832B8; Fri, 9 Jul 2021 16:36:57 +0200 (CEST) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A9E8782DEE for ; Fri, 9 Jul 2021 16:36:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x736.google.com with SMTP id q190so9500468qkd.2 for ; Fri, 09 Jul 2021 07:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rgOxbmWJmXOSuUn/zRXY9lod62gnuLTMCTyaVuLBiDU=; b=cFU8W1/3jPMpVMwjR33J3/BINsOAE9/QLMyozQAXx0mx4v8468BfA1FyrFfpj/qc/d vKifC9l6Gu2yRVKv5imwpWhVTy0Z8aXyKD5sC6p9dVH9mqbvYgkwF6FRacmHx+EaHejK d7Y/1ZvJ72Io52Knjgvnie1VxPTS0sKUl4md4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rgOxbmWJmXOSuUn/zRXY9lod62gnuLTMCTyaVuLBiDU=; b=cHzYSVCy7rwbxeULLHxTVZUfKQl6z283WYoI8Ik3zP5VKyUGMY+VWGd+oL8psIhENH ZC9N/A9RW8aVCMmN1vNUFH+ndEg9txbRg7LzN00aWSMx2fD1cFp6Z1yJEIVKqpkUdym/ JjaRrn+xWqop5+/wSBVGrclCYqP7on+n0hFC9XbcyBIrTUpiheABm3rr1b+7/9K8Sl8w 9G6aiTTzWIx69GzHmh6IExMLXPsotgReaOvOlmIATw8oBiT0TFhNzMmzdCGXiad7E4Nq aYZozUv+m1PswBMulb0QBrTu4oINR4EqchdF40UV08e2Mak5prYS5VFV3ULpywpKWvWp ZiJQ== X-Gm-Message-State: AOAM530O5nVQX0TQytTLfSxpm8H7x4qtfsisx50dOYaV9yQQ8pcBMBq2 RS7YawTeTDZCwhXjUYapc49NDg== X-Google-Smtp-Source: ABdhPJy22OCDrexff/A1EMHO2eKoxLy9n6leXxeGWoRSB0Ec5TUrsTglUWA4GUIzNF7hKLesnaFm4g== X-Received: by 2002:a37:9e44:: with SMTP id h65mr20870390qke.431.1625841413321; Fri, 09 Jul 2021 07:36:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1083-622a-b9ec-c6c6.res6.spectrum.com. [2603:6081:7b01:cbda:1083:622a:b9ec:c6c6]) by smtp.gmail.com with ESMTPSA id l206sm2496185qke.80.2021.07.09.07.36.52 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Jul 2021 07:36:52 -0700 (PDT) Date: Fri, 9 Jul 2021 10:36:50 -0400 From: Tom Rini To: Kishon Vijay Abraham I Cc: Lokesh Vutla , Simon Glass , marex@denx.de, a-govindraju@ti.com, u-boot@lists.denx.de Subject: Re: [PATCH v3 19/20] env: ti: j721e-evm: Add env variable to power on & reset QSGMII PHY in J7200 EVM Message-ID: <20210709143650.GG9516@bill-the-cat> References: <20210504104155.19222-1-kishon@ti.com> <20210504104155.19222-20-kishon@ti.com> <20210507171452.GT17669@bill-the-cat> <897775d4-c7f2-0159-33c7-9b152b149cba@ti.com> <20210511143311.GP17669@bill-the-cat> <2af86da3-e47a-b142-efb4-46fde4c0e443@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oIZ/Bw18JaI1CpQk" Content-Disposition: inline In-Reply-To: <2af86da3-e47a-b142-efb4-46fde4c0e443@ti.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --oIZ/Bw18JaI1CpQk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 09, 2021 at 08:02:03PM +0530, Kishon Vijay Abraham I wrote: > Hi Tom, >=20 > On 11/05/21 8:03 pm, Tom Rini wrote: > > On Tue, May 11, 2021 at 07:28:10PM +0530, Kishon Vijay Abraham I wrote: > >> Hi Tom, > >> > >> On 07/05/21 10:44 pm, Tom Rini wrote: > >>> On Tue, May 04, 2021 at 04:11:54PM +0530, Kishon Vijay Abraham I wrot= e: > >>> > >>>> MAIN CPSW0 requires the PHY to be powered on and reset for QSGMII > >>>> operation. Add a env variable to configure driving "0" on ENET_EXP_P= WRDN > >>>> controlled by GPIO EXPANDER2 (I2C Addr: 0x22), PIN: 17 and driving "= 1" > >>>> on ENET_EXP_RESETZ controlled by GPIO EXPANDER2 (I2C Addr: 0x22), > >>>> PIN: 18. > >>>> > >>>> Signed-off-by: Kishon Vijay Abraham I > >>>> Reviewed-by: Suman Anna > >>>> --- > >>>> include/configs/j721e_evm.h | 16 +++++++++++++++- > >>>> 1 file changed, 15 insertions(+), 1 deletion(-) > >>>> > >>>> diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm= =2Eh > >>>> index b707fc4e89..00d0a18a68 100644 > >>>> --- a/include/configs/j721e_evm.h > >>>> +++ b/include/configs/j721e_evm.h > >>>> @@ -139,11 +139,24 @@ > >>>> #endif /* CONFIG_TARGET_J721E_A72_EVM */ > >>>> =20 > >>>> #ifdef CONFIG_TARGET_J7200_A72_EVM > >>>> +#define EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY \ > >>>> + "do_main_cpsw0_qsgmii_phyinit=3D1\0" \ > >>> > >>> When would this be not true? > >> > >> If the user don't want to use QSGMII, this could be set to false. For > >> instance the SERDES in J7200 can be used such that it can be used with > >> two protocols at a time. So it can be either PCIe + QSGMII or PCIe + > >> USB. So for use cases which require PCIe + USB, this could be set to f= alse. > >=20 > > Then we need to create doc/board/ti/j721e_evm.rst with some general > > content and then document the above in there. >=20 > There is already a document @ board/ti/j721e/README which has some > general information. Maybe that could be updated and moved to > doc/board/ti/j721e_evm.rst? Yes, board/*/boardname/README should be converted to doc/board/*/boardname.= rst in geneal. --=20 Tom --oIZ/Bw18JaI1CpQk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDoXvgACgkQFHw5/5Y0 tyxMjgwAjFiH1mvISNeb8FgVxUpvzBOZ4h1HdUxGcaLNMoKGAhA6eG5TLyvDQEF1 AYs1I9BDuyKLHIaCB9yvutCcqk4K9ZiFpo0VEg45N3bbZUbWoAGAR79iY5CzMizI iMWyyW8HhcO4r2OniaAhJpx/kS77P8diUdMEOBB4NqgHZTScVjMDy2p5fbVLf9mU eIzr+ZhVYqB3m/GBhSBNF0ApgwPP8VSFpvBqxLluG5PgDedkU7WkZ9O5Ii3+JV6m c4h1sxcKPTxMLDF1qTxJPjfew6VonV8wbCFZQw9+NAaRc/6sNPHRW1LCmsukXT0r EHRIWsgAXNnyP/WAo8DlC3Kf9Fl2TVyeN1yH9wHum9ju0+KUEv644pmbEOIXbzs9 7Vv0Nu7FEjpTL713rnkeILCSGcgFLSogSL9IXw2OclzI6hF05J7SD5Jv//Dbmp21 Q7EGlxp6yvzb9nqYb0R4ZH84V4mWTlvVSD/h+j+b8EtjrDzOxR8vdi6/ul5TcIaU qeplGynO =doPE -----END PGP SIGNATURE----- --oIZ/Bw18JaI1CpQk--