From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A117FC07E9E for ; Sat, 10 Jul 2021 02:31:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AA89613CC for ; Sat, 10 Jul 2021 02:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbhGJCdv (ORCPT ); Fri, 9 Jul 2021 22:33:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:49198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233581AbhGJCc1 (ORCPT ); Fri, 9 Jul 2021 22:32:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B9C5A6143F; Sat, 10 Jul 2021 02:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625884078; bh=glUyRGJpssEUWp1XjJ1DcA/CbbL9xDZj0iPpNNgStho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HD7lxE2Uxy9cTmuon8BgcwsWPelr9zCM6xbcB7GnshxqgCPi23+bxTkjzyKzRN/4V ptIk+o6l+2bd9NCbCE24yALlDmcb+5Y1RDDeL/GD4NoJXHILbbOyoalLm/uwF7665g hMWprUcdL8I62PWwKASBYS7Y+g9xioMn1sNNf6ngZ9brEfZiTxaRssVTDEjM74NLx7 5T8WZoEYKWWS3WWfDf4c5OXHMNVznfuc9aTXjvCch8/u/HQDLdSu53PLi9zQxn3x8t uZzBfwJ0Q6kY4+yDrGt7CWDTWRSYh5Rx2HsyyO9nmiyjL9XDTYyHJVjuH2P1ioMWH4 sP1h3n1TyvB4Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivas Neeli , Bartosz Golaszewski , Sasha Levin , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 38/63] gpio: zynq: Check return value of pm_runtime_get_sync Date: Fri, 9 Jul 2021 22:26:44 -0400 Message-Id: <20210710022709.3170675-38-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022709.3170675-1-sashal@kernel.org> References: <20210710022709.3170675-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Srinivas Neeli [ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ] Return value of "pm_runtime_get_sync" API was neither captured nor checked. Fixed it by capturing the return value and then checking for any warning. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-zynq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 88b04d8a7fa7..25a42605aa81 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -938,8 +938,11 @@ static int zynq_gpio_probe(struct platform_device *pdev) static int zynq_gpio_remove(struct platform_device *pdev) { struct zynq_gpio *gpio = platform_get_drvdata(pdev); + int ret; - pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_get_sync(&pdev->dev); + if (ret < 0) + dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n"); gpiochip_remove(&gpio->chip); clk_disable_unprepare(gpio->clk); device_set_wakeup_capable(&pdev->dev, 0); -- 2.30.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39D5FC07E99 for ; Sat, 10 Jul 2021 02:37:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11599613BE for ; Sat, 10 Jul 2021 02:37:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11599613BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wNNEsOVnSypTbySP3sspfswHfpY3Jr58VbfA5KTx/JM=; b=ocE6zlHhVhh2h7 rDL7mkyrZAPVX1GewaCkHvRtY/5+8EnzyBnLc7od0ZRvUNvofEtCugl0xngcMuYbDD9TUW3cVKzLg 82ZeuRm6+hDNgpkpWJt5nkb20/H8mhMVSUuJ6fHEoBgRgiwVrtsQUa+SJSLdzc92J1Lmt7Ps/5tqF 4ynNVY5CkgN+0ITtL7//OyM8jpvUh2YNTZlfYtf0MMrgHbidfEzZExKJzHeV9IIom4ooWO2bCT8TW cNf3T5+zF9dTZVmOmOziVXmrvm/1FGHWI3khZbYKAlF9Z8GpafMDBVXx5F19YbWPG45/cBYHN9cnN f5G9Z+jeFDNBwnqiOYcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m22qK-002vCC-3U; Sat, 10 Jul 2021 02:35:49 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m22ik-002qHQ-O0 for linux-arm-kernel@lists.infradead.org; Sat, 10 Jul 2021 02:28:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B9C5A6143F; Sat, 10 Jul 2021 02:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625884078; bh=glUyRGJpssEUWp1XjJ1DcA/CbbL9xDZj0iPpNNgStho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HD7lxE2Uxy9cTmuon8BgcwsWPelr9zCM6xbcB7GnshxqgCPi23+bxTkjzyKzRN/4V ptIk+o6l+2bd9NCbCE24yALlDmcb+5Y1RDDeL/GD4NoJXHILbbOyoalLm/uwF7665g hMWprUcdL8I62PWwKASBYS7Y+g9xioMn1sNNf6ngZ9brEfZiTxaRssVTDEjM74NLx7 5T8WZoEYKWWS3WWfDf4c5OXHMNVznfuc9aTXjvCch8/u/HQDLdSu53PLi9zQxn3x8t uZzBfwJ0Q6kY4+yDrGt7CWDTWRSYh5Rx2HsyyO9nmiyjL9XDTYyHJVjuH2P1ioMWH4 sP1h3n1TyvB4Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Srinivas Neeli , Bartosz Golaszewski , Sasha Levin , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 38/63] gpio: zynq: Check return value of pm_runtime_get_sync Date: Fri, 9 Jul 2021 22:26:44 -0400 Message-Id: <20210710022709.3170675-38-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210710022709.3170675-1-sashal@kernel.org> References: <20210710022709.3170675-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210709_192758_895210_F6F6FFBF X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Srinivas Neeli [ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ] Return value of "pm_runtime_get_sync" API was neither captured nor checked. Fixed it by capturing the return value and then checking for any warning. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-zynq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 88b04d8a7fa7..25a42605aa81 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -938,8 +938,11 @@ static int zynq_gpio_probe(struct platform_device *pdev) static int zynq_gpio_remove(struct platform_device *pdev) { struct zynq_gpio *gpio = platform_get_drvdata(pdev); + int ret; - pm_runtime_get_sync(&pdev->dev); + ret = pm_runtime_get_sync(&pdev->dev); + if (ret < 0) + dev_warn(&pdev->dev, "pm_runtime_get_sync() Failed\n"); gpiochip_remove(&gpio->chip); clk_disable_unprepare(gpio->clk); device_set_wakeup_capable(&pdev->dev, 0); -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel