Re: [RFC net-next] net: extend netdev features

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4408 bytes --]

Hi Jian,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jian-Shen/net-extend-netdev-features/20210710-174828
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 5e437416ff66981d8154687cfdf7de50b1d82bfc
config: nios2-defconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/378137e43ebe9f450b0ab5be3b32ec4295a6806f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jian-Shen/net-extend-netdev-features/20210710-174828
        git checkout 378137e43ebe9f450b0ab5be3b32ec4295a6806f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/skbuff.h:32,
                    from include/net/net_namespace.h:39,
                    from include/linux/inet.h:42,
                    from net/sunrpc/svcsock.c:30:
   include/linux/netdev_features.h: In function 'netdev_features_empty':
   include/linux/netdev_features.h:334:11: error: 'return' with a value, in function returning void [-Werror=return-type]
     334 |    return false;
         |           ^~~~~
   include/linux/netdev_features.h:328:20: note: declared here
     328 | static inline void netdev_features_empty(netdev_features_t *src)
         |                    ^~~~~~~~~~~~~~~~~~~~~
   include/linux/netdev_features.h:336:9: error: 'return' with a value, in function returning void [-Werror=return-type]
     336 |  return true;
         |         ^~~~
   include/linux/netdev_features.h:328:20: note: declared here
     328 | static inline void netdev_features_empty(netdev_features_t *src)
         |                    ^~~~~~~~~~~~~~~~~~~~~
   In file included from include/net/inet_sock.h:19,
                    from include/linux/udp.h:16,
                    from net/sunrpc/svcsock.c:31:
   include/linux/netdevice.h: In function 'netif_elide_gro':
   include/linux/netdevice.h:2254:22: error: invalid operands to binary & (have 'const netdev_features_t *' {aka 'const long long unsigned int *'} and 'long long unsigned int')
    2254 |  if (!(dev->features & NETIF_F_GRO) || dev->xdp_prog)
         |        ~~~           ^
         |        |
         |        const netdev_features_t * {aka const long long unsigned int *}
   In file included from net/sunrpc/svcsock.c:61:
   net/sunrpc/sunrpc.h: In function 'sock_is_loopback':
>> net/sunrpc/sunrpc.h:47:26: error: invalid operands to binary & (have 'netdev_features_t *' {aka 'long long unsigned int *'} and 'long long unsigned int')
      47 |      (dst->dev->features & NETIF_F_LOOPBACK))
         |       ~~~                ^
         |       |
         |       netdev_features_t * {aka long long unsigned int *}
   cc1: some warnings being treated as errors


vim +47 net/sunrpc/sunrpc.h

6951867b996706 Benny Halevy 2009-09-10  39  
ef11ce24875a8a NeilBrown    2014-05-12  40  static inline int sock_is_loopback(struct sock *sk)
ef11ce24875a8a NeilBrown    2014-05-12  41  {
ef11ce24875a8a NeilBrown    2014-05-12  42  	struct dst_entry *dst;
ef11ce24875a8a NeilBrown    2014-05-12  43  	int loopback = 0;
ef11ce24875a8a NeilBrown    2014-05-12  44  	rcu_read_lock();
ef11ce24875a8a NeilBrown    2014-05-12  45  	dst = rcu_dereference(sk->sk_dst_cache);
ef11ce24875a8a NeilBrown    2014-05-12  46  	if (dst && dst->dev &&
ef11ce24875a8a NeilBrown    2014-05-12 @47  	    (dst->dev->features & NETIF_F_LOOPBACK))
ef11ce24875a8a NeilBrown    2014-05-12  48  		loopback = 1;
ef11ce24875a8a NeilBrown    2014-05-12  49  	rcu_read_unlock();
ef11ce24875a8a NeilBrown    2014-05-12  50  	return loopback;
ef11ce24875a8a NeilBrown    2014-05-12  51  }
ef11ce24875a8a NeilBrown    2014-05-12  52  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 10032 bytes --]