From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E785C11F67 for ; Mon, 12 Jul 2021 06:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 086FC61106 for ; Mon, 12 Jul 2021 06:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233935AbhGLG01 (ORCPT ); Mon, 12 Jul 2021 02:26:27 -0400 Received: from verein.lst.de ([213.95.11.211]:51197 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234485AbhGLGZd (ORCPT ); Mon, 12 Jul 2021 02:25:33 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 01B1268AFE; Mon, 12 Jul 2021 08:22:41 +0200 (CEST) Date: Mon, 12 Jul 2021 08:22:41 +0200 From: Christoph Hellwig To: Hillf Danton Cc: syzbot , axboe@kernel.dk, hare@suse.de, hch@lst.de, jack@suse.cz, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] INFO: task hung in del_gendisk Message-ID: <20210712062241.GA9697@lst.de> References: <0000000000003fdaa905c6db08d0@google.com> <20210712041417.835-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712041417.835-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jul 12, 2021 at 12:14:17PM +0800, Hillf Danton wrote: > Fix it by s/nbd->destroy_complete/&nbd->destroy_complete/ > > Note this isnt a cure to what the syzbot reported. Yeah. The completion stuff does look bogus, but the actual sysbot report is about the fact that del_gendisk is called from ->release.