From: Jason Gunthorpe <jgg@nvidia.com>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: dledford@redhat.com, linux-rdma@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Subject: Re: [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup
Date: Mon, 12 Jul 2021 21:00:30 -0300 [thread overview]
Message-ID: <20210713000030.GA136586@nvidia.com> (raw)
In-Reply-To: <ddae0dc9-383b-00eb-b6f1-c5d3ba92694a@cornelisnetworks.com>
On Mon, Jul 12, 2021 at 03:33:37PM -0400, Dennis Dalessandro wrote:
> On 7/12/21 1:42 PM, Jason Gunthorpe wrote:
> > On Tue, Jul 06, 2021 at 01:23:45PM -0400, Dennis Dalessandro wrote:
> >> From: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
> >>
> >> There is no counter for dmawait in AIP, which hampers debugging
> >> performance issues.
> >>
> >> Add the counter increment when the txq is queued.
> >>
> >> Fixes: d99dc602e2a5 ("IB/hfi1: Add functions to transmit datagram ipoib packets")
> >> Fixes: c4cf5688ea69 ("IB/hfi1: Indicate DMA wait when txq is queued for wakeup")
> >
> > Neither of these fixes lines are correct, please resend it with
> > correct fixes lines.
>
> I believe the thinking is these are fixes that should have had the counter in
> the first place.
$ git describe --contains c4cf5688ea69
Could not get sha1 for c4cf5688ea69. Skipping.
Jason
next prev parent reply other threads:[~2021-07-13 0:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 17:23 [PATCH for-rc or next 0/2] Second attempt at two small fixups Dennis Dalessandro
2021-07-06 17:23 ` [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup Dennis Dalessandro
2021-07-06 21:41 ` kernel test robot
2021-07-12 17:42 ` Jason Gunthorpe
2021-07-12 19:33 ` Dennis Dalessandro
2021-07-13 0:00 ` Jason Gunthorpe [this message]
2021-07-14 15:45 ` Marciniszyn, Mike
2021-07-06 17:23 ` [PATCH for-rc or next 2/2] IB/hfi1: Adjust pkey entry in index 0 Dennis Dalessandro
-- strict thread matches above, loose matches on Subject: below --
2021-07-01 15:46 [PATCH for-rc or next 0/2] Two small fixups Dennis Dalessandro
2021-07-01 15:47 ` [PATCH for-rc or next 1/2] IB/hfi1: Indicate DMA wait when txq is queued for wakeup Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713000030.GA136586@nvidia.com \
--to=jgg@nvidia.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.