All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dylan MacKenzie <ecstaticmorse@gmail.com>
To: ecstaticmorse@gmail.com
Cc: Basavaraj.Natikar@amd.com, Nehal-Bakulchandra.shah@amd.com,
	benjamin.tissoires@redhat.com, jikos@kernel.org,
	linux-input@vger.kernel.org, shyam-sundar.s-k@amd.com
Subject: [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address
Date: Tue, 13 Jul 2021 16:31:07 -0700	[thread overview]
Message-ID: <20210713233106.9168-2-ecstaticmorse@gmail.com> (raw)
In-Reply-To: <20210713041121.13418-1-ecstaticmorse@gmail.com>

amd_stop_sensor_v2 accidentally used a different MMIO register than
amd_start_sensor_v2 for the DMA address.

Signed-off-by: Dylan MacKenzie <ecstaticmorse@gmail.com>
---
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
index 96e2577fa37e..8d68796aa905 100644
--- a/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
+++ b/drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
@@ -58,7 +58,7 @@ static void amd_stop_sensor_v2(struct amd_mp2_dev *privdata, u16 sensor_idx)
 	cmd_base.cmd_v2.sensor_id = sensor_idx;
 	cmd_base.cmd_v2.length  = 16;
 
-	writeq(0x0, privdata->mmio + AMD_C2P_MSG2);
+	writeq(0x0, privdata->mmio + AMD_C2P_MSG1);
 	writel(cmd_base.ul, privdata->mmio + AMD_C2P_MSG0);
 }
 
-- 
2.31.1


  reply	other threads:[~2021-07-13 23:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  4:11 [PATCH] HID: amd_sfh: Use correct MMIO register for DMA address Dylan MacKenzie
2021-07-13 23:31 ` Dylan MacKenzie [this message]
2021-07-15  6:34   ` Basavaraj Natikar
2021-07-15 19:41     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210713233106.9168-2-ecstaticmorse@gmail.com \
    --to=ecstaticmorse@gmail.com \
    --cc=Basavaraj.Natikar@amd.com \
    --cc=Nehal-Bakulchandra.shah@amd.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=shyam-sundar.s-k@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.