From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1m3WJm-0002d0-4w for mharc-grub-devel@gnu.org; Wed, 14 Jul 2021 00:16:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3WJl-0002cr-3M for grub-devel@gnu.org; Wed, 14 Jul 2021 00:16:17 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.111.102]:57404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3WJi-0004mk-PN for grub-devel@gnu.org; Wed, 14 Jul 2021 00:16:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1626236170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMd6ALOXuVXe+EuIxutcc86o6TFevoSNIWBYHUi4ocA=; b=IEhQpF807MkHM6R2G1b9qxxF4JrPcKzQ7v6Ejb7+J7k+vNxZEeS9X1Q3sWaKg2JbEUHfft TCz+gd9cmk/qTtqSE8yAgqVijOaRJinTwD4bMJLj3CwiFWuzZQO+xsS15DSD9H8MtSmhEr RvzU+RsRueaDOiCPyBQbG/pzkltqwvY= Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2057.outbound.protection.outlook.com [104.47.0.57]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-34-3_V1GRF1M-ejGVkeChzHyg-1; Wed, 14 Jul 2021 06:16:09 +0200 X-MC-Unique: 3_V1GRF1M-ejGVkeChzHyg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5MVl8kpFhfWQxWfUvq9SVNhSm96S74UkqR7hJd5VGkHyAxgOJoTKOdneRRGPd2eIiF8n5tB0HU3ZZvCsfVqCW+g/WSuaiPBad+0DN643vGhSD4vP59VWaH0Wi7spcmJufVbpkO1umsTx4WrOFPFh7nCjC1kSH3/XfLbf6jG3CHdpw07SjDZVKRP83BFFaMcn2DWfxDbp94q+N8r883hqoX8sgyNnMYIt478Phe0MIGc3dCgVeyqTIy/ntF98Ge5zfhb2sPnCd16lSqMH3sJdIktsFMbeTUtwS4ugNhjlBAlUCk1ne92fuhEYCWk5s2d/mwr7GZ99w1Ny32/WALAPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OTApvoNZAkoRFFEDVX5wtXPCzzc4WSDfksULMMrfQX0=; b=KmLgC6aSUzQDxOZrUNmoIRhf8vvIFYy1d40l7Z+GYjcBeWRRkwAU5Vuxn08bpJ2s/1J57l0qT6jaM85h491ImsdWsTHJXmdpiU1OeY+47B9hgBKWr9tMTbAXwumx7qjmzrLn5ahydX/6VnMG/S1TXJGFpxE6ptLZiNBdZcCCdMZHYTobTj1G0qCV361yfR2SbcUX3XB1PXPkybqNhPO0iVx4kut7GZ8vRymZyG/gZXCiQ1+X6w/Uyrwo/sqeWEt1Ir9aYbvGPDK/mPQDXMzvKLsU4SqPA1nT/bIxOrFKA9NOIs+AZrIQQtdpdwsoofEUXXGZ66vQDeaFqfmd4p8E5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: molgen.mpg.de; dkim=none (message not signed) header.d=none;molgen.mpg.de; dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8648.eurprd04.prod.outlook.com (2603:10a6:10:2df::21) by DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Wed, 14 Jul 2021 04:16:08 +0000 Received: from DU2PR04MB8648.eurprd04.prod.outlook.com ([fe80::245b:a7da:fcc:25a1]) by DU2PR04MB8648.eurprd04.prod.outlook.com ([fe80::245b:a7da:fcc:25a1%4]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 04:16:07 +0000 Date: Wed, 14 Jul 2021 12:16:02 +0800 From: Michael Chang To: Paul Menzel CC: Petr Vorel , Jeff Mahoney , Daniel Kiper , Mike Gilbert , The development of GNU GRUB Subject: Re: [PATCH 2/2] grub2: use stat instead of udevadm for partition lookup Message-ID: <20210714041602.GA12851@mercury> References: <20210708155558.26466-1-pvorel@suse.cz> <20210708155558.26466-3-pvorel@suse.cz> <33f16d1e-162c-6eb1-b0d0-fa69d4a2dbe4@molgen.mpg.de> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <33f16d1e-162c-6eb1-b0d0-fa69d4a2dbe4@molgen.mpg.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) To DU2PR04MB8648.eurprd04.prod.outlook.com (2603:10a6:10:2df::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (36.226.47.79) by HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.21 via Frontend Transport; Wed, 14 Jul 2021 04:16:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d63db77-5bde-4f0d-403b-08d9467e1aac X-MS-TrafficTypeDiagnostic: DU2PR04MB8822: X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:261; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8FEJvOCazM2GS4cploTvoyR5pc5W9VoTNXk6HkKjYJIb8dLr6lNxli2mX6MwRChmXO+a+9Oj0nWe4qLbDcPNTOLEkn+Ilaq58HDxNc4XoNzuVxjAvO3KUxml+Fj4SYwk7fafEdP20fouXiDxYyWqbKLOsdeD4oJ9o74aG2nM7fBdnMupx+YSySy2Cmv+QocqqTPA3Wv483G+N+zCXSMnpWZEpuwJ5uDzGkWVww9xfuraPYNUXcN8LQli2OOsu0XC8iAGOJTTZ4BAd/K27ENF0fD4h5sJOcDDw3HMowc6kyBkEzCVn3rgol6fiFMX8ZjuE+j5nrfVEW4QzK/ytMf7VlNSagtmJz94qTyjCKgiQRuDufMtm9rMBohReftT/lIHEZMuGNOmz0ypXXOkfSs2j35ojrAJtu0G51B/VdTVHhACBIiXZLljFnC44HYqTh294Tb6VKzl9ZCqWGdNbNa/fFUNjUjF9ncDn2S09PlTDkHzCRQU6PBEZIA2FA5jhaSYtmQvUBsKoG18Mmoe9YzBhKhLjuHaTo6h31HrqbkevyZdan0r9+czPsMiWTzXZ6uIonzJECUMlC2ogQC1i+OI6fLoefHmL8r1I7VB+kYBKw4Xt+SzXmUwOZwkU6zGNtE/c6U1fEkLFMV5JghexfqKFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8648.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(366004)(396003)(136003)(39860400002)(376002)(346002)(6916009)(33716001)(2906002)(1076003)(316002)(186003)(6666004)(83380400001)(33656002)(6496006)(9686003)(86362001)(26005)(478600001)(4326008)(66556008)(54906003)(8936002)(5660300002)(6486002)(956004)(8676002)(66476007)(66946007)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0NRz20B7dJ3ZsMAl7ms7kFyEgCEES+ppJH5AO5jcspVREY7zP/vd7W8SrlFp?= =?us-ascii?Q?o6TXzOHAdbyjTPYNO3qe6iqfjU0mos6DpP2CrRAv/XB2YrnFPmn3vMLBLU4Q?= =?us-ascii?Q?j2lmNrX+jFid5ouERvqwq1LE4pJ+Q76RcDlwOF0eYWheQDfGU5UWtYvgCJdD?= =?us-ascii?Q?qteqrLKpzKoEKxkJmtjNyUseRAi/AkuJntcNuR+2HVJ6IND79rHy51zyPqsC?= =?us-ascii?Q?AYWS4T/QVFYn4L0rx1h2Jmx6sxZaorSWFTvAKzgbLyMjz2lCPKiNpmh+Ns3D?= =?us-ascii?Q?RiB1JH5GYcFHNbRH/N+JjgUgvRsvVbTPEx4KX7xkxb41OVoCZISU2s321G1K?= =?us-ascii?Q?rku4UzDlMdelO7SY5zSqz5wS7FSXA4z3p/jqvGMHgEF4QobM4T0cW0fr5mbP?= =?us-ascii?Q?rsUT3np6aNPhM6HLhvbVyC7EZ8Me8LgnVCBGzcaY+/lEz7n4Rn5ASk5ewxoX?= =?us-ascii?Q?rBQiNyGcjefyEMGe5CMtmhodfC5PYqSUcDKGWoOcczhxb1FCf++IRSSxb8PZ?= =?us-ascii?Q?H4u9f+GnTTfyKqP7HYz9FGan0ePjHxmIzLshZOtC1NNqwq3+uGEbH05TrR0X?= =?us-ascii?Q?f//JhObaM2JaeB2ZV4lpTsvsun1hPoHjfdrJZPVUitqNQ78XqKMLe1g1s3ae?= =?us-ascii?Q?8VdVCxgawXADe9CIP+An8VEOOTxy58G3KcAoj1WtO+9JXD+UhoTCQpzOlMmF?= =?us-ascii?Q?reKZd2rgT77y2gqpWmfp7L39z5NIkHWZwn9mb+iQj2iELv5UCzn/xq/kLpzT?= =?us-ascii?Q?yAy5MHbcEbi/Av8mnHKhMdUbygM54VJMs/SMT5KwT8OUcesgR4cQMXCE6MGs?= =?us-ascii?Q?drX/o/QA/qQrdul1bRm2Nw+nSpC5wcOOimdepO9TcGVvwj/tafBfP0Vpw0q6?= =?us-ascii?Q?fc2WZEfzRBIlIwNUio4WuYPXB5zRHcC051EoAc7876/RSkIE+4MMLCNY6U0a?= =?us-ascii?Q?3Z5YGDlxnJYft4isqHt9N2VOfmW0M/2mtjklNe+4ev1fdvanLAtAxl255cCr?= =?us-ascii?Q?5auOG3A42x3R4HQqTfPKxxLoA6bXXGlnRniLDeBShUghV6Yyl1r9bFXJFiHh?= =?us-ascii?Q?pLX+am88sg5hfyqmuwUXoGRrOCpXkgd+6EsL9cCMc4yly3mSYnVzSXjoQaYq?= =?us-ascii?Q?GKNpHz2GMCCjJNbXu4cSfEsKB6S/7nKJKHOpEEY+Ax+y0XIkKoNPtcAg7AQv?= =?us-ascii?Q?Edt0PF3RCfV8fYTVUIkPaPKHvAtZQ0apLVINc7bm+VeEDJlDiuAXGnjJPE93?= =?us-ascii?Q?kWfG1csgPbSPJ9tFYvBuhsQSN+U1sWH6benSNamUxSF9s/rzLZAC7QMOVb+y?= =?us-ascii?Q?3QotLYISBCC9TzjXSWefi3hb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d63db77-5bde-4f0d-403b-08d9467e1aac X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8648.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2021 04:16:07.8708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uy0hIfVH+rAf5LzJi8Y20S5PE2cr1pogTSY64i/tH5Xpb3dGgBzUvhKButte2AQ/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8822 Received-SPF: pass client-ip=194.104.111.102; envelope-from=mchang@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 04:16:17 -0000 On Tue, Jul 13, 2021 at 11:25:49AM +0200, Paul Menzel wrote: > Dear Petr, dear Jeff, >=20 >=20 > Am 08.07.21 um 17:55 schrieb Petr Vorel: > > From: Jeff Mahoney > >=20 > > sysfs_partition_path calls udevadm to resolve the sysfs path for > > a block device. That can be accomplished by stating the device node > > and using the major/minor to follow the symlinks in /sys/dev/block/. > >=20 > > This cuts the execution time of grub2-mkconfig from 10s to 2s on > > my system. >=20 > Petr, where you able to reproduce this issue? Could the specifications of > Jeff=E2=80=99s system be added to the commit message? >=20 > > Signed-off-by: Jeff Mahoney > > [ pvorel: include grub/osdep/major.h ] > > Signed-off-by: Petr Vorel > > --- > > grub-core/osdep/linux/hostdisk.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > >=20 > > diff --git a/grub-core/osdep/linux/hostdisk.c b/grub-core/osdep/linux/h= ostdisk.c > > index da62f924e..43dc4b0ba 100644 > > --- a/grub-core/osdep/linux/hostdisk.c > > +++ b/grub-core/osdep/linux/hostdisk.c > > @@ -31,6 +31,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > @@ -105,6 +106,13 @@ sysfs_partition_path (const char *dev, const char = *entry) > > char *buf =3D NULL; > > size_t len =3D 0; > > char *path =3D NULL; > > + struct stat st; > > + int ret; > > + > > + ret =3D stat(dev, &st); > > + if (ret =3D=3D 0 && S_ISBLK(st.st_mode)) > > + return xasprintf ("/sys/dev/block/%u:%u/%s", > > + major (st.st_rdev), minor (st.st_rdev), entry); > > argv[0] =3D "udevadm"; > > argv[1] =3D "info"; >=20 > Now the non-block device case has one stat call more executed each time. Practically this should not happen imho, as the device here are returned by grub_guess_root_devices() to which underlying block devices is used by a given path or mount point. Thanks, Michael >=20 >=20 > Kind regards, >=20 > Paul >=20