From: Shawn Guo <shawn.guo@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] power: reset: qcom-pon: Add support for 'qcom,pon-reboot-not-used'
Date: Wed, 14 Jul 2021 19:49:57 +0800 [thread overview]
Message-ID: <20210714114957.GF11342@dragon> (raw)
In-Reply-To: <YOx3+qy2JhmLP87r@yoga>
On Mon, Jul 12, 2021 at 12:12:26PM -0500, Bjorn Andersson wrote:
> On Sun 04 Jul 21:50 CDT 2021, Shawn Guo wrote:
>
> > Check property 'qcom,pon-reboot-not-used' and skip reboot-mode setup
> > if the property is present. This is useful for devices that use IMEM
> > instead of PON register to pass reboot mode, but still want to populate
> > pwrkey and resin devices.
> >
>
> If IMEM is used instead, I think it should be sufficient for the DT
> author to omit mode-* properties to achieve this.
Indeed! This is much better solution. Thanks for the suggestion!
So please disregard patch #2 and #3, and I will resend #1 as a separate
patch.
Shawn
> If the PON hardware
> doesn't support mode-*, then that should be reflected in the DT binding
> and compatible.
prev parent reply other threads:[~2021-07-14 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 2:50 [PATCH 0/3] Add 'qcom,pon-reboot-not-used' support in PON driver Shawn Guo
2021-07-05 2:50 ` [PATCH 1/3] dt-bindings: power: reset: Convert qcom,pon to DT schema Shawn Guo
2021-07-12 15:45 ` Rob Herring
2021-07-14 11:47 ` Shawn Guo
2021-07-05 2:50 ` [PATCH 2/3] dt-bindings: qcom,pon: Add 'qcom,pon-reboot-not-used' property Shawn Guo
2021-07-12 17:08 ` Bjorn Andersson
2021-07-05 2:50 ` [PATCH 3/3] power: reset: qcom-pon: Add support for 'qcom,pon-reboot-not-used' Shawn Guo
2021-07-12 17:12 ` Bjorn Andersson
2021-07-14 11:49 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714114957.GF11342@dragon \
--to=shawn.guo@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=stephan@gerhold.net \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.