From: Rob Herring <robh@kernel.org>
To: 권오훈 <ohoono.kwon@samsung.com>
Cc: "frowand.list@gmail.com" <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"ohkwon1043@gmail.com" <ohkwon1043@gmail.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Subject: Re: [PATCH] of: fdt: remove unnecessary codes
Date: Wed, 14 Jul 2021 16:50:26 -0600 [thread overview]
Message-ID: <20210714225026.GA3683016@robh.at.kernel.org> (raw)
In-Reply-To: <20210701140457epcms1p2cc43a7c62150f012619feab913f017af@epcms1p2>
On Thu, 01 Jul 2021 23:04:57 +0900, 권오훈 wrote:
> While unflattening the device tree, we try to populate dt nodes and
> properties into tree-shaped data structure.
>
> In populate_properties function, pprev is initially set to
> &np->properties, and then updated to &pp->next.
>
> In both scenarios *pprev is NULL, since the memory area that we are
> allocating from is initially zeroed.
>
> I tested the code as below, and it showed that BUG was never called.
>
> - if (!dryrun)
> + if (!dryrun) {
> + if (*pprev)
> + BUG();
> *pprev = NULL;
> + }
>
> Let's remove unnecessary code.
>
> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
> ---
> drivers/of/fdt.c | 3 ---
> 1 file changed, 3 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-07-14 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210701140328epcms1p85149318b6c18fa18b3c7c8e966c14db0@epcms1p2>
2021-07-01 14:04 ` [PATCH] of: fdt: remove unnecessary codes 권오훈
2021-07-14 22:50 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714225026.GA3683016@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ohkwon1043@gmail.com \
--cc=ohoono.kwon@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.