From: Jason Gunthorpe <jgg@nvidia.com>
To: Halil Pasic <pasic@linux.ibm.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
borntraeger@de.ibm.com, cohuck@redhat.com,
pasic@linux.vnet.ibm.com, jjherne@linux.ibm.com,
alex.williamson@redhat.com, kwankhede@nvidia.com,
frankja@linux.ibm.com, david@redhat.com, imbrenda@linux.ibm.com,
hca@linux.ibm.com
Subject: Re: [PATCH] s390/vfio-ap: do not open code locks for VFIO_GROUP_NOTIFY_SET_KVM notification
Date: Thu, 15 Jul 2021 11:57:21 -0300 [thread overview]
Message-ID: <20210715145721.GE543781@nvidia.com> (raw)
In-Reply-To: <20210715133136.420c40b0.pasic@linux.ibm.com>
On Thu, Jul 15, 2021 at 01:31:36PM +0200, Halil Pasic wrote:
> I'm in favor of rewriting this to use rw_semaphore. I'm not in favor
> of proclaiming this a fix for stable, because for that you first have
> to prove that you fix a real problem.
So Tony keeps saying that a rwsem couldn't work for what kvm_busy
does, so it should be trivial enough to put in the rwsem and capture
the lockdep spew.
> I hope we are on the same page.
Sure
Jason
next prev parent reply other threads:[~2021-07-15 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 15:41 [PATCH] s390/vfio-ap: do not open code locks for VFIO_GROUP_NOTIFY_SET_KVM notification Tony Krowiak
2021-07-12 13:42 ` Tony Krowiak
2021-07-12 23:38 ` Halil Pasic
2021-07-13 13:48 ` Tony Krowiak
2021-07-13 16:45 ` Halil Pasic
2021-07-13 17:05 ` Jason Gunthorpe
2021-07-13 19:04 ` Tony Krowiak
2021-07-13 19:21 ` Jason Gunthorpe
2021-07-14 13:25 ` Tony Krowiak
2021-07-14 17:56 ` Christian Borntraeger
2021-07-14 18:43 ` Jason Gunthorpe
2021-07-14 19:02 ` Alex Williamson
2021-07-15 11:31 ` Halil Pasic
2021-07-15 14:57 ` Jason Gunthorpe [this message]
2021-07-13 18:47 ` Tony Krowiak
2021-07-15 13:44 ` Halil Pasic
2021-07-15 14:38 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715145721.GE543781@nvidia.com \
--to=jgg@nvidia.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.