From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F7BC636C9 for ; Fri, 16 Jul 2021 00:56:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7758A613E4 for ; Fri, 16 Jul 2021 00:56:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7758A613E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ursDrZE4rEl8KgSLqfKLQAqMsEpRcRYJB5J3aQ2FEJM=; b=LQTexdg/mx/j0s CBHK7T7oFW/x71UzXZIdfkB52ggBLwxSye/89JIev/eppvor61ASJuXxnt/h3EHivJg7ksDifE5AE UWlFG1AsXihw94IMXBqAUcmew791c3A87KIgkcFARJrlqwiUvPY5gtqsLbkD7KgmFGjU+kPJgX6Js 6QphomsvATk3JJMnbiXEvDKMY0Xhg3ZrigM+/+L2QG51yf2WrqKkUL+bdVeV4NZJ6b1BJcsmuLKBl R1Bpt2QUlkADvpMc1IY/Bvrlg0qvB0TPDolMlNd6hZVksEK2BvM47bXFZ1/yjVdnw8u+KlqeFHAQL 3guQ/H2tdeiZ4kjxhZ9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4C7R-002mRj-Up; Fri, 16 Jul 2021 00:54:22 +0000 Received: from mga01.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4C7O-002mRG-3R for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 00:54:19 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="232483507" X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="232483507" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 17:54:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="494767129" Received: from linux.intel.com ([10.54.29.200]) by orsmga001.jf.intel.com with ESMTP; 15 Jul 2021 17:54:15 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 4586158073D; Thu, 15 Jul 2021 17:54:12 -0700 (PDT) Date: Fri, 16 Jul 2021 08:54:08 +0800 From: Wong Vee Khee To: Joakim Zhang Cc: "menglong8.dong@gmail.com" , "davem@davemloft.net" , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "kuba@kernel.org" , "mcoquelin.stm32@gmail.com" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Zhang Yunkai , Zeal Robot Subject: Re: [PATCH linux-next] net:stmmac: Fix the unsigned expression compared with zero Message-ID: <20210716005408.GA31939@linux.intel.com> References: <20210715074539.226600-1-zhang.yunkai@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_175418_216284_67E58025 X-CRM114-Status: GOOD ( 30.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdWwgMTUsIDIwMjEgYXQgMTA6MTI6MDRBTSArMDAwMCwgSm9ha2ltIFpoYW5nIHdy b3RlOgo+IAo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IG1lbmdsb25n OC5kb25nQGdtYWlsLmNvbSA8bWVuZ2xvbmc4LmRvbmdAZ21haWwuY29tPgo+ID4gU2VudDogMjAy MeW5tDfmnIgxNeaXpSAxNTo0Ngo+ID4gVG86IGRhdmVtQGRhdmVtbG9mdC5uZXQKPiA+IENjOiBw ZXBwZS5jYXZhbGxhcm9Ac3QuY29tOyBhbGV4YW5kcmUudG9yZ3VlQGZvc3Muc3QuY29tOwo+ID4g am9hYnJldUBzeW5vcHN5cy5jb207IGt1YmFAa2VybmVsLm9yZzsgbWNvcXVlbGluLnN0bTMyQGdt YWlsLmNvbTsKPiA+IG5ldGRldkB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LXN0bTMyQHN0LW1kLW1h aWxtYW4uc3Rvcm1yZXBseS5jb207Cj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IFpoYW5nCj4gPiBZdW5rYWkgPHpo YW5nLnl1bmthaUB6dGUuY29tLmNuPjsgWmVhbCBSb2JvdCA8emVhbGNpQHp0ZS5jb20uY24+Cj4g PiBTdWJqZWN0OiBbUEFUQ0ggbGludXgtbmV4dF0gbmV0OnN0bW1hYzogRml4IHRoZSB1bnNpZ25l ZCBleHByZXNzaW9uIGNvbXBhcmVkCj4gPiB3aXRoIHplcm8KPiA+IAo+ID4gRnJvbTogWmhhbmcg WXVua2FpIDx6aGFuZy55dW5rYWlAenRlLmNvbS5jbj4KPiA+IAo+ID4gV0FSTklORzogIFVuc2ln bmVkIGV4cHJlc3Npb24gInF1ZXVlIiBjb21wYXJlZCB3aXRoIHplcm8uCj4gPiBSZXBvcnRlZC1i eTogWmVhbCBSb2JvdCA8emVhbGNpQHp0ZS5jb20uY24+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBaaGFu ZyBZdW5rYWkgPHpoYW5nLnl1bmthaUB6dGUuY29tLmNuPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9u ZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFjX21haW4uYyB8IDggKystLS0tLS0KPiA+ ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+ID4gCj4g PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvc3RtaWNyby9zdG1tYWMvc3RtbWFj X21haW4uYwo+ID4gYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9zdG1pY3JvL3N0bW1hYy9zdG1tYWNf bWFpbi5jCj4gPiBpbmRleCA3Yjg0MDRhMjE1NDQuLmE0Y2YyYzY0MDUzMSAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19tYWluLmMKPiA+ ICsrKyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L3N0bWljcm8vc3RtbWFjL3N0bW1hY19tYWluLmMK PiA+IEBAIC0xNjk5LDcgKzE2OTksNyBAQCBzdGF0aWMgaW50IGluaXRfZG1hX3J4X2Rlc2Nfcmlu Z3Moc3RydWN0IG5ldF9kZXZpY2UKPiA+ICpkZXYsIGdmcF90IGZsYWdzKQo+ID4gIAlyZXR1cm4g MDsKPiA+IAo+ID4gIGVycl9pbml0X3J4X2J1ZmZlcnM6Cj4gPiAtCXdoaWxlIChxdWV1ZSA+PSAw KSB7Cj4gPiArCWRvIHsKPiA+ICAJCXN0cnVjdCBzdG1tYWNfcnhfcXVldWUgKnJ4X3EgPSAmcHJp di0+cnhfcXVldWVbcXVldWVdOwo+ID4gCj4gPiAgCQlpZiAocnhfcS0+eHNrX3Bvb2wpCj4gPiBA QCAtMTcxMCwxMSArMTcxMCw3IEBAIHN0YXRpYyBpbnQgaW5pdF9kbWFfcnhfZGVzY19yaW5ncyhz dHJ1Y3QKPiA+IG5ldF9kZXZpY2UgKmRldiwgZ2ZwX3QgZmxhZ3MpCj4gPiAgCQlyeF9xLT5idWZf YWxsb2NfbnVtID0gMDsKPiA+ICAJCXJ4X3EtPnhza19wb29sID0gTlVMTDsKPiA+IAo+ID4gLQkJ aWYgKHF1ZXVlID09IDApCj4gPiAtCQkJYnJlYWs7Cj4gPiAtCj4gPiAtCQlxdWV1ZS0tOwo+ID4g LQl9Cj4gPiArCX0gd2hpbGUgKHF1ZXVlLS0pOwo+ID4gCj4gPiAgCXJldHVybiByZXQ7Cj4gPiAg fQo+IAo+IAo+IFRoaXMgaXMgYSByZWFsIENvdmVyaXR5IGlzc3VlIHNpbmNlIHF1ZXVlIHZhcmlh YmxlIGlzIGRlZmluZWQgYXMgdTMyLCBidXQgdGhlcmUgaXMgbm8gYnJlYWthZ2UgZnJvbSBsb2dp YywgaXQgd2lsbCBicmVhayB3aGlsZSBsb29wIHdoZW4gcXVldWUgZXF1YWwgMCwgYW5kIHF1ZXVl WzBdIGFjdHVhbGx5IG5lZWQgYmUgaGFuZGxlZC4KPiBBZnRlciB5b3VyIGNvZGUgY2hhbmdlLCBx dWV1ZVswXSB3aWxsIG5vdCBiZSBoYW5kbGVkLCByaWdodD8gSXQgd2lsbCBicmVhayB0aGUgbG9n aWMuIElmIHlvdSB3YW50IHRvIGZpeCB0aGUgdGhpcyBpc3N1ZSwgSSB0aGluayB0aGUgZWFzaWVz dCB3YXkgaXMgdG8gZGVmaW5lIHF1ZXVlIHZhcmlhYmxlIHRvIGludC4KPiAKPiBCZXN0IFJlZ2Fy ZHMsCj4gSm9ha2ltIFpoYW5nCj4gPiAtLQo+ID4gMi4yNS4xCj4KClRoZSBmdW5jdGlvbiAnX19p bml0X2RtYV9yeF9kZXNjX3JpbmdzJyBpcyBleHBlY3RpbmcgJ3F1ZXVlJyB0byBiZSB1MzIgdHlw ZS4KSSB3b3VsZCBzdWdnZXN0IHRoZSBmb2xsb3dpbmc6LQoKQEAgLTE2ODYsNiArMTY4Niw3IEBA IHN0YXRpYyBpbnQgaW5pdF9kbWFfcnhfZGVzY19yaW5ncyhzdHJ1Y3QgbmV0X2RldmljZSAqZGV2 LCBnZnBfdCBmbGFncykKICAgICAgICBzdHJ1Y3Qgc3RtbWFjX3ByaXYgKnByaXYgPSBuZXRkZXZf cHJpdihkZXYpOwogICAgICAgIHUzMiByeF9jb3VudCA9IHByaXYtPnBsYXQtPnJ4X3F1ZXVlc190 b191c2U7CiAgICAgICAgdTMyIHF1ZXVlOworICAgICAgIHUzMiBpOwogICAgICAgIGludCByZXQ7 CgogICAgICAgIC8qIFJYIElOSVRJQUxJWkFUSU9OICovCkBAIC0xNzAxLDIxICsxNzAyLDE2IEBA IHN0YXRpYyBpbnQgaW5pdF9kbWFfcnhfZGVzY19yaW5ncyhzdHJ1Y3QgbmV0X2RldmljZSAqZGV2 LCBnZnBfdCBmbGFncykKICAgICAgICByZXR1cm4gMDsKCiBlcnJfaW5pdF9yeF9idWZmZXJzOgot ICAgICAgIHdoaWxlIChxdWV1ZSA+PSAwKSB7Ci0gICAgICAgICAgICAgICBzdHJ1Y3Qgc3RtbWFj X3J4X3F1ZXVlICpyeF9xID0gJnByaXYtPnJ4X3F1ZXVlW3F1ZXVlXTsKKyAgICAgICBmb3IgKGkg PSAwOyBpIDw9IHF1ZXVlOyBpKyspIHsKKyAgICAgICAgICAgICAgIHN0cnVjdCBzdG1tYWNfcnhf cXVldWUgKnJ4X3EgPSAmcHJpdi0+cnhfcXVldWVbaV07CgogICAgICAgICAgICAgICAgaWYgKHJ4 X3EtPnhza19wb29sKQotICAgICAgICAgICAgICAgICAgICAgICBkbWFfZnJlZV9yeF94c2tidWZz KHByaXYsIHF1ZXVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgZG1hX2ZyZWVfcnhfeHNrYnVm cyhwcml2LCBpKTsKICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICAgICAgICAg ZG1hX2ZyZWVfcnhfc2tidWZzKHByaXYsIHF1ZXVlKTsKKyAgICAgICAgICAgICAgICAgICAgICAg ZG1hX2ZyZWVfcnhfc2tidWZzKHByaXYsIGkpOwoKICAgICAgICAgICAgICAgIHJ4X3EtPmJ1Zl9h bGxvY19udW0gPSAwOwogICAgICAgICAgICAgICAgcnhfcS0+eHNrX3Bvb2wgPSBOVUxMOwotCi0g ICAgICAgICAgICAgICBpZiAocXVldWUgPT0gMCkKLSAgICAgICAgICAgICAgICAgICAgICAgYnJl YWs7Ci0KLSAgICAgICAgICAgICAgIHF1ZXVlLS07CiAgICAgICAgfQoKUmVnYXJkcywKIFZLIAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F053C636C9 for ; Fri, 16 Jul 2021 00:54:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F22860E0B for ; Fri, 16 Jul 2021 00:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232635AbhGPA5M (ORCPT ); Thu, 15 Jul 2021 20:57:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:31713 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbhGPA5K (ORCPT ); Thu, 15 Jul 2021 20:57:10 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10046"; a="210700234" X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="210700234" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 17:54:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,243,1620716400"; d="scan'208";a="494767129" Received: from linux.intel.com ([10.54.29.200]) by orsmga001.jf.intel.com with ESMTP; 15 Jul 2021 17:54:15 -0700 Received: from linux.intel.com (vwong3-iLBPG3.png.intel.com [10.88.229.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by linux.intel.com (Postfix) with ESMTPS id 4586158073D; Thu, 15 Jul 2021 17:54:12 -0700 (PDT) Date: Fri, 16 Jul 2021 08:54:08 +0800 From: Wong Vee Khee To: Joakim Zhang Cc: "menglong8.dong@gmail.com" , "davem@davemloft.net" , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "kuba@kernel.org" , "mcoquelin.stm32@gmail.com" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Zhang Yunkai , Zeal Robot Subject: Re: [PATCH linux-next] net:stmmac: Fix the unsigned expression compared with zero Message-ID: <20210716005408.GA31939@linux.intel.com> References: <20210715074539.226600-1-zhang.yunkai@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 10:12:04AM +0000, Joakim Zhang wrote: > > > -----Original Message----- > > From: menglong8.dong@gmail.com > > Sent: 2021年7月15日 15:46 > > To: davem@davemloft.net > > Cc: peppe.cavallaro@st.com; alexandre.torgue@foss.st.com; > > joabreu@synopsys.com; kuba@kernel.org; mcoquelin.stm32@gmail.com; > > netdev@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; > > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Zhang > > Yunkai ; Zeal Robot > > Subject: [PATCH linux-next] net:stmmac: Fix the unsigned expression compared > > with zero > > > > From: Zhang Yunkai > > > > WARNING: Unsigned expression "queue" compared with zero. > > Reported-by: Zeal Robot > > Signed-off-by: Zhang Yunkai > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 8 ++------ > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > index 7b8404a21544..a4cf2c640531 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > @@ -1699,7 +1699,7 @@ static int init_dma_rx_desc_rings(struct net_device > > *dev, gfp_t flags) > > return 0; > > > > err_init_rx_buffers: > > - while (queue >= 0) { > > + do { > > struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; > > > > if (rx_q->xsk_pool) > > @@ -1710,11 +1710,7 @@ static int init_dma_rx_desc_rings(struct > > net_device *dev, gfp_t flags) > > rx_q->buf_alloc_num = 0; > > rx_q->xsk_pool = NULL; > > > > - if (queue == 0) > > - break; > > - > > - queue--; > > - } > > + } while (queue--); > > > > return ret; > > } > > > This is a real Coverity issue since queue variable is defined as u32, but there is no breakage from logic, it will break while loop when queue equal 0, and queue[0] actually need be handled. > After your code change, queue[0] will not be handled, right? It will break the logic. If you want to fix the this issue, I think the easiest way is to define queue variable to int. > > Best Regards, > Joakim Zhang > > -- > > 2.25.1 > The function '__init_dma_rx_desc_rings' is expecting 'queue' to be u32 type. I would suggest the following:- @@ -1686,6 +1686,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) struct stmmac_priv *priv = netdev_priv(dev); u32 rx_count = priv->plat->rx_queues_to_use; u32 queue; + u32 i; int ret; /* RX INITIALIZATION */ @@ -1701,21 +1702,16 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) return 0; err_init_rx_buffers: - while (queue >= 0) { - struct stmmac_rx_queue *rx_q = &priv->rx_queue[queue]; + for (i = 0; i <= queue; i++) { + struct stmmac_rx_queue *rx_q = &priv->rx_queue[i]; if (rx_q->xsk_pool) - dma_free_rx_xskbufs(priv, queue); + dma_free_rx_xskbufs(priv, i); else - dma_free_rx_skbufs(priv, queue); + dma_free_rx_skbufs(priv, i); rx_q->buf_alloc_num = 0; rx_q->xsk_pool = NULL; - - if (queue == 0) - break; - - queue--; } Regards, VK