From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952C7C636C8 for ; Thu, 15 Jul 2021 22:57:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6061C613AF for ; Thu, 15 Jul 2021 22:57:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6061C613AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=teTFeOVIu+u1CwtOM9hpSwmeaQ6/7icu6P0ZHlhDocU=; b=SrS3v/Xjyn7/WB snhX6p1lFfV6J7DrT82Dj/I6D2GOBgYMtfNSD0LWpThgfSlkvsjdLJrv0idhNuCp88IUV1XsYZCm6 nM8ooiNnE8vaMRpuiV65TX6yLxrO2svF1WeGm1FomXqafrw6VKSr4mh/RI2vF/OIlNsCH90EXf7sQ Tbe5dCYDdgBrkbVGmWodASRmvgSM+QK3gAr0nLKWGCA4Lo5CLrNd/KCyX/VDyb5l79dChOIVfti7B LseeBk6dyl8YhOPH1bN6SOHA+ZS6aWNupZ6ekE++qg3SupImKEMYV372/nYK1eWNqxTZmzT8GFwYL A+b/9t/hEkEf2HvwpwiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4AIZ-002aZE-NP; Thu, 15 Jul 2021 22:57:43 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4AIX-002aY4-1z for linux-i3c@lists.infradead.org; Thu, 15 Jul 2021 22:57:42 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8287F1BF205; Thu, 15 Jul 2021 22:57:38 +0000 (UTC) Date: Fri, 16 Jul 2021 00:57:37 +0200 From: Miquel Raynal To: Clark Wang Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, vitor.soares@synopsys.com, boris.brezillon@bootlin.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal Message-ID: <20210716005737.49760d66@xps13> In-Reply-To: <20210715082413.3042149-5-xiaoning.wang@nxp.com> References: <20210715082413.3042149-1-xiaoning.wang@nxp.com> <20210715082413.3042149-5-xiaoning.wang@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210715_155741_308532_C13D4385 X-CRM114-Status: GOOD ( 15.02 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org SGkgQ2xhcmssCgpDbGFyayBXYW5nIDx4aWFvbmluZy53YW5nQG54cC5jb20+IHdyb3RlIG9uIFRo dSwgMTUgSnVsIDIwMjEgMTY6MjQ6MTMKKzA4MDA6Cgo+IElmIHVzaW5nIEkyQy9JM0MgbWl4ZWQg bW9kZSwgbmVlZCB0byBzZXQgT0RTVE9QLiBPdGhlcndpc2UsIHRoZSBJMkMKPiBkZXZpY2VzIGNh bm5vdCBzZWUgdGhlIHN0b3Agc2lnbmFsLiBJdCBtYXkgY2F1c2UgbWVzc2FnZSBzZW5kaW5nIGVy cm9ycy4KClJldmlld2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4u Y29tPgoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBDbGFyayBXYW5nIDx4aWFvbmluZy53YW5nQG54cC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jIHwgNyArKysr Ky0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jIGIvZHJp dmVycy9pM2MvbWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMKPiBpbmRleCA4OTJlNTdmZWM0YjAuLmIw NWNjN2Y1MjFlNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjLWkzYy1tYXN0 ZXIuYwo+ICsrKyBiL2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jCj4gQEAgLTQ0 OSw3ICs0NDksNyBAQCBzdGF0aWMgaW50IHN2Y19pM2NfbWFzdGVyX2J1c19pbml0KHN0cnVjdCBp M2NfbWFzdGVyX2NvbnRyb2xsZXIgKm0pCj4gIAlzdHJ1Y3QgaTNjX2RldmljZV9pbmZvIGluZm8g PSB7fTsKPiAgCXVuc2lnbmVkIGxvbmcgZmNsa19yYXRlLCBmY2xrX3BlcmlvZF9uczsKPiAgCXVu c2lnbmVkIGludCBoaWdoX3BlcmlvZF9ucywgb2RfbG93X3BlcmlvZF9uczsKPiAtCXUzMiBwcGJh dWQsIHBwbG93LCBvZGhwcCwgb2RiYXVkLCBpMmNiYXVkLCByZWc7Cj4gKwl1MzIgcHBiYXVkLCBw cGxvdywgb2RocHAsIG9kYmF1ZCwgb2RzdG9wLCBpMmNiYXVkLCByZWc7Cj4gIAlpbnQgcmV0Owo+ ICAKPiAgCS8qIFRpbWluZ3MgZGVyaXZhdGlvbiAqLwo+IEBAIC00NzksNiArNDc5LDcgQEAgc3Rh dGljIGludCBzdmNfaTNjX21hc3Rlcl9idXNfaW5pdChzdHJ1Y3QgaTNjX21hc3Rlcl9jb250cm9s bGVyICptKQo+ICAJc3dpdGNoIChidXMtPm1vZGUpIHsKPiAgCWNhc2UgSTNDX0JVU19NT0RFX1BV UkU6Cj4gIAkJaTJjYmF1ZCA9IDA7Cj4gKwkJb2RzdG9wID0gMDsKPiAgCQlicmVhazsKPiAgCWNh c2UgSTNDX0JVU19NT0RFX01JWEVEX0ZBU1Q6Cj4gIAljYXNlIEkzQ19CVVNfTU9ERV9NSVhFRF9M SU1JVEVEOgo+IEBAIC00ODcsNiArNDg4LDcgQEAgc3RhdGljIGludCBzdmNfaTNjX21hc3Rlcl9i dXNfaW5pdChzdHJ1Y3QgaTNjX21hc3Rlcl9jb250cm9sbGVyICptKQo+ICAJCSAqIGJldHdlZW4g dGhlIGhpZ2ggYW5kIGxvdyBwZXJpb2QgZG9lcyBub3QgcmVhbGx5IG1hdHRlci4KPiAgCQkgKi8K PiAgCQlpMmNiYXVkID0gRElWX1JPVU5EX1VQKDEwMDAsIG9kX2xvd19wZXJpb2RfbnMpIC0gMjsK PiArCQlvZHN0b3AgPSAxOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBJM0NfQlVTX01PREVfTUlYRURf U0xPVzoKPiAgCQkvKgo+IEBAIC00OTQsNiArNDk2LDcgQEAgc3RhdGljIGludCBzdmNfaTNjX21h c3Rlcl9idXNfaW5pdChzdHJ1Y3QgaTNjX21hc3Rlcl9jb250cm9sbGVyICptKQo+ICAJCSAqIGNv bnN0cmFpbnRzIGFzIHRoZSBGTSsgbW9kZS4KPiAgCQkgKi8KPiAgCQlpMmNiYXVkID0gRElWX1JP VU5EX1VQKDI1MDAsIG9kX2xvd19wZXJpb2RfbnMpIC0gMjsKPiArCQlvZHN0b3AgPSAxOwo+ICAJ CWJyZWFrOwo+ICAJZGVmYXVsdDoKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtNTAyLDcgKzUw NSw3IEBAIHN0YXRpYyBpbnQgc3ZjX2kzY19tYXN0ZXJfYnVzX2luaXQoc3RydWN0IGkzY19tYXN0 ZXJfY29udHJvbGxlciAqbSkKPiAgCXJlZyA9IFNWQ19JM0NfTUNPTkZJR19NQVNURVJfRU4gfAo+ ICAJICAgICAgU1ZDX0kzQ19NQ09ORklHX0RJU1RPKDApIHwKPiAgCSAgICAgIFNWQ19JM0NfTUNP TkZJR19IS0VFUCgwKSB8Cj4gLQkgICAgICBTVkNfSTNDX01DT05GSUdfT0RTVE9QKDApIHwKPiAr CSAgICAgIFNWQ19JM0NfTUNPTkZJR19PRFNUT1Aob2RzdG9wKSB8Cj4gIAkgICAgICBTVkNfSTND X01DT05GSUdfUFBCQVVEKHBwYmF1ZCkgfAo+ICAJICAgICAgU1ZDX0kzQ19NQ09ORklHX1BQTE9X KHBwbG93KSB8Cj4gIAkgICAgICBTVkNfSTNDX01DT05GSUdfT0RCQVVEKG9kYmF1ZCkgfAoKCgoK VGhhbmtzLApNaXF1w6hsCgotLSAKbGludXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWkzYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2576BC636C9 for ; Thu, 15 Jul 2021 22:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1C83613D2 for ; Thu, 15 Jul 2021 22:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231539AbhGOXAe convert rfc822-to-8bit (ORCPT ); Thu, 15 Jul 2021 19:00:34 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45971 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229624AbhGOXAd (ORCPT ); Thu, 15 Jul 2021 19:00:33 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 8287F1BF205; Thu, 15 Jul 2021 22:57:38 +0000 (UTC) Date: Fri, 16 Jul 2021 00:57:37 +0200 From: Miquel Raynal To: Clark Wang Cc: conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, vitor.soares@synopsys.com, boris.brezillon@bootlin.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] i3c: master: svc: set ODSTOP to let I2C device see the STOP signal Message-ID: <20210716005737.49760d66@xps13> In-Reply-To: <20210715082413.3042149-5-xiaoning.wang@nxp.com> References: <20210715082413.3042149-1-xiaoning.wang@nxp.com> <20210715082413.3042149-5-xiaoning.wang@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clark, Clark Wang wrote on Thu, 15 Jul 2021 16:24:13 +0800: > If using I2C/I3C mixed mode, need to set ODSTOP. Otherwise, the I2C > devices cannot see the stop signal. It may cause message sending errors. Reviewed-by: Miquel Raynal > > Signed-off-by: Clark Wang > --- > drivers/i3c/master/svc-i3c-master.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 892e57fec4b0..b05cc7f521e6 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -449,7 +449,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m) > struct i3c_device_info info = {}; > unsigned long fclk_rate, fclk_period_ns; > unsigned int high_period_ns, od_low_period_ns; > - u32 ppbaud, pplow, odhpp, odbaud, i2cbaud, reg; > + u32 ppbaud, pplow, odhpp, odbaud, odstop, i2cbaud, reg; > int ret; > > /* Timings derivation */ > @@ -479,6 +479,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m) > switch (bus->mode) { > case I3C_BUS_MODE_PURE: > i2cbaud = 0; > + odstop = 0; > break; > case I3C_BUS_MODE_MIXED_FAST: > case I3C_BUS_MODE_MIXED_LIMITED: > @@ -487,6 +488,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m) > * between the high and low period does not really matter. > */ > i2cbaud = DIV_ROUND_UP(1000, od_low_period_ns) - 2; > + odstop = 1; > break; > case I3C_BUS_MODE_MIXED_SLOW: > /* > @@ -494,6 +496,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m) > * constraints as the FM+ mode. > */ > i2cbaud = DIV_ROUND_UP(2500, od_low_period_ns) - 2; > + odstop = 1; > break; > default: > return -EINVAL; > @@ -502,7 +505,7 @@ static int svc_i3c_master_bus_init(struct i3c_master_controller *m) > reg = SVC_I3C_MCONFIG_MASTER_EN | > SVC_I3C_MCONFIG_DISTO(0) | > SVC_I3C_MCONFIG_HKEEP(0) | > - SVC_I3C_MCONFIG_ODSTOP(0) | > + SVC_I3C_MCONFIG_ODSTOP(odstop) | > SVC_I3C_MCONFIG_PPBAUD(ppbaud) | > SVC_I3C_MCONFIG_PPLOW(pplow) | > SVC_I3C_MCONFIG_ODBAUD(odbaud) | Thanks, Miquèl