All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/binutils: fix linker assert on OpenRisc
Date: Fri, 16 Jul 2021 22:52:53 +0200	[thread overview]
Message-ID: <20210716225253.68956897@windsurf> (raw)
In-Reply-To: <20210712104501.2276261-2-giulio.benetti@benettiengineering.com>

On Mon, 12 Jul 2021 12:45:01 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> When building openal we were seeing the assert failure:
> 
> /home/buildroot/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: CMakeFiles/OpenAL.dir/al/source.cpp.o:
> pc-relative relocation against dynamic symbol alSourcePausev
> /home/buildroot/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: CMakeFiles/OpenAL.dir/al/source.cpp.o:
> pc-relative relocation against dynamic symbol alSourceStopv
> /home/buildroot/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: CMakeFiles/OpenAL.dir/al/source.cpp.o:
> pc-relative relocation against dynamic symbol alSourceRewindv
> /home/buildroot/autobuild/run/instance-0/output-1/host/opt/ext-toolchain/bin/../lib/gcc/or1k-buildroot-linux-uclibc/9.3.0/../../../../or1k-buildroot-linux-uclibc/bin/ld: CMakeFiles/OpenAL.dir/al/source.cpp.o:
> pc-relative relocation against dynamic symbol alSourcePlayv
> collect2: error: ld returned 1 exit status
> 
> So add patches to fix this binutils assert link failure on OpenRisc.
> It's been suggested upstream and it's pending here:
> https://sourceware.org/pipermail/binutils/2021-July/117334.html
> 
> Fixes:
> http://autobuild.buildroot.net/results/c96/c96f2600f227d6c76114b9fbc41f74a57e40415a/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  ...tive-relocation-against-dynamic-on-P.patch | 59 +++++++++++++++++++
>  ...tive-relocation-against-dynamic-on-P.patch | 59 +++++++++++++++++++
>  ...tive-relocation-against-dynamic-on-P.patch | 59 +++++++++++++++++++
>  ...tive-relocation-against-dynamic-on-P.patch | 59 +++++++++++++++++++
>  4 files changed, 236 insertions(+)
>  create mode 100644 package/binutils/2.32/0015-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
>  create mode 100644 package/binutils/2.34/0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
>  create mode 100644 package/binutils/2.35.2/0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch
>  create mode 100644 package/binutils/2.36.1/0008-or1k-fix-pc-relative-relocation-against-dynamic-on-P.patch

Wow, thanks a lot for this work! Really amazing that you've been able
to push this through!

Applied to master, of course!

Thanks again,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2021-07-16 20:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 10:45 [Buildroot] [PATCH 0/1] Fix last OpenRisc binutils bug Giulio Benetti
2021-07-12 10:45 ` [Buildroot] [PATCH 1/1] package/binutils: fix linker assert on OpenRisc Giulio Benetti
2021-07-16 14:14   ` Giulio Benetti
2021-07-16 14:14     ` Giulio Benetti
2021-07-16 20:52   ` Thomas Petazzoni [this message]
2021-07-17  0:27     ` Giulio Benetti
2021-07-17  0:28       ` Giulio Benetti
2021-07-17  0:40         ` Giulio Benetti
2021-07-17  0:40           ` Giulio Benetti
2021-08-03  9:13   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210716225253.68956897@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.