From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [sashal-linux-stable:pending-4.19 387/414] drivers/remoteproc/qcom_q6v5.c:282:16: error: implicit declaration of function 'devm_qcom_smem_state_get'; did you mean 'qcom_smem_state_get'?
Date: Sun, 18 Jul 2021 20:57:56 +0800 [thread overview]
Message-ID: <202107182050.7aPyPT6C-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 6702 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-4.19
head: 2589ac98034d2c19f1303535132ae543640b086c
commit: c515bc15971993cbe9c0824aa210504823966f3e [387/414] remoteproc: qcom_q6v5: Use devm_qcom_smem_state_get() to fix missing put()
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=c515bc15971993cbe9c0824aa210504823966f3e
git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-linux-stable pending-4.19
git checkout c515bc15971993cbe9c0824aa210504823966f3e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
drivers/remoteproc/qcom_q6v5.c: In function 'qcom_q6v5_init':
>> drivers/remoteproc/qcom_q6v5.c:282:16: error: implicit declaration of function 'devm_qcom_smem_state_get'; did you mean 'qcom_smem_state_get'? [-Werror=implicit-function-declaration]
282 | q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| qcom_smem_state_get
>> drivers/remoteproc/qcom_q6v5.c:282:14: warning: assignment to 'struct qcom_smem_state *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
282 | q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
| ^
cc1: some warnings being treated as errors
vim +282 drivers/remoteproc/qcom_q6v5.c
166
167 /**
168 * qcom_q6v5_init() - initializer of the q6v5 common struct
169 * @q6v5: handle to be initialized
170 * @pdev: platform_device reference for acquiring resources
171 * @rproc: associated remoteproc instance
172 * @crash_reason: SMEM id for crash reason string, or 0 if none
173 * @handover: function to be called when proxy resources should be released
174 *
175 * Return: 0 on success, negative errno on failure
176 */
177 int qcom_q6v5_init(struct qcom_q6v5 *q6v5, struct platform_device *pdev,
178 struct rproc *rproc, int crash_reason,
179 void (*handover)(struct qcom_q6v5 *q6v5))
180 {
181 int ret;
182
183 q6v5->rproc = rproc;
184 q6v5->dev = &pdev->dev;
185 q6v5->crash_reason = crash_reason;
186 q6v5->handover = handover;
187
188 init_completion(&q6v5->start_done);
189 init_completion(&q6v5->stop_done);
190
191 q6v5->wdog_irq = platform_get_irq_byname(pdev, "wdog");
192 if (q6v5->wdog_irq < 0) {
193 if (q6v5->wdog_irq != -EPROBE_DEFER)
194 dev_err(&pdev->dev,
195 "failed to retrieve wdog IRQ: %d\n",
196 q6v5->wdog_irq);
197 return q6v5->wdog_irq;
198 }
199
200 ret = devm_request_threaded_irq(&pdev->dev, q6v5->wdog_irq,
201 NULL, q6v5_wdog_interrupt,
202 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
203 "q6v5 wdog", q6v5);
204 if (ret) {
205 dev_err(&pdev->dev, "failed to acquire wdog IRQ\n");
206 return ret;
207 }
208
209 q6v5->fatal_irq = platform_get_irq_byname(pdev, "fatal");
210 if (q6v5->fatal_irq < 0) {
211 if (q6v5->fatal_irq != -EPROBE_DEFER)
212 dev_err(&pdev->dev,
213 "failed to retrieve fatal IRQ: %d\n",
214 q6v5->fatal_irq);
215 return q6v5->fatal_irq;
216 }
217
218 ret = devm_request_threaded_irq(&pdev->dev, q6v5->fatal_irq,
219 NULL, q6v5_fatal_interrupt,
220 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
221 "q6v5 fatal", q6v5);
222 if (ret) {
223 dev_err(&pdev->dev, "failed to acquire fatal IRQ\n");
224 return ret;
225 }
226
227 q6v5->ready_irq = platform_get_irq_byname(pdev, "ready");
228 if (q6v5->ready_irq < 0) {
229 if (q6v5->ready_irq != -EPROBE_DEFER)
230 dev_err(&pdev->dev,
231 "failed to retrieve ready IRQ: %d\n",
232 q6v5->ready_irq);
233 return q6v5->ready_irq;
234 }
235
236 ret = devm_request_threaded_irq(&pdev->dev, q6v5->ready_irq,
237 NULL, q6v5_ready_interrupt,
238 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
239 "q6v5 ready", q6v5);
240 if (ret) {
241 dev_err(&pdev->dev, "failed to acquire ready IRQ\n");
242 return ret;
243 }
244
245 q6v5->handover_irq = platform_get_irq_byname(pdev, "handover");
246 if (q6v5->handover_irq < 0) {
247 if (q6v5->handover_irq != -EPROBE_DEFER)
248 dev_err(&pdev->dev,
249 "failed to retrieve handover IRQ: %d\n",
250 q6v5->handover_irq);
251 return q6v5->handover_irq;
252 }
253
254 ret = devm_request_threaded_irq(&pdev->dev, q6v5->handover_irq,
255 NULL, q6v5_handover_interrupt,
256 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
257 "q6v5 handover", q6v5);
258 if (ret) {
259 dev_err(&pdev->dev, "failed to acquire handover IRQ\n");
260 return ret;
261 }
262 disable_irq(q6v5->handover_irq);
263
264 q6v5->stop_irq = platform_get_irq_byname(pdev, "stop-ack");
265 if (q6v5->stop_irq < 0) {
266 if (q6v5->stop_irq != -EPROBE_DEFER)
267 dev_err(&pdev->dev,
268 "failed to retrieve stop-ack IRQ: %d\n",
269 q6v5->stop_irq);
270 return q6v5->stop_irq;
271 }
272
273 ret = devm_request_threaded_irq(&pdev->dev, q6v5->stop_irq,
274 NULL, q6v5_stop_interrupt,
275 IRQF_TRIGGER_RISING | IRQF_ONESHOT,
276 "q6v5 stop", q6v5);
277 if (ret) {
278 dev_err(&pdev->dev, "failed to acquire stop-ack IRQ\n");
279 return ret;
280 }
281
> 282 q6v5->state = devm_qcom_smem_state_get(&pdev->dev, "stop", &q6v5->stop_bit);
283 if (IS_ERR(q6v5->state)) {
284 dev_err(&pdev->dev, "failed to acquire stop state\n");
285 return PTR_ERR(q6v5->state);
286 }
287
288 return 0;
289 }
290 EXPORT_SYMBOL_GPL(qcom_q6v5_init);
291
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61255 bytes --]
reply other threads:[~2021-07-18 12:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107182050.7aPyPT6C-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.