From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RESEND] power: supply: ab8500: clean up warnings found by cppcheck
Date: Mon, 19 Jul 2021 13:21:25 +0300 [thread overview]
Message-ID: <20210719102124.GT1931@kadam> (raw)
In-Reply-To: <20210719101648.14497-1-colin.king@canonical.com>
On Mon, Jul 19, 2021 at 11:16:48AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Clean up a handful of checkpatch warnings:
The subject says cppcheck but it's actually checkpatch.
> - static const char * array should probably be static const char * const
> - function arguments should have identifier names
> - else should follow close brace '}'
> - suspect code indent for conditional statements
> - unnecessary parentheses in an if condition
> - avoid multiple line dereference
> - prefer using '"%s...", __func__' to using 'ab8500_chargalg_wd_work'
This printk should just be deleted. Use ftrace instea.
> - prefer 'long' over 'long int' as the int is unnecessary
>
regards,
dan carpenter
prev parent reply other threads:[~2021-07-19 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 10:16 [PATCH][RESEND] power: supply: ab8500: clean up warnings found by cppcheck Colin King
2021-07-19 10:21 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719102124.GT1931@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.