From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets
Date: Tue, 20 Jul 2021 09:50:25 +0200 [thread overview]
Message-ID: <20210720075025.GA17565@lst.de> (raw)
In-Reply-To: <20210720044209.851141-1-ming.lei@redhat.com>
> +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> +{
> + /*
> + * Simple invocations do not provide a calc_sets() callback. Call
> + * the generic one.
> + */
> + if (!affd->calc_sets)
> + default_calc_sets(affd, affvecs);
> + else
> + affd->calc_sets(affd, affvecs);
Nit: avoid pointless negations:
if (affd->calc_sets)
affd->calc_sets(affd, affvecs);
else
default_calc_sets(affd, affvecs);
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-07-20 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 4:42 [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets Ming Lei
2021-07-20 7:50 ` Christoph Hellwig [this message]
2021-07-21 0:02 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720075025.GA17565@lst.de \
--to=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.