From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 2/2] iomap: simplify iomap_add_to_ioend
Date: Tue, 20 Jul 2021 14:16:11 +0200 [thread overview]
Message-ID: <20210720121611.GA6540@lst.de> (raw)
In-Reply-To: <YPa9HFTyJV4qIqJ+@casper.infradead.org>
On Tue, Jul 20, 2021 at 01:10:04PM +0100, Matthew Wilcox wrote:
> On Tue, Jul 20, 2021 at 10:43:20AM +0200, Christoph Hellwig wrote:
> > Now that the outstanding writes are counted in bytes, there is no need
> > to use the low-level __bio_try_merge_page API, we can switch back to
> > always using bio_add_page and simply iomap_add_to_ioend again.
>
> These two callers were the only external users of __bio_try_merge_page(),
> so it can now be made static to block/bio.c.
Yeah, but doing so in the same merge window will create an annoying
cross dependency. I have a series to cleanup a whole lot of the
bio_add_page related code including starting to clean up the return
value for the next merge window.
next prev parent reply other threads:[~2021-07-20 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 8:43 [PATCH 1/2] iomap: simplify iomap_readpage_actor Christoph Hellwig
2021-07-20 8:43 ` [PATCH 2/2] iomap: simplify iomap_add_to_ioend Christoph Hellwig
2021-07-20 12:10 ` Matthew Wilcox
2021-07-20 12:16 ` Christoph Hellwig [this message]
2021-07-20 12:27 ` [PATCH 1/2] iomap: simplify iomap_readpage_actor Matthew Wilcox
2021-07-20 13:26 ` Christoph Hellwig
2021-07-20 13:41 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2021-07-22 5:42 cleanup the bio handling in iomap v2 Christoph Hellwig
2021-07-22 5:42 ` [PATCH 2/2] iomap: simplify iomap_add_to_ioend Christoph Hellwig
2021-07-22 19:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720121611.GA6540@lst.de \
--to=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.