From: Arnd Bergmann <arnd@kernel.org>
To: netdev@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH net-next v5 0/4] remove compat_alloc_user_space()
Date: Tue, 20 Jul 2021 16:24:32 +0200 [thread overview]
Message-ID: <20210720142436.2096733-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
This is the fifth version of my series, now spanning four patches
instead of two, with a new approach for handling struct ifreq
compatibility after I realized that my earlier approach introduces
additional problems.
The idea here is to always push down the compat conversion
deeper into the call stack: rather than pretending to be
native mode with a modified copy of the original data on
the user space stack, have the code that actually works on
the data understand the difference between native and compat
versions.
I have spent a long time looking at all drivers that implement
an ndo_do_ioctl callback to verify that my assumptions are
correct. This has led to a series of 29 additional patches
that I am not including here but will post separately, fixing
a number of bugs in SIOCDEVPRIVATE ioctls, removing dead
code, and splitting ndo_do_ioctl into two new ndo callbacks
for private and ethernet specific commands.
The patches are largely identical to v4 that I sent last
November, with small fixes for issues pointed out by Jakub
and my own randconfig build bot.
Arnd
Link: https://lore.kernel.org/netdev/20201124151828.169152-1-arnd@kernel.org/
Changes in v5:
- Rebase to v5.14-rc2
- Fix a few build issues
Changes in v4:
- build fix without CONFIG_INET
- build fix without CONFIG_COMPAT
- style fixes pointed out by hch
Changes in v3:
- complete rewrite of the series
Arnd Bergmann (4):
ethtool: improve compat ioctl handling
net: socket: rework SIOC?IFMAP ioctls
net: socket: simplify dev_ifconf handling
net: socket: rework compat_ifreq_ioctl()
include/linux/compat.h | 82 +++++------
include/linux/ethtool.h | 4 -
include/linux/inetdevice.h | 9 ++
include/linux/netdevice.h | 12 +-
net/appletalk/ddp.c | 4 +-
net/core/dev_ioctl.c | 152 ++++++++++---------
net/ethtool/ioctl.c | 136 +++++++++++++++--
net/ieee802154/socket.c | 4 +-
net/ipv4/af_inet.c | 6 +-
net/ipv4/devinet.c | 4 +-
net/qrtr/qrtr.c | 4 +-
net/socket.c | 292 +++++++++----------------------------
12 files changed, 333 insertions(+), 376 deletions(-)
--
2.29.2
next reply other threads:[~2021-07-20 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 14:24 Arnd Bergmann [this message]
2021-07-20 14:24 ` [PATCH v5 1/4] ethtool: improve compat ioctl handling Arnd Bergmann
2021-07-20 14:24 ` [PATCH v5 2/4] net: socket: rework SIOC?IFMAP ioctls Arnd Bergmann
2021-07-21 7:28 ` Christoph Hellwig
2021-07-21 8:32 ` Arnd Bergmann
2021-07-20 14:24 ` [PATCH v5 3/4] net: socket: simplify dev_ifconf handling Arnd Bergmann
2021-07-21 7:32 ` Christoph Hellwig
2021-07-21 9:12 ` Arnd Bergmann
2021-07-20 14:24 ` [PATCH v5 4/4] net: socket: rework compat_ifreq_ioctl() Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720142436.2096733-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.