From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1109 amdgpu_debugfs_gfxoff_read() warn: ignoring unreachable code.
Date: Tue, 20 Jul 2021 18:32:50 +0800 [thread overview]
Message-ID: <202107201842.HDFa4gHa-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5572 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: "Jinzhou.Su" <Jinzhou.Su@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>
CC: Evan Quan <evan.quan@amd.com>
CC: Huang Rui <ray.huang@amd.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2734d6c1b1a089fb593ef6a23d4b70903526fe0c
commit: 443c7f3c3641c790a7c306f9d9d54a2a5e3021b9 drm/amdgpu: add read amdgpu_gfxoff status in debugfs
date: 12 months ago
:::::: branch date: 2 days ago
:::::: commit date: 12 months ago
config: s390-randconfig-m031-20210720 (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1109 amdgpu_debugfs_gfxoff_read() warn: ignoring unreachable code.
Old smatch warnings:
arch/s390/include/asm/uaccess.h:143 __get_user_fn() error: uninitialized symbol 'rc'.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:355 amdgpu_debugfs_regs_pcie_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:474 amdgpu_debugfs_regs_didt_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:593 amdgpu_debugfs_regs_smc_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:748 amdgpu_debugfs_gca_config_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:826 amdgpu_debugfs_sensor_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:912 amdgpu_debugfs_wave_read() warn: ignoring unreachable code.
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1005 amdgpu_debugfs_gpr_read() warn: ignoring unreachable code.
vim +1109 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
669e2f91e4d11d Tom St Denis 2020-02-21 1074
669e2f91e4d11d Tom St Denis 2020-02-21 1075
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1076 /**
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1077 * amdgpu_debugfs_regs_gfxoff_status - read gfxoff status
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1078 *
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1079 * @f: open file handle
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1080 * @buf: User buffer to store read data in
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1081 * @size: Number of bytes to read
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1082 * @pos: Offset to seek to
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1083 */
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1084 static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf,
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1085 size_t size, loff_t *pos)
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1086 {
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1087 struct amdgpu_device *adev = file_inode(f)->i_private;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1088 ssize_t result = 0;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1089 int r;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1090
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1091 if (size & 0x3 || *pos & 0x3)
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1092 return -EINVAL;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1093
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1094 r = pm_runtime_get_sync(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1095 if (r < 0)
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1096 return r;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1097
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1098 while (size) {
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1099 uint32_t value;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1100
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1101 r = amdgpu_get_gfx_off_status(adev, &value);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1102 if (r) {
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1103 pm_runtime_mark_last_busy(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1104 pm_runtime_put_autosuspend(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1105 return r;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1106 }
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1107
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1108 r = put_user(value, (uint32_t *)buf);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 @1109 if (r) {
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1110 pm_runtime_mark_last_busy(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1111 pm_runtime_put_autosuspend(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1112 return r;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1113 }
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1114
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1115 result += 4;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1116 buf += 4;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1117 *pos += 4;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1118 size -= 4;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1119 }
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1120
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1121 pm_runtime_mark_last_busy(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1122 pm_runtime_put_autosuspend(adev->ddev->dev);
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1123
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1124 return result;
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1125 }
443c7f3c3641c7 Jinzhou.Su 2020-07-07 1126
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28417 bytes --]
next reply other threads:[~2021-07-20 10:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 10:32 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-28 23:17 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1109 amdgpu_debugfs_gfxoff_read() warn: ignoring unreachable code kernel test robot
2021-02-10 11:51 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107201842.HDFa4gHa-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.