From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dakshaja Uppalapati <dakshaja@chelsio.com>,
dledford@redhat.com, linux-rdma@vger.kernel.org,
bharat@chelsio.com
Subject: Re: [PATCH for-rc] iw_cxgb4: Fix refcount underflow while destroying cqs.
Date: Thu, 22 Jul 2021 10:02:31 -0300 [thread overview]
Message-ID: <20210722130231.GI1117491@nvidia.com> (raw)
In-Reply-To: <YPlrQ1Uu+OXxRJBF@unreal>
On Thu, Jul 22, 2021 at 03:57:39PM +0300, Leon Romanovsky wrote:
> We are talking about two different issues that this refcount_read patch pointed.
> You are focused on wrong usage of completion, I saw useless compare of
> refcount_t with 0 that can't be.
It can be zero. Anything that does refcount_dec_and_test() can make
the refcount be zero.
The issue here is that refcount_dec() cannot make the refcount zero as
it is improper use of the API.
Jason
next prev parent reply other threads:[~2021-07-22 13:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 11:21 [PATCH for-rc] iw_cxgb4: Fix refcount underflow while destroying cqs Dakshaja Uppalapati
2021-07-22 7:43 ` Leon Romanovsky
2021-07-22 12:06 ` Jason Gunthorpe
2021-07-22 12:57 ` Leon Romanovsky
2021-07-22 13:02 ` Jason Gunthorpe [this message]
2021-07-22 13:23 ` Dakshaja Uppalapati
2021-07-22 14:01 ` Leon Romanovsky
2021-07-22 14:02 ` Jason Gunthorpe
[not found] ` <20210803155919.GB11439@chelsio.com>
2021-08-03 16:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210722130231.GI1117491@nvidia.com \
--to=jgg@nvidia.com \
--cc=bharat@chelsio.com \
--cc=dakshaja@chelsio.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.