Re: [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Edmundo Ferreira <fc.edmundo@gmail.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Thijs Vermeir <thijsvermeir@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 31/35] package/x265: fixes SITE since upstream repo was moved
Date: Thu, 22 Jul 2021 23:07:38 +0200	[thread overview]
Message-ID: <20210722230738.57510350@windsurf> (raw)
In-Reply-To: <20210608202434.10092-1-edmundo.ferreira@esa.int>

Hello Edmundo,

On Tue,  8 Jun 2021 22:24:34 +0200
Edmundo Ferreira <fc.edmundo@gmail.com> wrote:

> From: Edmundo Ferreira <fc.edmundo@gmail.com>
> 
> Signed-off-by: Edmundo Ferreira <fc.edmundo@gmail.com>

Thanks a lot for your patch. There is indeed an issue as the current
URL gives a 404. However, your patch doesn't fix it really: the hash of
the tarball downloaded from this new URL is different, and so it gets
rejected, and we fallback to sources.buildroot.net. See:

>>> x265 3.3 Downloading
wget --passive-ftp -nd -t 3 -O '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output' 'https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz' 
--2021-07-22 23:02:55--  https://bitbucket.org/multicoreware/x265_git/downloads/x265_3.3.tar.gz
Resolving bitbucket.org (bitbucket.org)... 2406:da00:ff00::34cc:ea4a, 2406:da00:ff00::22c3:9b0a, 2406:da00:ff00::22c2:513, ...
Connecting to bitbucket.org (bitbucket.org)|2406:da00:ff00::34cc:ea4a|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None [following]
--2021-07-22 23:02:56--  https://bbuseruploads.s3.amazonaws.com/c105f477-2003-4e12-80e5-06858cf7e40b/downloads/4247de9f-1484-4e31-b9b8-f69a505230de/x265_3.3.tar.gz?Signature=GAYCnXeWIBn3w2FX%2FLeQnQ%2Bi2c8%3D&Expires=1626989576&AWSAccessKeyId=AKIA6KOSE3BNJRRFUUX6&versionId=s9fflFgseT2OEPm_eT1G33eu3G8q_RJ5&response-content-disposition=attachment%3B%20filename%3D%22x265_3.3.tar.gz%22&response-content-encoding=None
Resolving bbuseruploads.s3.amazonaws.com (bbuseruploads.s3.amazonaws.com)... 52.216.98.243
Connecting to bbuseruploads.s3.amazonaws.com (bbuseruploads.s3.amazonaws.com)|52.216.98.243|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1508513 (1,4M) [application/x-gzip]
Saving to: ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’

/home/thomas/projets/buildroo 100%[===============================================>]   1,44M   930KB/s    in 1,6s    

2021-07-22 23:02:59 (930 KB/s) - ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.YfSH95/output’ saved [1508513/1508513]

ERROR: x265_3.3.tar.gz has wrong md5 hash:
ERROR: expected: 0c8c747b59b5411dea8cf557554636c1
ERROR: got     : be6ea7a139b01fa6f2614d5c1197492d
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
wget --passive-ftp -nd -t 3 -O '/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output' 'http://sources.buildroot.net/x265/x265_3.3.tar.gz' 
--2021-07-22 23:02:59--  http://sources.buildroot.net/x265/x265_3.3.tar.gz
Resolving sources.buildroot.net (sources.buildroot.net)... 2606:4700:20::681a:125, 2606:4700:20::681a:25, 2606:4700:20::ac43:4838, ...
Connecting to sources.buildroot.net (sources.buildroot.net)|2606:4700:20::681a:125|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1438685 (1,4M) [application/x-gtar-compressed]
Saving to: ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’

/home/thomas/projets/buildroo 100%[===============================================>]   1,37M  1,12MB/s    in 1,2s    

2021-07-22 23:03:00 (1,12 MB/s) - ‘/home/thomas/projets/buildroot/output/build/.x265_3.3.tar.gz.N9OBTM/output’ saved [1438685/1438685]

x265_3.3.tar.gz: OK (md5: 0c8c747b59b5411dea8cf557554636c1)
x265_3.3.tar.gz: OK (sha256: f26e148ed1f4dfb33fd1eb3ff5e60e08078d1b2017e88bcbb045b3fb58300b9c)

Could you have a look? We can't simply change the hash, because that
would mean the tarball cached on sources.buildroot.net is no longer
valid. And we cannot delete it, as it would break older Buildroot
releases, which use the current hash for the x265 tarball.

Usually, the easiest path is to update the URL *and* do a version bump
at the same time.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot