From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBAF4C4338F for ; Fri, 23 Jul 2021 06:07:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6100260E8B for ; Fri, 23 Jul 2021 06:07:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6100260E8B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LzO3PhxPsBftzKEwKgO+8u7qiJpldZ92QmThWg9c21g=; b=EzUv0zn53MVCiC hMkLP/KzXWQk57HsajVptKhxdn4i3gWRJEyJG7IGW7NuLuKRut7M+SuY3rMzlHsKDGHSBBZrqoN0e ZjIZeps3SzUqw1U5CmgXGjxJou5fI3SxyXOCHqClhG6JkuldHz6fxJVzYKJkMGBepmsy/TEZ/RIlB yXEkTk0/Zk0cvAoXMUtGZTsIFH1mxIhjbIOlA3GExNP3V9Abud0Aqw9yuiQv7TirJ5+lXVwaDTTeW CbiXSpSGHLdrJwF2pxEw9xUXMQsLhwQmGRJcPH9z1rqctIEeKV/lUM8h7mOBPSwdEz/PT8ub9u5Pe sCOrTVuHezlulj6ww1+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6oKV-003V6s-23; Fri, 23 Jul 2021 06:06:39 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6oKR-003V6I-A6 for linux-nvme@lists.infradead.org; Fri, 23 Jul 2021 06:06:36 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 6DA4A67373; Fri, 23 Jul 2021 08:06:31 +0200 (CEST) Date: Fri, 23 Jul 2021 08:06:31 +0200 From: Christoph Hellwig To: Boris Pismenny Cc: dsahern@gmail.com, kuba@kernel.org, davem@davemloft.net, saeedm@nvidia.com, hch@lst.de, sagi@grimberg.me, axboe@fb.com, kbusch@kernel.org, viro@zeniv.linux.org.uk, edumazet@google.com, smalin@marvell.com, boris.pismenny@gmail.com, linux-nvme@lists.infradead.org, netdev@vger.kernel.org, benishay@nvidia.com, ogerlitz@nvidia.com, yorayz@nvidia.com, Boris Pismenny Subject: Re: [PATCH v5 net-next 04/36] net/tls: expose get_netdev_for_sock Message-ID: <20210723060631.GA32369@lst.de> References: <20210722110325.371-1-borisp@nvidia.com> <20210722110325.371-5-borisp@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210722110325.371-5-borisp@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_230635_544232_AA26D939 X-CRM114-Status: GOOD ( 12.88 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Thu, Jul 22, 2021 at 02:02:53PM +0300, Boris Pismenny wrote: > From: Boris Pismenny > > get_netdev_for_sock is a utility that is used to obtain > the net_device structure from a connected socket. > > Later patches will use this for nvme-tcp DDP and DDP DDGST offloads. > > Signed-off-by: Boris Pismenny > Reviewed-by: Sagi Grimberg I don't think this should be an inline. Please move it to net/core/dev.c, andd add an EXPORT_SYMBOL_GPL and a kerneldoc comment. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme