All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
	<Michael.Hennerich@analog.com>, <alexandru.ardelean@analog.com>,
	<jic23@kernel.org>, <devicetree@vger.kernel.org>,
	<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<lars@metafoo.de>, <Dragos.Bogdan@analog.com>,
	<Darius.Berghe@analog.com>
Subject: Re: [PATCH v2 2/2] iio: accel: Add driver support for ADXL355
Date: Fri, 23 Jul 2021 18:44:04 +0100	[thread overview]
Message-ID: <20210723184404.0000001d@Huawei.com> (raw)
In-Reply-To: <20210723171422.GK5221@sirena.org.uk>

On Fri, 23 Jul 2021 18:14:22 +0100
Mark Brown <broonie@kernel.org> wrote:

> On Fri, Jul 23, 2021 at 06:10:22PM +0100, Jonathan Cameron wrote:
> 
> > @Mark.  This has come up a few times recently.  Are we now safe to assume
> > that regmap will always copy data when used with SPI and hence we no
> > longer need to ensure DMA safe buffers?     
> 
> Only for single register I/O, I'd not assume that for things like raw
> I/O.

Thanks for the confirmation.  So in this driver that means we
need DMA safe buffers for the regmap_bulk_ calls.  Easiest approach
is probably to use a __cacheline_aligned buffer at the end of the
iio_priv() structure.

> 
> Note that my name is spelt Mark.
> 

I'll blame Friday.

Thanks,

Jonathan



  reply	other threads:[~2021-07-23 17:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22  6:21 [PATCH v2 0/2] iio: accel: add support for ADXL355 Puranjay Mohan
2021-07-22  6:21 ` [PATCH v2 1/2] dt-bindings: iio: accel: Add ADXL355 in trivial-devices Puranjay Mohan
2021-07-23 16:29   ` Jonathan Cameron
2021-07-24 15:46     ` Puranjay Mohan
2021-07-22  6:21 ` [PATCH v2 2/2] iio: accel: Add driver support for ADXL355 Puranjay Mohan
2021-07-22  7:10   ` Alexandru Ardelean
2021-07-23 16:28     ` Jonathan Cameron
2021-07-23 17:10   ` Jonathan Cameron
2021-07-23 17:14     ` Mark Brown
2021-07-23 17:44       ` Jonathan Cameron [this message]
2021-07-23 17:47         ` Mark Brown
2021-07-24 15:53     ` Puranjay Mohan
2021-07-25 15:17       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723184404.0000001d@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Darius.Berghe@analog.com \
    --cc=Dragos.Bogdan@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=puranjay12@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.