From: David Sterba <dsterba@suse.cz>
To: Roman Mamedov <rm@romanrm.net>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: allow degenerate raid0/raid10
Date: Fri, 23 Jul 2021 21:21:45 +0200 [thread overview]
Message-ID: <20210723192145.GF19710@suse.cz> (raw)
In-Reply-To: <20210723222730.1d23f9b4@natsu>
On Fri, Jul 23, 2021 at 10:27:30PM +0500, Roman Mamedov wrote:
> On Fri, 23 Jul 2021 16:08:43 +0200
> David Sterba <dsterba@suse.cz> wrote:
>
> > > Can we slightly enhance the output?
> > > RAID0/1 really looks like a new profile now, even the "1" really means
> > > the number of device.
> >
> > Do you have a concrete suggestion? This format was inspired by a
> > discussion and suggested by users so I guess this is what people expect
> > and I find it clear. It's also documented in manual page so if you think
> > it's not clear or missing some important information, please let me
> > know.
>
> It really reads like another RAID level, easily confused with RAID10.
>
> Or that it would flip between RAID0 and RAID1 depending on something.
I think it could be confusing when the number of stripes is also another
raid level, like /1 in this case. From the commit
https://github.com/kdave/btrfs-progs/commit/4693e8226140289dcf8f0932af05895a38152817
/dev/vdc, ID: 1
Device size: 1.00GiB
Device slack: 0.00B
Data,RAID0/2: 912.62MiB
Data,RAID0/3: 912.62MiB
Metadata,RAID1: 102.38MiB
System,RAID1: 8.00MiB
Unallocated: 1.00MiB
it's IMHO clear or at least prompting to read the docs what it means.
> Maybe something like RAID0d1?
That looks similar to RAID1c3 which I'd interpret as a new profile as
well. The raid56 profiles also print the stripe count so I don't know if
eg. RAID5d4 is really an improvement.
A 4 device mix of raid56 data and metadata would look like:
# btrfs dev us .
/dev/sda10, ID: 1
Device size: 10.00GiB
Device slack: 0.00B
Data,RAID5/4: 1.00GiB
Metadata,RAID6/4: 64.00MiB
System,RAID6/4: 8.00MiB
Unallocated: 8.93GiB
/dev/sda11, ID: 2
Device size: 10.00GiB
Device slack: 0.00B
Data,RAID5/4: 1.00GiB
Metadata,RAID6/4: 64.00MiB
System,RAID6/4: 8.00MiB
Unallocated: 8.93GiB
/dev/sda12, ID: 3
Device size: 10.00GiB
Device slack: 0.00B
Data,RAID5/4: 1.00GiB
Metadata,RAID6/4: 64.00MiB
System,RAID6/4: 8.00MiB
Unallocated: 8.93GiB
/dev/sda13, ID: 4
Device size: 10.00GiB
Device slack: 0.00B
Data,RAID5/4: 1.00GiB
Metadata,RAID6/4: 64.00MiB
System,RAID6/4: 8.00MiB
Unallocated: 8.93GiB
Maybe it's still too new so nobody is used to it and we've always had
problems with the raid naming scheme anyway.
next prev parent reply other threads:[~2021-07-23 19:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 19:29 [PATCH] btrfs: allow degenerate raid0/raid10 David Sterba
2021-07-22 22:51 ` Qu Wenruo
2021-07-23 14:08 ` David Sterba
2021-07-23 17:27 ` Roman Mamedov
2021-07-23 19:21 ` David Sterba [this message]
2021-07-24 11:04 ` waxhead
2021-07-24 11:24 ` Hugo Mills
2021-07-24 11:49 ` waxhead
2021-07-24 11:55 ` Hugo Mills
2021-07-24 12:07 ` waxhead
2021-07-24 12:30 ` Hugo Mills
2021-07-24 13:54 ` Forza
2021-07-24 21:15 ` Zygo Blaxell
2021-07-24 22:25 ` waxhead
2021-07-23 22:35 ` Qu Wenruo
2021-07-24 21:31 ` Zygo Blaxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723192145.GF19710@suse.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=rm@romanrm.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.