Re: [Buildroot] [PATCH] Fix restorecond startup for sysvinit builds

From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: "José Pekkarinen" <jose.pekkarinen@unikie.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH] Fix restorecond startup for sysvinit builds
Date: Sat, 24 Jul 2021 23:36:27 +0200	[thread overview]
Message-ID: <20210724233627.25e8ab13@windsurf> (raw)
In-Reply-To: <20210723124754.46568-1-jose.pekkarinen@unikie.com>

On Fri, 23 Jul 2021 15:47:54 +0300
José Pekkarinen <jose.pekkarinen@unikie.com> wrote:

> Currently restorecond init script sources the
> file /etc/rc.d/init.d/functions, that in some
> init systems, like sysvinit, may not be available,
> however, it doesn't actually uses any function
> from it.
> 
> Also, the init script uses daemon, that is not
> marked as a dependency. So this patches adds its
> dependency to guarantee it's present in the build.
> 
> Signed-off-by: José Pekkarinen <jose.pekkarinen@unikie.com>

Thanks for this patch. However, if we are going to use our own init
script for restorecond, it should follow our "model" for init scripts,
package/busybox/S01syslogd. This means it should use start-stop-daemon,
instead of daemon, if possible.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot