Re: [PATCH net-next] devlink: Remove duplicated registration check

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3283 bytes --]

Hi Leon,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Leon-Romanovsky/devlink-Remove-duplicated-registration-check/20210725-202618
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cc19862ffe454a5b632ca202e5a51bfec9f89fd2
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2e93956fb49369674f9230f43f27c140fe4d277a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Leon-Romanovsky/devlink-Remove-duplicated-registration-check/20210725-202618
        git checkout 2e93956fb49369674f9230f43f27c140fe4d277a
        # save the attached .config to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c: In function 'mlx5e_devlink_port_unregister':
>> drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c:58:13: error: 'struct devlink_port' has no member named 'registered'
      58 |  if (dl_port->registered)
         |             ^~
   drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c: In function 'mlx5e_get_devlink_port':
   drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c:70:10: error: 'struct devlink_port' has no member named 'registered'
      70 |  if (port->registered)
         |          ^~
--
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_nic_init':
>> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:4954:13: error: 'struct devlink_port' has no member named 'registered'
    4954 |  if (dl_port->registered)
         |             ^~
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_nic_cleanup':
   drivers/net/ethernet/mellanox/mlx5/core/en_main.c:4964:13: error: 'struct devlink_port' has no member named 'registered'
    4964 |  if (dl_port->registered)
         |             ^~


vim +58 drivers/net/ethernet/mellanox/mlx5/core/en/devlink.c

c6acd629eec754 Vladyslav Tarasiuk 2019-11-13  53  
162add8cbae463 Parav Pandit       2020-03-03  54  void mlx5e_devlink_port_unregister(struct mlx5e_priv *priv)
c6acd629eec754 Vladyslav Tarasiuk 2019-11-13  55  {
c27971d08abecc Roi Dayan          2020-10-28  56  	struct devlink_port *dl_port = mlx5e_devlink_get_dl_port(priv);
c27971d08abecc Roi Dayan          2020-10-28  57  
6a5689ba0259ac Vladyslav Tarasiuk 2021-04-13 @58  	if (dl_port->registered)
c27971d08abecc Roi Dayan          2020-10-28  59  		devlink_port_unregister(dl_port);
c6acd629eec754 Vladyslav Tarasiuk 2019-11-13  60  }
c6acd629eec754 Vladyslav Tarasiuk 2019-11-13  61  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68211 bytes --]