From: Dan Carpenter <dan.carpenter@oracle.com>
To: miquel.raynal@bootlin.com
Cc: linux-i3c@lists.infradead.org
Subject: [bug report] i3c: master: svc: Add Silvaco I3C master driver
Date: Mon, 26 Jul 2021 10:33:19 +0300 [thread overview]
Message-ID: <20210726073319.GA9515@kili> (raw)
Hello Miquel Raynal,
The patch dd3c52846d59: "i3c: master: svc: Add Silvaco I3C master
driver" from Jan 21, 2021, leads to the following static checker
warning:
drivers/i3c/master/svc-i3c-master.c:690 svc_i3c_master_do_daa_locked()
warn: sleeping in atomic context
drivers/i3c/master/svc-i3c-master.c
670 static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master,
671 u8 *addrs, unsigned int *count)
672 {
673 u64 prov_id[SVC_I3C_MAX_DEVS] = {}, nacking_prov_id = 0;
674 unsigned int dev_nb = 0, last_addr = 0;
675 u32 reg;
676 int ret, i;
677
678 while (true) {
679 /* Enter/proceed with DAA */
680 writel(SVC_I3C_MCTRL_REQUEST_PROC_DAA |
681 SVC_I3C_MCTRL_TYPE_I3C |
682 SVC_I3C_MCTRL_IBIRESP_NACK |
683 SVC_I3C_MCTRL_DIR(SVC_I3C_MCTRL_DIR_WRITE),
684 master->regs + SVC_I3C_MCTRL);
685
686 /*
687 * Either one slave will send its ID, or the assignment process
688 * is done.
689 */
--> 690 ret = readl_poll_timeout(master->regs + SVC_I3C_MSTATUS, reg,
691 SVC_I3C_MSTATUS_RXPEND(reg) |
692 SVC_I3C_MSTATUS_MCTRLDONE(reg),
693 1, 1000);
^
This is called with a lock held and the code is doing a 1 us sleep.
694 if (ret)
695 return ret;
696
regards,
dan carpenter
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next reply other threads:[~2021-07-26 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 7:33 Dan Carpenter [this message]
2021-07-26 8:48 ` [bug report] i3c: master: svc: Add Silvaco I3C master driver Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2021-02-09 10:57 Dan Carpenter
2021-02-16 15:21 ` Miquel Raynal
2021-02-16 18:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726073319.GA9515@kili \
--to=dan.carpenter@oracle.com \
--cc=linux-i3c@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.