From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB085C4338F for ; Tue, 27 Jul 2021 11:29:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AEFE619E5 for ; Tue, 27 Jul 2021 11:29:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5AEFE619E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8LGl-0003aE-9H for qemu-devel@archiver.kernel.org; Tue, 27 Jul 2021 07:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8LG3-0002uY-Db for qemu-devel@nongnu.org; Tue, 27 Jul 2021 07:28:23 -0400 Received: from mail-oo1-xc36.google.com ([2607:f8b0:4864:20::c36]:45630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m8LG1-00071T-Mo for qemu-devel@nongnu.org; Tue, 27 Jul 2021 07:28:23 -0400 Received: by mail-oo1-xc36.google.com with SMTP id s21-20020a4ae5550000b02902667598672bso2995230oot.12 for ; Tue, 27 Jul 2021 04:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:reply-to:references :mime-version:content-disposition:in-reply-to; bh=gvAclqr6IVogEKIBs1tfR8U3aqTBhmg96ioRHafCBlw=; b=vgZYmkjRJV/3fhjRP756u1cMdfTp0CoQaqukKeJz1rlcXLjKSqu1dtqMzlNbJ0pAv2 vAuOI4O/nlBH8Y0M3vsYaW/8Wf3cqrwpqedtATiF1SnlBs6KcR/fMvm04+vRxT75jWfL h2MYcCVC1T3/N2QT0mAr97D/pS97XdD9GHx5GwLiCarmcy9JQuQmSo+Wxup3orzb9J88 2wmujtGlg1/hbGdR2wD2Fr744DK1Z+CQ7nmPiypXnur3oKq8h3rzsxAJWy3mPLPd3dxN +uFMikjPqcx9ezP/1e2H9QPiaWrxAgzaEt3XcFqLPT2RWPR3UCNSwS/ZUjb/sD2Do14Q u62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :reply-to:references:mime-version:content-disposition:in-reply-to; bh=gvAclqr6IVogEKIBs1tfR8U3aqTBhmg96ioRHafCBlw=; b=bWqdPrSbVn9suz+Cdjxen2F6/In/Ms2kvXaypMXqqa5bBxrU6uI8Q5XoFqFdY0TcjM L+c8OF45y/OStQpteU1NrZpCkmKSGydYCHx+aTLdgDgDWP7So0V/8xQ+mFSvbpTDxEvT gF1fj8BpmibXMHu0I1E2O1Y0Hzx5pK5NEH1/z059kW6xs7VEv8YuuTTWBGPBEZ1ShUcu GbTx1eVK8w4JJBkGXEI8W1OOfZkeRenahLkQHG902aUCvYrgfoIRnhprXRtJq/39HCj2 CCLmaZpQvhBGR2fcxP4ybARhfpHVY5XD61PvRr9Qgm8RPE9qfShl1oS1faOlMGKA8d/P 5AnQ== X-Gm-Message-State: AOAM532vU+3a3XA8vDwU5+Ns/HuN/nLaI6nZH0nvOjK5mej+mkMj9Qge jgQI6Xm9dZcwLavPE/JBvQ== X-Google-Smtp-Source: ABdhPJwRnZQGXsC43OvOOQmsTgLdxY2xyuXmNxUNedZrpMdipqhB2z26zcVIqHeqQmAjnt4EHd6mMA== X-Received: by 2002:a4a:7651:: with SMTP id w17mr13279539ooe.38.1627385299495; Tue, 27 Jul 2021 04:28:19 -0700 (PDT) Received: from serve.minyard.net ([47.184.156.158]) by smtp.gmail.com with ESMTPSA id d7sm423850oon.18.2021.07.27.04.28.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 04:28:18 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:b0e5:c1ad:46f6:254a]) by serve.minyard.net (Postfix) with ESMTPSA id 99B201800D4; Tue, 27 Jul 2021 11:28:17 +0000 (UTC) Date: Tue, 27 Jul 2021 06:28:16 -0500 From: Corey Minyard To: Peter Maydell Subject: Re: QEMU question: upstreaming I2C device with unpublished datasheet Message-ID: <20210727112816.GU3406@minyard.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::c36; envelope-from=tcminyard@gmail.com; helo=mail-oo1-xc36.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: Hao Wu , Patrick Venture , Shengtan Mao , QEMU Developers , Chris Rauer Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 27, 2021 at 10:23:26AM +0100, Peter Maydell wrote: > On Wed, 21 Jul 2021 at 22:06, Shengtan Mao wrote: > > > > Hi everyone, > > we are hoping to upstream a MAX I2C device to QEMU. The device's datasheet is not public, and we are contacting the Maxim company to get their permission. If Maxim is okay with upstreaming the device with an unpublished datasheet, will this still be an issue with QEMU? > > It's not inherently a blocker, but the difficulty is code review. > Without knowing how the device should behave, it's hard to tell > whether the model is doing the right thing. Ideally Maxim should > just publish their datasheet, so if you/your company has any > leverage with them you should push them to do that :-) > > That said, we do have other device models in the tree which > don't have public datasheets, and as long as the device is not > too complicated we should be OK as long as you can also submit > enough test cases that we could refactor the device in future > without worrying too much that we're breaking it because we don't > know how it's supposed to behave. Thanks Peter. I will add that you need to be sure you have the legal right to publish the software. If you have a non-public datasheet, that probably means you had to sign NDA or something like that to see it. That may limit what you can do. -corey