From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [drm-intel:drm-intel-gt-next 8/8] drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:189 i915_gem_dmabuf_attach() error: uninitialized symbol 'err'.
Date: Tue, 27 Jul 2021 12:27:51 +0800 [thread overview]
Message-ID: <202107271235.G45ct7KM-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4791 bytes --]
CC: kbuild-all(a)lists.01.org
CC: intel-gfx(a)lists.freedesktop.org
CC: dri-devel(a)lists.freedesktop.org
TO: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
CC: Matthew Auld <matthew.auld@intel.com>
CC: "Michael J. Ruhl" <michael.j.ruhl@intel.com>
CC: Jason Ekstrand <jason@jlekstrand.net>
tree: git://anongit.freedesktop.org/drm-intel drm-intel-gt-next
head: cdb35d1ed6d216978521b75927acb3b8c50a6cac
commit: cdb35d1ed6d216978521b75927acb3b8c50a6cac [8/8] drm/i915/gem: Migrate to system at dma-buf attach time (v7)
:::::: branch date: 13 hours ago
:::::: commit date: 13 hours ago
config: x86_64-randconfig-m001-20210726 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:189 i915_gem_dmabuf_attach() error: uninitialized symbol 'err'.
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:189 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 178)
vim +/err +189 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c
346400c8010791 drivers/gpu/drm/i915/i915_gem_dmabuf.c Tiago Vignatti 2015-12-22 162
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 163 static int i915_gem_dmabuf_attach(struct dma_buf *dmabuf,
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 164 struct dma_buf_attachment *attach)
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 165 {
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 166 struct drm_i915_gem_object *obj = dma_buf_to_obj(dmabuf);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 167 struct i915_gem_ww_ctx ww;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 168 int err;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 169
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 170 if (!i915_gem_object_can_migrate(obj, INTEL_REGION_SMEM))
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 171 return -EOPNOTSUPP;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 172
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 173 for_i915_gem_ww(&ww, err, true) {
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 174 err = i915_gem_object_lock(obj, &ww);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 175 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 176 continue;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 177
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 178 err = i915_gem_object_migrate(obj, &ww, INTEL_REGION_SMEM);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 179 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 180 continue;
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 181
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 182 err = i915_gem_object_wait_migration(obj, 0);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 183 if (err)
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 184 continue;
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 185
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 186 err = i915_gem_object_pin_pages(obj);
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 187 }
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 188
cdb35d1ed6d216 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 @189 return err;
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 190 }
d7b2cb380b3a67 drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c Thomas Hellström 2021-07-23 191
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37509 bytes --]
reply other threads:[~2021-07-27 4:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202107271235.G45ct7KM-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.