Re: [bitbake-devel] [PATCH v4 0/5] Re-implement prserv on top of asyncrpc

["Paul Barker" <paul@pbarker.dev>]

[-- Attachment #1: Type: text/plain, Size: 2811 bytes --]

On Tue, 27 Jul 2021 13:28:30 +0100
"Richard Purdie" <richard.purdie@linuxfoundation.org> wrote:

> On Tue, 2021-07-27 at 13:26 +0100, Richard Purdie via lists.openembedded.org wrote:
> > On Mon, 2021-07-26 at 22:37 -0400, Scott Murray wrote:  
> > > These changes replace the old XML-based RPC system in prserv with the
> > > new asyncrpc implementation originally used by hashserv, and add a
> > > read-only mode to match the hash equivalency server's support.
> > > 
> > > Changes from v3:
> > >   * Scott Murray taking over upstreaming effort from Paul Barker.
> > > 
> > >   * Dropped patches which are currently applied to master-next, this
> > >     series should be applied on top of the current master-next branch.
> > > 
> > >   * Patches 2-4 updated by Scott Murray to rebase on top of 3983643
> > >     ("bitbake: asyncrpc: Catch early SIGTERM").
> > > 
> > >   * Read-only PR server support patch added to stack to get it into
> > >     the review process.
> > > 
> > > Paul Barker (5):
> > >   asyncrpc: Wait on writers to close with Python 3.7+
> > >   asyncrpc: Ensure that asyncio shutdown is clean
> > >   asyncrpc: Handle exceptions
> > >   prserv: Replace XML RPC with modern asyncrpc implementation
> > >   prserv: Add read-only mode  
> > 
> > There is an odd failure on the autobuilder which seems related to this.
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/75/builds/3746
> > 
> > and looking at the bitbake-cookerdaemon.log:
> > 
> > 1958 12:03:42.046562 Running command ['clientComplete']
> > 1958 12:03:42.046659 Command Completed
> > 1958 12:03:42.047003 Processing Client
> > 1958 12:03:42.047061 Disconnecting Client
> > 1958 12:03:42.047215 No timeout, exiting.
> > 1958 12:03:42.147541 Exiting
> > Caught exception: type object '_asyncio.Task' has no attribute 'all_tasks'
> > Caught exception: type object '_asyncio.Task' has no attribute 'all_tasks'
> > Caught exception: type object '_asyncio.Task' has no attribute 'all_tasks'
> > Caught exception: type object '_asyncio.Task' has no attribute 'all_tasks'
> > 
> > with this last line repeating a 'lot' (log is over 1GB in size).  
> 
> I should add, this is after the bitbake-layers command used to add the layer during
> the setup of that build. The later command just times out as the server process
> remains and is locked up.

What's the Python version there? I've just re-checked the docs for
asyncio.Task.all_tasks():

    This method is deprecated and will be removed in Python 3.9. Use the
    asyncio.all_tasks() function instead.

asyncio.all_tasks() was added in Python 3.7. So we need to use
asyncio.Task.all_tasks() before 3.7, asyncio.all_tasks() after 3.7.

-- 
Paul Barker
https://pbarker.dev/

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 235 bytes --]