All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, armbru@redhat.com, mreitz@redhat.com,
	kwolf@redhat.com, vsementsov@virtuozzo.com, jsnow@redhat.com
Subject: [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror
Date: Tue, 27 Jul 2021 19:47:51 +0300	[thread overview]
Message-ID: <20210727164754.62895-1-vsementsov@virtuozzo.com> (raw)

Hi all!

That's an alternative to (part of) Max's
"[PATCH for-6.1? v2 0/7] mirror: Handle errors after READY cancel"
and shows' my idea of handling soft-cancelling READY mirror case
directly in qmp_block_job_cancel. And cleanup all other job cancelling
functions.

That's untested draft, don't take it to heart :)

Vladimir Sementsov-Ogievskiy (3):
  job: add job_complete_ex with do_graph_change argument
  job: use complete(do_graph_change=false) to handle soft cancel
  job: drop force argument of *job*cancel

 include/qemu/job.h               | 19 ++++++++----------
 block/backup.c                   |  2 +-
 block/mirror.c                   | 33 +++++++++++++++++---------------
 blockdev.c                       | 13 +++++++++++--
 job-qmp.c                        |  2 +-
 job.c                            | 27 ++++++++++++++------------
 tests/unit/test-bdrv-drain.c     |  2 +-
 tests/unit/test-block-iothread.c |  2 +-
 tests/unit/test-blockjob-txn.c   |  8 ++++----
 tests/unit/test-blockjob.c       |  4 ++--
 10 files changed, 62 insertions(+), 50 deletions(-)

-- 
2.29.2



             reply	other threads:[~2021-07-27 16:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 16:47 Vladimir Sementsov-Ogievskiy [this message]
2021-07-27 16:47 ` [PATCH 1/3] job: add job_complete_ex with do_graph_change argument Vladimir Sementsov-Ogievskiy
2021-07-27 16:47 ` [PATCH 2/3] job: use complete(do_graph_change=false) to handle soft cancel Vladimir Sementsov-Ogievskiy
2021-07-27 16:47 ` [PATCH 3/3] job: drop force argument of *job*cancel Vladimir Sementsov-Ogievskiy
2021-07-27 16:56 ` [PATCH RFC 0/3] mirror: rework soft-cancelling READY mirror Vladimir Sementsov-Ogievskiy
2021-07-28  7:00 ` Max Reitz
2021-07-29 10:02   ` Vladimir Sementsov-Ogievskiy
2021-07-29 10:38     ` Max Reitz
2021-07-29 11:35       ` Vladimir Sementsov-Ogievskiy
2021-07-29 13:47         ` Max Reitz
2021-07-29 16:29           ` Vladimir Sementsov-Ogievskiy
2021-07-30 15:11             ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210727164754.62895-1-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.